summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaksym Hazevych <mhazevych@proton.me>2023-01-11 20:28:24 +0200
committerRobert Ancell <robert.ancell@canonical.com>2023-03-29 14:26:55 +1300
commite00f773b2fe555d5f18ec0306e59e10edb946bf9 (patch)
treeb5bc7acac8fb214c7cd1949a70071a68073f2bdd
parent5b988a69435b1bea5e5facbc79ab5dfed81827be (diff)
downloadgnome-control-center-e00f773b2fe555d5f18ec0306e59e10edb946bf9.tar.gz
Remove unnecessary visibility change
-rw-r--r--panels/color/cc-color-calibrate.c3
-rw-r--r--panels/color/cc-color-device.c1
-rw-r--r--panels/common/cc-language-chooser.c1
-rw-r--r--panels/keyboard/cc-input-chooser.c2
-rw-r--r--panels/keyboard/cc-input-list-box.c1
-rw-r--r--panels/network/cc-wifi-panel.c1
-rw-r--r--panels/printers/cc-printers-panel.c1
-rw-r--r--panels/printers/pp-options-dialog.c1
-rw-r--r--panels/printers/pp-ppd-selection-dialog.c1
-rw-r--r--panels/user-accounts/cc-avatar-chooser.c2
-rw-r--r--panels/wacom/calibrator/calibrator-gui.c1
-rw-r--r--panels/wacom/cc-wacom-button-row.c2
-rw-r--r--panels/wacom/test-wacom.c1
-rw-r--r--panels/wwan/cc-wwan-mode-dialog.c1
-rw-r--r--panels/wwan/cc-wwan-network-dialog.c1
15 files changed, 0 insertions, 20 deletions
diff --git a/panels/color/cc-color-calibrate.c b/panels/color/cc-color-calibrate.c
index 6a5c17bf9..30d56d590 100644
--- a/panels/color/cc-color-calibrate.c
+++ b/panels/color/cc-color-calibrate.c
@@ -442,7 +442,6 @@ cc_color_calibrate_finished (CcColorCalibrate *calibrate,
gtk_widget_set_visible (widget, FALSE);
widget = GTK_WIDGET (gtk_builder_get_object (calibrate->builder,
"button_done"));
- gtk_widget_set_visible (widget, TRUE);
str = g_string_new ("");
if (code == CD_SESSION_ERROR_NONE)
@@ -866,10 +865,8 @@ cc_color_calibrate_start (CcColorCalibrate *calibrate,
/* show correct buttons */
widget = GTK_WIDGET (gtk_builder_get_object (calibrate->builder,
"button_cancel"));
- gtk_widget_set_visible (widget, TRUE);
widget = GTK_WIDGET (gtk_builder_get_object (calibrate->builder,
"button_start"));
- gtk_widget_set_visible (widget, TRUE);
widget = GTK_WIDGET (gtk_builder_get_object (calibrate->builder,
"button_resume"));
gtk_widget_set_visible (widget, FALSE);
diff --git a/panels/color/cc-color-device.c b/panels/color/cc-color-device.c
index 9ccb3d369..4f1f05ec6 100644
--- a/panels/color/cc-color-device.c
+++ b/panels/color/cc-color-device.c
@@ -281,7 +281,6 @@ cc_color_device_init (CcColorDevice *color_device)
gtk_widget_set_valign (color_device->widget_button, GTK_ALIGN_CENTER);
gtk_widget_add_css_class (color_device->widget_button, "flat");
gtk_button_set_child (GTK_BUTTON (color_device->widget_button), color_device->widget_arrow);
- gtk_widget_set_visible (color_device->widget_arrow, TRUE);
gtk_widget_set_margin_top (color_device->widget_button, 9);
gtk_widget_set_margin_bottom (color_device->widget_button, 9);
gtk_widget_set_margin_end (color_device->widget_button, 12);
diff --git a/panels/common/cc-language-chooser.c b/panels/common/cc-language-chooser.c
index 42b9a261c..366117de8 100644
--- a/panels/common/cc-language-chooser.c
+++ b/panels/common/cc-language-chooser.c
@@ -68,7 +68,6 @@ add_all_languages (CcLanguageChooser *self)
continue;
row = cc_language_row_new (locale_ids[i]);
- gtk_widget_set_visible (GTK_WIDGET (row), TRUE);
is_initial = (g_hash_table_lookup (initial, locale_ids[i]) != NULL);
cc_language_row_set_is_extra (row, !is_initial);
gtk_list_box_prepend (self->language_listbox, GTK_WIDGET (row));
diff --git a/panels/keyboard/cc-input-chooser.c b/panels/keyboard/cc-input-chooser.c
index bce696dc9..1030cee04 100644
--- a/panels/keyboard/cc-input-chooser.c
+++ b/panels/keyboard/cc-input-chooser.c
@@ -680,7 +680,6 @@ add_default_row (CcInputChooser *self,
info->default_input_source_row = input_source_row_new (self, type, id);
if (info->default_input_source_row)
{
- gtk_widget_set_visible (GTK_WIDGET (info->default_input_source_row), TRUE);
g_object_ref_sink (GTK_WIDGET (info->default_input_source_row));
g_object_set_data (G_OBJECT (info->default_input_source_row), "default", GINT_TO_POINTER (TRUE));
g_object_set_data (G_OBJECT (info->default_input_source_row), "locale-info", info);
@@ -713,7 +712,6 @@ add_rows_to_table (CcInputChooser *self,
if (g_strcmp0 (id, default_id))
{
row = input_source_row_new (self, type, id);
- gtk_widget_set_visible (GTK_WIDGET (row), TRUE);
if (row)
{
g_object_set_data (G_OBJECT (row), "locale-info", info);
diff --git a/panels/keyboard/cc-input-list-box.c b/panels/keyboard/cc-input-list-box.c
index 09a7d6e74..ef94e83c3 100644
--- a/panels/keyboard/cc-input-list-box.c
+++ b/panels/keyboard/cc-input-list-box.c
@@ -300,7 +300,6 @@ add_input_row (CcInputListBox *self, CcInputSource *source)
gtk_widget_set_visible (GTK_WIDGET (self->no_inputs_row), FALSE);
row = cc_input_row_new (source);
- gtk_widget_set_visible (GTK_WIDGET (row), TRUE);
g_signal_connect_object (row, "show-settings", G_CALLBACK (row_settings_cb), self, G_CONNECT_SWAPPED);
g_signal_connect_object (row, "show-layout", G_CALLBACK (row_layout_cb), self, G_CONNECT_SWAPPED);
g_signal_connect_object (row, "move-row", G_CALLBACK (row_moved_cb), self, G_CONNECT_SWAPPED);
diff --git a/panels/network/cc-wifi-panel.c b/panels/network/cc-wifi-panel.c
index 8f9d61fe3..bf1589f4f 100644
--- a/panels/network/cc-wifi-panel.c
+++ b/panels/network/cc-wifi-panel.c
@@ -238,7 +238,6 @@ add_wifi_device (CcWifiPanel *self,
net_device = net_device_wifi_new (CC_PANEL (self),
self->client,
device);
- gtk_widget_set_visible (GTK_WIDGET (net_device), TRUE);
/* And add to the header widgets */
header_widget = net_device_wifi_get_header_widget (net_device);
diff --git a/panels/printers/cc-printers-panel.c b/panels/printers/cc-printers-panel.c
index e95040faa..6ec893449 100644
--- a/panels/printers/cc-printers-panel.c
+++ b/panels/printers/cc-printers-panel.c
@@ -724,7 +724,6 @@ add_printer_entry (CcPrintersPanel *self,
content = (GtkWidget*) gtk_builder_get_object (self->builder, "content");
printer_entry = pp_printer_entry_new (printer, self->is_authorized);
- gtk_widget_set_visible (GTK_WIDGET (printer_entry), TRUE);
widgets = pp_printer_entry_get_size_group_widgets (printer_entry);
for (l = widgets; l != NULL; l = l->next)
diff --git a/panels/printers/pp-options-dialog.c b/panels/printers/pp-options-dialog.c
index b322684f2..35dc560f2 100644
--- a/panels/printers/pp-options-dialog.c
+++ b/panels/printers/pp-options-dialog.c
@@ -346,7 +346,6 @@ ipp_option_add (IPPAttribute *attr_supported,
position = grid_get_height (grid);
label = gtk_label_new (option_display_name);
- gtk_widget_set_visible (GTK_WIDGET (label), TRUE);
gtk_label_set_mnemonic_widget (GTK_LABEL (label), widget);
gtk_widget_add_css_class (label, "dim-label");
gtk_widget_set_halign (label, GTK_ALIGN_END);
diff --git a/panels/printers/pp-ppd-selection-dialog.c b/panels/printers/pp-ppd-selection-dialog.c
index c7b5de653..f08fabefe 100644
--- a/panels/printers/pp-ppd-selection-dialog.c
+++ b/panels/printers/pp-ppd-selection-dialog.c
@@ -240,7 +240,6 @@ populate_dialog (PpPPDSelectionDialog *self)
header = gtk_label_new (gtk_tree_view_column_get_title (column));
gtk_widget_set_margin_start (header, 10);
gtk_tree_view_column_set_widget (column, header);
- gtk_widget_set_visible (header, TRUE);
gtk_tree_view_append_column (models_treeview, column);
diff --git a/panels/user-accounts/cc-avatar-chooser.c b/panels/user-accounts/cc-avatar-chooser.c
index 18db1702d..6fd231fe6 100644
--- a/panels/user-accounts/cc-avatar-chooser.c
+++ b/panels/user-accounts/cc-avatar-chooser.c
@@ -107,7 +107,6 @@ cc_avatar_chooser_crop (CcAvatarChooser *self,
/* Content */
self->crop_area = cc_crop_area_new ();
- gtk_widget_set_visible (self->crop_area, TRUE);
cc_crop_area_set_min_size (CC_CROP_AREA (self->crop_area), 48, 48);
cc_crop_area_set_paintable (CC_CROP_AREA (self->crop_area),
GDK_PAINTABLE (gdk_texture_new_for_pixbuf (pixbuf)));
@@ -118,7 +117,6 @@ cc_avatar_chooser_crop (CcAvatarChooser *self,
gtk_window_set_default_size (GTK_WINDOW (dialog), 400, 300);
- gtk_widget_set_visible (dialog, TRUE);
}
static void
diff --git a/panels/wacom/calibrator/calibrator-gui.c b/panels/wacom/calibrator/calibrator-gui.c
index 072e6888c..b265130d1 100644
--- a/panels/wacom/calibrator/calibrator-gui.c
+++ b/panels/wacom/calibrator/calibrator-gui.c
@@ -371,7 +371,6 @@ cc_calib_area_new (GdkDisplay *display,
else
gtk_window_fullscreen (GTK_WINDOW (calib_area));
- gtk_widget_set_visible (GTK_WIDGET (calib_area), TRUE);
return calib_area;
}
diff --git a/panels/wacom/cc-wacom-button-row.c b/panels/wacom/cc-wacom-button-row.c
index 10df0f712..dd9643643 100644
--- a/panels/wacom/cc-wacom-button-row.c
+++ b/panels/wacom/cc-wacom-button-row.c
@@ -237,7 +237,6 @@ cc_wacom_button_row_new (guint button,
row->settings = g_object_ref (settings);
grid = gtk_grid_new ();
- gtk_widget_set_visible (grid, TRUE);
gtk_grid_set_row_homogeneous (GTK_GRID (grid), TRUE);
gtk_grid_set_column_homogeneous (GTK_GRID (grid), TRUE);
@@ -257,7 +256,6 @@ cc_wacom_button_row_new (guint button,
shortcut_button = gsd_wacom_key_shortcut_button_new ();
g_object_set (shortcut_button, "mode", GSD_WACOM_KEY_SHORTCUT_BUTTON_MODE_ALL, NULL);
gtk_grid_attach (GTK_GRID (grid), shortcut_button, 2, 0, 1, 1);
- gtk_widget_set_visible (shortcut_button, TRUE);
row->key_shortcut_button = GSD_WACOM_KEY_SHORTCUT_BUTTON (shortcut_button);
g_signal_connect_object (shortcut_button, "key-shortcut-cleared",
G_CALLBACK (on_key_shortcut_cleared),
diff --git a/panels/wacom/test-wacom.c b/panels/wacom/test-wacom.c
index 008a0c932..b95ee09b3 100644
--- a/panels/wacom/test-wacom.c
+++ b/panels/wacom/test-wacom.c
@@ -146,7 +146,6 @@ int main (int argc, char **argv)
devices = create_fake_h610pro ();
add_page (devices, notebook);
- gtk_widget_set_visible (window, TRUE);
while (g_list_model_get_n_items (gtk_window_get_toplevels ()) > 0)
g_main_context_iteration (NULL, TRUE);
diff --git a/panels/wwan/cc-wwan-mode-dialog.c b/panels/wwan/cc-wwan-mode-dialog.c
index 1a054c702..95dd21ab7 100644
--- a/panels/wwan/cc-wwan-mode-dialog.c
+++ b/panels/wwan/cc-wwan-mode-dialog.c
@@ -138,7 +138,6 @@ cc_wwan_mode_dialog_row_new (CcWwanModeDialog *self,
row->preferred = preferred;
box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 12);
- gtk_widget_set_visible (box, TRUE);
g_object_set (box,
"margin-top", 18,
"margin-bottom", 18,
diff --git a/panels/wwan/cc-wwan-network-dialog.c b/panels/wwan/cc-wwan-network-dialog.c
index 7dd4c92c6..af2d89bb6 100644
--- a/panels/wwan/cc-wwan-network-dialog.c
+++ b/panels/wwan/cc-wwan-network-dialog.c
@@ -139,7 +139,6 @@ cc_wwan_network_dialog_row_new (CcWwanNetworkDialog *self,
row = g_object_new (CC_TYPE_WWAN_NETWORK_ROW, NULL);
box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 12);
- gtk_widget_set_visible (box, TRUE);
g_object_set (box,
"margin-top", 18,
"margin-bottom", 18,