diff options
| author | Rui Matos <tiagomatos@gmail.com> | 2015-09-03 19:24:00 +0200 |
|---|---|---|
| committer | Rui Matos <tiagomatos@gmail.com> | 2015-09-07 16:45:03 +0200 |
| commit | 3b14056a01b2dd16880e9f936de8be3cf13cc96f (patch) | |
| tree | c3570a24badf9523f0a5c281b78833a58aa364ad | |
| parent | 958c0140bbc3e9094c29d85bb088956e7e70ba39 (diff) | |
| download | gnome-control-center-3b14056a01b2dd16880e9f936de8be3cf13cc96f.tar.gz | |
region: Fix the input chooser add button sensitiveness logic
Going back when the back row just gets selected breaks keyboard
navigation. This behavior got introduced by mistake in commit
f28e06a4. Instead, let's just do the add button sensitiveness logic
here. The back row still works when activated.
https://bugzilla.gnome.org/show_bug.cgi?id=754524
| -rw-r--r-- | panels/region/cc-input-chooser.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/panels/region/cc-input-chooser.c b/panels/region/cc-input-chooser.c index 2a62b997c..9a6f249bb 100644 --- a/panels/region/cc-input-chooser.c +++ b/panels/region/cc-input-chooser.c @@ -702,17 +702,14 @@ selected_rows_changed (GtkListBox *box, GtkWidget *chooser) { CcInputChooserPrivate *priv = GET_PRIVATE (chooser); + gboolean sensitive = TRUE; GtkListBoxRow *row; - gpointer data; row = gtk_list_box_get_selected_row (box); - gtk_widget_set_sensitive (priv->add_button, row != NULL); - if (!row) - return; + if (!row || g_object_get_data (G_OBJECT (row), "back")) + sensitive = FALSE; - data = g_object_get_data (G_OBJECT (row), "back"); - if (data) - show_locale_rows (chooser); + gtk_widget_set_sensitive (priv->add_button, sensitive); } static void |