diff options
| author | Niels De Graef <nielsdegraef@gmail.com> | 2020-11-30 21:22:08 +0100 |
|---|---|---|
| committer | Niels De Graef <nielsdegraef@gmail.com> | 2020-11-30 21:25:19 +0100 |
| commit | e0671976f2d3628cb488e911b8ab4cc00193698d (patch) | |
| tree | 41daee7d9d9efdc8a6db2785edc5fc4483e0e5d5 /tests | |
| parent | 687adab8db19f1534007c1a0416ae836f80d60b6 (diff) | |
| download | gnome-contacts-e0671976f2d3628cb488e911b8ab4cc00193698d.tar.gz | |
Import only the Folks namspace
This commit removes all remaining occurrences `using Gtk;`, `using Gee;`
and `using Hdy;`. There's a number of reasons why we're doing this, but
to list a few:
* The `Gtk` and `Hdy` namespaces have had issues before with types
having the same name (ie HdyHeaderBar and GtkHeaderBar) which could
suddenly break the build.
* By omitting namespaces, it's harder to see for new contributors what
the actual type is of a certain variable when they want to look up the
API
* In the long term, we want to get rid of Gee, as it's clear that it's
not really maintained, and has some serious performance drawbacks.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/basic-test.vala | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/tests/basic-test.vala b/tests/basic-test.vala index 9cf1517..86ee407 100644 --- a/tests/basic-test.vala +++ b/tests/basic-test.vala @@ -15,8 +15,6 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ -using Gee; - void main (string[] args) { Test.init (ref args); Test.add_func ("/utils/get_first", Contacts.UtilsTests.get_first); @@ -25,7 +23,7 @@ void main (string[] args) { namespace Contacts.UtilsTests { private void get_first () { - Collection<Object> empty = Collection.empty (); + Gee.Collection<Object> empty = Gee.Collection.empty (); assert_true (Utils.get_first (empty) == null); } } |