diff options
| author | Alexander Mikhaylenko <alexm@gnome.org> | 2021-02-18 13:53:49 +0500 |
|---|---|---|
| committer | Alexander Mikhaylenko <alexm@gnome.org> | 2021-02-18 13:53:49 +0500 |
| commit | 16aa45ebec0e53d556cb06b8edbd1467580d8a8b (patch) | |
| tree | df72336816ff44d2f39096eea0411c3d991f4256 | |
| parent | 6d6f8f56f58920c7d65737a1279e1af0cf90d3c5 (diff) | |
| download | epiphany-wip/exalm/shortcuts.tar.gz | |
window-commands: Hide webapp shortcuts instead of destroyingwip/exalm/shortcuts
Avoid a use-after-free.
Fixes https://gitlab.gnome.org/GNOME/epiphany/-/issues/1452
| -rw-r--r-- | src/window-commands.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/window-commands.c b/src/window-commands.c index 809100771..ac6da6309 100644 --- a/src/window-commands.c +++ b/src/window-commands.c @@ -917,7 +917,7 @@ window_cmd_show_shortcuts (GSimpleAction *action, shortcuts_window = GTK_WIDGET (gtk_builder_get_object (builder, "shortcuts-dialog")); if (ephy_is_running_inside_flatpak ()) - gtk_widget_destroy (GTK_WIDGET (gtk_builder_get_object (builder, "shortcuts-web-apps-group"))); + gtk_widget_hide (GTK_WIDGET (gtk_builder_get_object (builder, "shortcuts-web-apps-group"))); if (gtk_widget_get_default_direction () == GTK_TEXT_DIR_RTL) { GtkShortcutsShortcut *shortcut; |