summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElias Projahn <johrpan@gmail.com>2021-01-05 17:35:04 +0100
committerMichael Catanzaro <mcatanzaro@gnome.org>2021-01-29 14:46:53 +0000
commitf266e76ff16f8c7e2ff59c8f5982b941cb0a6d07 (patch)
tree667b3a3f562dd8a50c6d40650eb6825e23a1e5c7
parent4c1b14c4727d5ba815cd9541cb734f4a2e87a751 (diff)
downloadepiphany-f266e76ff16f8c7e2ff59c8f5982b941cb0a6d07.tar.gz
action-bar-start: Propagate primary button release events
Previously, the release events for the primary mouse button on the navigation buttons were not propagated. Because of that, the GtkButton stayed in its pressed state. The middle button events will still be blocked as justified by the respective comment.
-rw-r--r--src/ephy-action-bar-start.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/ephy-action-bar-start.c b/src/ephy-action-bar-start.c
index e55105fcd..135e6ebe0 100644
--- a/src/ephy-action-bar-start.c
+++ b/src/ephy-action-bar-start.c
@@ -383,6 +383,8 @@ navigation_button_release_event_cb (GtkButton *button,
"navigation-forward-new-tab");
g_action_activate (action, NULL);
}
+
+ /* Don't propagate the event to avoid other middle-click actions. */
return GDK_EVENT_STOP;
}
@@ -396,9 +398,13 @@ navigation_button_release_event_cb (GtkButton *button,
"navigation-forward");
g_action_activate (action, NULL);
}
- return GDK_EVENT_STOP;
+
+ /* Propagate the event to allow the button to correctly reset its internal
+ * state. */
+ return GDK_EVENT_PROPAGATE;
}
+ /* Propagate other unhandled events. */
return GDK_EVENT_PROPAGATE;
}