From f266e76ff16f8c7e2ff59c8f5982b941cb0a6d07 Mon Sep 17 00:00:00 2001 From: Elias Projahn Date: Tue, 5 Jan 2021 17:35:04 +0100 Subject: action-bar-start: Propagate primary button release events Previously, the release events for the primary mouse button on the navigation buttons were not propagated. Because of that, the GtkButton stayed in its pressed state. The middle button events will still be blocked as justified by the respective comment. --- src/ephy-action-bar-start.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/ephy-action-bar-start.c b/src/ephy-action-bar-start.c index e55105fcd..135e6ebe0 100644 --- a/src/ephy-action-bar-start.c +++ b/src/ephy-action-bar-start.c @@ -383,6 +383,8 @@ navigation_button_release_event_cb (GtkButton *button, "navigation-forward-new-tab"); g_action_activate (action, NULL); } + + /* Don't propagate the event to avoid other middle-click actions. */ return GDK_EVENT_STOP; } @@ -396,9 +398,13 @@ navigation_button_release_event_cb (GtkButton *button, "navigation-forward"); g_action_activate (action, NULL); } - return GDK_EVENT_STOP; + + /* Propagate the event to allow the button to correctly reset its internal + * state. */ + return GDK_EVENT_PROPAGATE; } + /* Propagate other unhandled events. */ return GDK_EVENT_PROPAGATE; } -- cgit v1.2.1