diff options
author | Michael Catanzaro <mcatanzaro@redhat.com> | 2023-01-04 13:02:41 -0600 |
---|---|---|
committer | Michael Catanzaro <mcatanzaro@redhat.com> | 2023-01-04 13:12:26 -0600 |
commit | 54849c462cc798298c06f65f8f9d058a1ae3cec7 (patch) | |
tree | 3a9baf53b464ec2f6ac114fc1b53a5ee0be58b8f | |
parent | a311325869170b19b5fb6103260374d0f18f60ae (diff) | |
download | epiphany-mcatanzaro/coverity-gnome-42.tar.gz |
embed-prefs: fix double free on error pathmcatanzaro/coverity-gnome-42
If we fail to create the file monitor for the user JS file, then we free
the error twice by mistake. Uh-oh. Found by Coverity.
-rw-r--r-- | embed/ephy-embed-prefs.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/embed/ephy-embed-prefs.c b/embed/ephy-embed-prefs.c index 630218689..a219ea54c 100644 --- a/embed/ephy-embed-prefs.c +++ b/embed/ephy-embed-prefs.c @@ -255,12 +255,10 @@ webkit_pref_callback_user_javascript (GSettings *settings, (GAsyncReadyCallback)user_javascript_read_cb, NULL); user_javascript_monitor = g_file_monitor_file (file, G_FILE_MONITOR_NONE, NULL, &error); - if (!user_javascript_monitor) { + if (!user_javascript_monitor) g_warning ("Could not create a file monitor for %s: %s\n", g_file_get_uri (file), error->message); - g_error_free (error); - } else { + else g_signal_connect (user_javascript_monitor, "changed", G_CALLBACK (user_javascript_file_changed), NULL); - } } static void |