| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
As discussed in <https://gitlab.gnome.org/GNOME/glib/-/issues/600>,
the volatile qualifier rarely has the semantics that are desired in C/C++.
With recent gcc versions, combining pointers to volatile-qualified types
with the __atomic_foo() family of builtins causes compiler warnings.
http://c.isvolatileusefulwiththreads.com/ has some other useful
references.
Signed-off-by: Simon McVittie <smcv@debian.org>
|
| |
|
| |
|
|
|
|
| |
It can be checked in the source code instead.
|
|
|
|
|
|
|
|
|
|
| |
Linux 3.4 added support for the MADV_DONTDUMP option to madvise(), which
requests that the covered memory not be included in coredumps. It makes
sense to use this to prevent cases where application crashes could
result in secrets being persisted to disk or included in dumps that are
uploaded to remote servers for analysis. I've avoided making this fatal
since there's a chance this code could be built on systems that have
MADV_DONTDUMP but run on systems that don't.
|
|
|
|
|
|
|
|
|
| |
These headers (at least for OpenSSL) must come in this order. We
shouldn't assume that `g_hash_table_foreach` is going to give a
particular ordering - it's not guaranteed, and has changed with GLib
2.59.
Fixes #21
|
| |
|
|
|
|
|
|
| |
Split out mock-interaction.c from libegg.la to libegg-test.la.
https://bugzilla.gnome.org/show_bug.cgi?id=794274
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=775981
|
|
|
|
|
| |
Even if the given string is shorter than n, the result should be null
terminated. This matches the behavior of strndup().
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=641082
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=778357
|
|
|
|
|
|
|
| |
Not all systems have memrchr(), so g_strrstr_len() is more portable,
though probably slower.
https://bugzilla.gnome.org/show_bug.cgi?id=774311
|
|
|
|
|
|
|
| |
Otherwise, including this header in two translation units later linked
together will fail compilation.
https://bugzilla.gnome.org/show_bug.cgi?id=774312
|
|
|
|
|
|
|
| |
In looking for places where gnome-keyring-daemon potentially
spawns subprocesses, I found this piece of unused code. Remove it.
https://bugzilla.gnome.org/show_bug.cgi?id=756324
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=92383
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=755873
|
|
|
|
|
|
| |
They're not used anymore.
https://bugzilla.gnome.org/show_bug.cgi?id=622905
|
|
|
|
|
| |
It's okay if the directory is gone, it may have been
removed by a test.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Most callers of asn1_set_value() seems to assume this function will take
ownership of the passed in GBytes, while it actually takes an additional
reference.
https://bugzilla.gnome.org/show_bug.cgi?id=738508
|
|
|
|
|
|
|
| |
EchoData::error and EchoData::output must be freed after
use.
https://bugzilla.gnome.org/show_bug.cgi?id=738508
|
|
|
|
|
|
|
| |
The 'md2' gcry_md_ht_t variable is opened with gcry_md_open() in that
method but is never closed, which causes a leak.
https://bugzilla.gnome.org/show_bug.cgi?id=738508
|
|
|
|
|
|
|
| |
In error cases, the Atlv variable 'tlv' which was created in this
function is not going to be used, so we must free it before returning.
https://bugzilla.gnome.org/show_bug.cgi?id=738508
|
|
|
|
|
|
|
| |
egg_padding_pkcs1_pad_02 returns newly allocated data which must be
g_free'ed after use.
https://bugzilla.gnome.org/show_bug.cgi?id=738508
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=738508
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=738508
|
|
|
|
|
|
|
| |
When unregistering a cleanup instance, the memory allocated for the cleanup
was not freed causing a memory leak.
https://bugzilla.gnome.org/show_bug.cgi?id=738508
|
|
|
|
| |
A header was missing
|
|
|
|
| |
So that it can be used in other parts of gnome-keyring.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libcrypt no longer supports setting our own threading callbacks,
and is thread-safe if we call gcry_check_version() before creating
threads.
Unfortunately we can't guarantee that we call gcry_check_version()
early enough, we try our best. Most of the callers of Gcr either
don't use libgcrypt, or also initialize it appropriately themselves.
Bump libgcrypt dependency to 1.4.5+, and have earlier versions use
the native pthread implementation of locking.
|
| |
|
|
|
|
|
|
|
|
|
| |
We don't do this via the standard mechanism, as it means that libdbus
just calls _exit() (not even exit()) when the connection goes away.
This can lead to inconsistent state. Shutdown should be orderly.
https://bugzilla.gnome.org/show_bug.cgi?id=708765
|
|
|
|
|
| |
Call 'rm' to cleanup the directory instead of removing files ourselves.
We want to use nested directories in some tests.
|
| |
|
|
|
|
|
| |
Also build in a 'make check-memory' and related functionality
which drives valgrind.
|
|
|
|
|
|
|
|
| |
This allows all the code to be built in parallel, and only
rebuilding stuff that's changed when developing. Much quicker.
In the meantime disable the p11-tests checks, which
were very rarely used. We'll need to migrate them to TAP.
|
|
|
|
|
| |
This allows for a cleaner build tree, and will provide benefits
when moving to a single Makefile.
|
|
|
|
|
|
| |
And refresh the COPYING and COPYING.LIB files
https://bugzilla.gnome.org/show_bug.cgi?id=721549
|
|
|
|
| |
Bump glib dependency to 2.38.x
|
| |
|
|
|
|
|
| |
* Use GMutex insteod of GStaticMutex
* Don't use g_thread_supported
|
| |
|
|
|
|
|
|
| |
* Discovered by Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com>
https://bugzilla.gnome.org/show_bug.cgi?id=691500
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Initial patch by Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com>
* The cause of this bug was reusing argument variables for other
purposes in parsing functions when that didn't really make sense,
so fix this as well.
* Add tests that catch this issue.
See https://bugzilla.redhat.com/show_bug.cgi?id=893162
https://bugzilla.gnome.org/show_bug.cgi?id=691500
|
|
|
|
|
|
| |
* Remove or change code that doesn't get executed in normal
operation.
* Fix a few bugs discovered during the testing.
|
|
|
|
|
| |
* Better detection of the case where TLV length overflows
the size of an int.
|
|
|
|
|
|
| |
Since the ASN.1 API changed, we need to make sure things still work.
Add tests to ensure this. In addition rework code which is (or should
be) currently unreachable.
|
|
|
|
|
|
| |
* When parsing invalid DER files and more than one sub-TLV is
encountered we would do a NULL dereference.
* Catch this condition and test for it.
|