summaryrefslogtreecommitdiff
path: root/gobject
diff options
context:
space:
mode:
authorLoic Le Page <llepage@fluendo.com>2022-01-19 18:55:21 +0100
committerLoïc Le Page <llepage@fluendo.com>2022-02-18 10:49:00 +0100
commit208593acc60d7e26c60b2085322bdfe2d3c765f5 (patch)
tree83bfe9ebf7ead0db583b08c3e596ec44f1397014 /gobject
parent84c5675cef8944d33c1714d0f001c269299d1e21 (diff)
downloadglib-208593acc60d7e26c60b2085322bdfe2d3c765f5.tar.gz
Fix redefinition of local variable and non-initialized variable in gobject/gsignal.c
Diffstat (limited to 'gobject')
-rw-r--r--gobject/gsignal.c19
1 files changed, 9 insertions, 10 deletions
diff --git a/gobject/gsignal.c b/gobject/gsignal.c
index df6c3e39f..7fd4ee92f 100644
--- a/gobject/gsignal.c
+++ b/gobject/gsignal.c
@@ -2219,7 +2219,7 @@ g_signal_chain_from_overridden_handler (gpointer instance,
GType chain_type = 0, restore_type = 0;
Emission *emission = NULL;
GClosure *closure = NULL;
- SignalNode *node;
+ SignalNode *node = NULL;
guint n_params = 0;
g_return_if_fail (G_TYPE_CHECK_INSTANCE (instance));
@@ -3365,7 +3365,6 @@ g_signal_emit_valist (gpointer instance,
SignalAccumulator *accumulator;
Emission emission;
GValue *return_accu, accu = G_VALUE_INIT;
- guint signal_id;
GType instance_type = G_TYPE_FROM_INSTANCE (instance);
GValue emission_return = G_VALUE_INIT;
GType rtype = node->return_type & ~G_SIGNAL_TYPE_STATIC_SCOPE;
@@ -3625,14 +3624,14 @@ signal_emit_unlocked_R (SignalNode *node,
if (node->flags & G_SIGNAL_NO_RECURSE)
{
- Emission *node = emission_find (signal_id, detail, instance);
-
- if (node)
- {
- node->state = EMISSION_RESTART;
- SIGNAL_UNLOCK ();
- return return_value_altered;
- }
+ Emission *emission_node = emission_find (signal_id, detail, instance);
+
+ if (emission_node)
+ {
+ emission_node->state = EMISSION_RESTART;
+ SIGNAL_UNLOCK ();
+ return return_value_altered;
+ }
}
accumulator = node->accumulator;
if (accumulator)