diff options
| author | Philip Withnall <withnall@endlessm.com> | 2018-08-22 11:15:08 +0100 |
|---|---|---|
| committer | Philip Withnall <withnall@endlessm.com> | 2018-08-22 11:18:02 +0100 |
| commit | c849a4ddd3d1da2ff8e7890810bc37f11e1330de (patch) | |
| tree | 4b3b6ee822542c29a49ad27e0303bca65481b5ce /glib/gbookmarkfile.h | |
| parent | 082730fc3e10a05c7938c06a27c875efd32a729b (diff) | |
| download | glib-c849a4ddd3d1da2ff8e7890810bc37f11e1330de.tar.gz | |
glib: Drop G_GNUC_MALLOC usage from various other allocation functions
These functions may be OK to leave the G_GNUC_MALLOC attribute on,
because the only valid pointers in the storage areas they return are,
themselves, new pointers.
However, it’s a lot easier to remove the attributes now than to try and
diagnose miscompilations in future. The performance impact of this is
likely to be unmeasurable. If there are performance problems caused by
this, then they can be profiled and fixed case-by-case in future,
bearing in mind the possibility for miscompilation if G_GNUC_MALLOC is
readded.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://gitlab.gnome.org/GNOME/glib/issues/1465
Diffstat (limited to 'glib/gbookmarkfile.h')
| -rw-r--r-- | glib/gbookmarkfile.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/glib/gbookmarkfile.h b/glib/gbookmarkfile.h index b87d27e08..8dd93a1dc 100644 --- a/glib/gbookmarkfile.h +++ b/glib/gbookmarkfile.h @@ -146,7 +146,7 @@ GLIB_AVAILABLE_IN_ALL gchar ** g_bookmark_file_get_groups (GBookmarkFile *bookmark, const gchar *uri, gsize *length, - GError **error) G_GNUC_MALLOC; + GError **error); GLIB_AVAILABLE_IN_ALL void g_bookmark_file_add_application (GBookmarkFile *bookmark, const gchar *uri, @@ -161,7 +161,7 @@ GLIB_AVAILABLE_IN_ALL gchar ** g_bookmark_file_get_applications (GBookmarkFile *bookmark, const gchar *uri, gsize *length, - GError **error) G_GNUC_MALLOC; + GError **error); GLIB_AVAILABLE_IN_ALL gboolean g_bookmark_file_set_app_info (GBookmarkFile *bookmark, const gchar *uri, @@ -228,7 +228,7 @@ GLIB_AVAILABLE_IN_ALL gint g_bookmark_file_get_size (GBookmarkFile *bookmark); GLIB_AVAILABLE_IN_ALL gchar ** g_bookmark_file_get_uris (GBookmarkFile *bookmark, - gsize *length) G_GNUC_MALLOC; + gsize *length); GLIB_AVAILABLE_IN_ALL gboolean g_bookmark_file_remove_group (GBookmarkFile *bookmark, const gchar *uri, |