diff options
| author | Steve Azzopardi <sazzopardi@gitlab.com> | 2023-01-30 09:21:17 +0100 |
|---|---|---|
| committer | Steve Azzopardi <sazzopardi@gitlab.com> | 2023-01-30 09:54:42 +0100 |
| commit | 80f684e48eca2bf1ef2006d84f8c49bec7104344 (patch) | |
| tree | d96c92030bfe86a5183a7268361b2ec70788f73c /internal/command/twofactorrecover | |
| parent | 51eab44edafd0c097e82c1a74fd379cae4869a42 (diff) | |
| download | gitlab-shell-80f684e48eca2bf1ef2006d84f8c49bec7104344.tar.gz | |
feat: make retryable http default client
What
---
Make the retryableHTTP client introduced in
https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/703 the
default HTTP client.
Why
---
In
https://gitlab.com/gitlab-com/gl-infra/production/-/issues/7979#note_1254964426
we've seen a 99% error reduction on `git` commands from `gitlab-shell`
when the retryableHTTP client is used.
This has been running in production for over 2 weeks in `us-east1-b` and
5 days fleet-wide so we should be confident that this client works as
expected.
Reference: https://gitlab.com/gitlab-com/gl-infra/production/-/issues/7979
Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>
Diffstat (limited to 'internal/command/twofactorrecover')
| -rw-r--r-- | internal/command/twofactorrecover/twofactorrecover_test.go | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/internal/command/twofactorrecover/twofactorrecover_test.go b/internal/command/twofactorrecover/twofactorrecover_test.go index 81b4dff..7e20a06 100644 --- a/internal/command/twofactorrecover/twofactorrecover_test.go +++ b/internal/command/twofactorrecover/twofactorrecover_test.go @@ -18,9 +18,7 @@ import ( "gitlab.com/gitlab-org/gitlab-shell/v14/internal/gitlabnet/twofactorrecover" ) -var ( - requests []testserver.TestRequestHandler -) +var requests []testserver.TestRequestHandler func setup(t *testing.T) { requests = []testserver.TestRequestHandler{ @@ -99,7 +97,7 @@ func TestExecute(t *testing.T) { desc: "With API fails", arguments: &commandargs.Shell{GitlabKeyId: "broken"}, answer: "yes\n", - expectedOutput: question + errorHeader + "Internal API error (500)\n", + expectedOutput: question + errorHeader + "Internal API unreachable\n", }, { desc: "With missing arguments", |