1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe TodosHelper do
let_it_be(:user) { create(:user) }
let_it_be(:author) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:issue) { create(:issue, title: 'Issue 1', project: project) }
let_it_be(:design) { create(:design, issue: issue) }
let_it_be(:note) do
create(:note,
project: issue.project,
note: 'I am note, hear me roar')
end
let_it_be(:design_todo) do
create(:todo, :mentioned,
user: user,
project: project,
target: design,
author: author,
note: note)
end
let_it_be(:alert_todo) do
alert = create(:alert_management_alert, iid: 1001)
create(:todo, target: alert)
end
let_it_be(:task_todo) do
task = create(:work_item, :task, project: project)
create(:todo, target: task, target_type: task.class.name, project: project)
end
let_it_be(:issue_todo) do
create(:todo, target: issue)
end
describe '#todos_count_format' do
it 'shows fuzzy count for 100 or more items' do
expect(helper.todos_count_format(100)).to eq '99+'
expect(helper.todos_count_format(1000)).to eq '99+'
end
it 'shows exact count for 99 or fewer items' do
expect(helper.todos_count_format(99)).to eq '99'
expect(helper.todos_count_format(50)).to eq '50'
expect(helper.todos_count_format(1)).to eq '1'
end
end
describe '#todo_target_link' do
context 'when given a design' do
let(:todo) { design_todo }
it 'produces a good link' do
path = helper.todo_target_path(todo)
link = helper.todo_target_link(todo)
expected = "<a href=\"#{path}\">design #{design.to_reference}</a>"
expect(link).to eq(expected)
end
end
end
describe '#todo_target_title' do
context 'when the target does not exist' do
let(:todo) { double('Todo', target: nil) }
it 'returns an empty string' do
title = helper.todo_target_title(todo)
expect(title).to eq("")
end
end
context 'when given a design todo' do
let(:todo) { design_todo }
it 'returns an empty string' do
title = helper.todo_target_title(todo)
expect(title).to eq("")
end
end
context 'when given a non-design todo' do
let(:todo) do
build_stubbed(:todo, :assigned,
user: user,
project: issue.project,
target: issue,
author: author)
end
it 'returns the title' do
title = helper.todo_target_title(todo)
expect(title).to eq("\"Issue 1\"")
end
end
end
describe '#todo_target_path' do
context 'when given a design' do
let(:todo) { design_todo }
it 'responds with an appropriate path' do
path = helper.todo_target_path(todo)
issue_path = Gitlab::Routing.url_helpers
.project_issue_path(issue.project, issue)
expect(path).to eq("#{issue_path}/designs/#{design.filename}##{dom_id(design_todo.note)}")
end
end
context 'when given an alert' do
let(:todo) { alert_todo }
it 'responds with an appropriate path' do
path = helper.todo_target_path(todo)
expect(path).to eq(
"/#{todo.project.full_path}/-/alert_management/#{todo.target.iid}/details"
)
end
end
context 'when given a task' do
let(:todo) { task_todo }
it 'responds with an appropriate path' do
path = helper.todo_target_path(todo)
expect(path).to eq("/#{todo.project.full_path}/-/work_items/#{todo.target.id}")
end
end
context 'when given an issue with a note anchor' do
let(:todo) { create(:todo, project: issue.project, target: issue, note: note) }
it 'responds with an appropriate path' do
path = helper.todo_target_path(todo)
expect(path).to eq("/#{issue.project.full_path}/-/issues/#{issue.iid}##{dom_id(note)}")
end
end
end
describe '#todo_target_type_name' do
subject { helper.todo_target_type_name(todo) }
context 'when given a design todo' do
let(:todo) { design_todo }
it { is_expected.to eq('design') }
end
context 'when given an alert todo' do
let(:todo) { alert_todo }
it { is_expected.to eq('alert') }
end
context 'when given a task todo' do
let(:todo) { task_todo }
it { is_expected.to eq('task') }
end
context 'when given an issue todo' do
let(:todo) { issue_todo }
it { is_expected.to eq('issue') }
end
context 'when given a merge request todo' do
let(:todo) do
merge_request = create(:merge_request, source_project: project)
create(:todo, target: merge_request)
end
it { is_expected.to eq('merge request') }
end
end
describe '#todo_types_options' do
it 'includes a match for a design todo' do
options = helper.todo_types_options
design_option = options.find { |o| o[:id] == design_todo.target_type }
expect(design_option).to include(text: 'Design')
end
end
describe '#todo_target_state_pill' do
subject { helper.todo_target_state_pill(todo) }
shared_examples 'a rendered state pill' do |attr|
it 'returns expected html' do
aggregate_failures do
expect(subject).to have_css(attr[:css])
expect(subject).to have_content(attr[:state].capitalize)
end
end
end
shared_examples 'no state pill' do
specify { expect(subject).to eq(nil) }
end
context 'merge request todo' do
let(:todo) { create(:todo, target: create(:merge_request)) }
it_behaves_like 'no state pill'
context 'closed MR' do
before do
todo.target.update!(state: 'closed')
end
it_behaves_like 'a rendered state pill', css: '.gl-bg-red-500', state: 'closed'
end
context 'merged MR' do
before do
todo.target.update!(state: 'merged')
end
it_behaves_like 'a rendered state pill', css: '.gl-bg-blue-500', state: 'merged'
end
end
context 'issue todo' do
let(:todo) { create(:todo, target: issue) }
it_behaves_like 'no state pill'
context 'closed issue' do
before do
todo.target.update!(state: 'closed')
end
it_behaves_like 'a rendered state pill', css: '.gl-bg-blue-500', state: 'closed'
end
end
context 'alert todo' do
let(:todo) { alert_todo }
it_behaves_like 'no state pill'
context 'resolved alert' do
before do
todo.target.resolve!
end
it_behaves_like 'a rendered state pill', css: '.gl-bg-blue-500', state: 'resolved'
end
end
end
describe '#no_todos_messages' do
context 'when getting todos messsages' do
it 'return these sentences' do
expected_sentences = [
s_('Todos|Good job! Looks like you don\'t have anything left on your To-Do List'),
s_('Todos|Isn\'t an empty To-Do List beautiful?'),
s_('Todos|Give yourself a pat on the back!'),
s_('Todos|Nothing left to do. High five!'),
s_('Todos|Henceforth, you shall be known as "To-Do Destroyer"')
]
expect(helper.no_todos_messages).to eq(expected_sentences)
end
end
end
describe '#todo_author_display?' do
using RSpec::Parameterized::TableSyntax
subject { helper.todo_author_display?(alert_todo) }
where(:action, :result) do
Todo::BUILD_FAILED | false
Todo::UNMERGEABLE | false
Todo::ASSIGNED | true
end
with_them do
before do
alert_todo.action = action
end
it { is_expected.to eq(result) }
end
end
describe '#todos_filter_params' do
using RSpec::Parameterized::TableSyntax
where(:state, :result) do
'done' | 'done'
'pending' | 'pending'
'' | nil
end
with_them do
before do
allow(helper).to receive(:params).and_return({ state: state })
end
it { expect(helper.todos_filter_params[:state]).to eq(result) }
end
end
describe '#todo_action_name' do
using RSpec::Parameterized::TableSyntax
where(:action, :self_added?, :expected_action_name) do
Todo::ASSIGNED | false | s_('Todos|assigned you')
Todo::ASSIGNED | true | s_('Todos|assigned')
Todo::REVIEW_REQUESTED | true | s_('Todos|requested a review of')
Todo::MENTIONED | true | format(s_("Todos|mentioned %{who} on"), who: s_('Todos|yourself'))
Todo::MENTIONED | false | format(s_("Todos|mentioned %{who} on"), who: _('you'))
Todo::DIRECTLY_ADDRESSED | true | format(s_("Todos|mentioned %{who} on"), who: s_('Todos|yourself'))
Todo::DIRECTLY_ADDRESSED | false | format(s_("Todos|mentioned %{who} on"), who: _('you'))
Todo::BUILD_FAILED | true | s_('Todos|The pipeline failed in')
Todo::MARKED | true | s_('Todos|added a todo for')
Todo::APPROVAL_REQUIRED | true | format(s_("Todos|set %{who} as an approver for"), who: s_('Todos|yourself'))
Todo::APPROVAL_REQUIRED | false | format(s_("Todos|set %{who} as an approver for"), who: _('you'))
Todo::UNMERGEABLE | true | s_('Todos|Could not merge')
Todo::MERGE_TRAIN_REMOVED | true | s_("Todos|Removed from Merge Train:")
end
with_them do
before do
alert_todo.action = action
alert_todo.user = self_added? ? alert_todo.author : user
end
it { expect(helper.todo_action_name(alert_todo)).to eq(expected_action_name) }
end
end
end
|