1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe JiraConnect::EventsController do
shared_examples 'verifies asymmetric JWT token' do
context 'when token is valid' do
include_context 'valid JWT token'
it 'renders successful' do
send_request
expect(response).to have_gitlab_http_status(:success)
end
end
context 'when token is invalid' do
include_context 'invalid JWT token'
it 'renders unauthorized' do
send_request
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
end
shared_context 'valid JWT token' do
before do
allow_next_instance_of(Atlassian::JiraConnect::AsymmetricJwt) do |asymmetric_jwt|
allow(asymmetric_jwt).to receive(:valid?).and_return(true)
allow(asymmetric_jwt).to receive(:iss_claim).and_return(client_key)
end
end
end
shared_context 'invalid JWT token' do
before do
allow_next_instance_of(Atlassian::JiraConnect::AsymmetricJwt) do |asymmetric_jwt|
allow(asymmetric_jwt).to receive(:valid?).and_return(false)
end
end
end
describe '#installed' do
let_it_be(:client_key) { '1234' }
let_it_be(:shared_secret) { 'secret' }
let_it_be(:base_url) { 'https://test.atlassian.net' }
let(:params) do
{
clientKey: client_key,
sharedSecret: shared_secret,
baseUrl: base_url
}
end
include_context 'valid JWT token'
subject do
post :installed, params: params
end
it_behaves_like 'verifies asymmetric JWT token' do
let(:send_request) { subject }
end
it 'saves the jira installation data' do
expect { subject }.to change { JiraConnectInstallation.count }.by(1)
end
it 'saves the correct values' do
subject
installation = JiraConnectInstallation.find_by_client_key(client_key)
expect(installation.shared_secret).to eq(shared_secret)
expect(installation.base_url).to eq('https://test.atlassian.net')
end
context 'when the shared_secret param is missing' do
let(:params) do
{
clientKey: client_key,
baseUrl: base_url
}
end
it 'returns 422' do
subject
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
context 'when an installation already exists' do
let_it_be(:installation) { create(:jira_connect_installation, base_url: base_url, client_key: client_key, shared_secret: shared_secret) }
it 'validates the JWT token in authorization header and returns 200 without creating a new installation', :aggregate_failures do
expect { subject }.not_to change { JiraConnectInstallation.count }
expect(response).to have_gitlab_http_status(:ok)
end
context 'when parameters include a new shared secret and base_url' do
let(:shared_secret) { 'new_secret' }
let(:base_url) { 'https://new_test.atlassian.net' }
it 'updates the installation', :aggregate_failures do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(installation.reload).to have_attributes(
shared_secret: shared_secret,
base_url: base_url
)
end
context 'when the `jira_connect_installation_update` feature flag is disabled' do
before do
stub_feature_flags(jira_connect_installation_update: false)
end
it 'does not update the installation', :aggregate_failures do
expect { subject }.not_to change { installation.reload.attributes }
expect(response).to have_gitlab_http_status(:ok)
end
end
end
context 'when the new base_url is invalid' do
let(:base_url) { 'invalid' }
it 'renders 422', :aggregate_failures do
expect { subject }.not_to change { installation.reload.base_url }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
end
end
describe '#uninstalled' do
let_it_be(:installation) { create(:jira_connect_installation) }
let(:client_key) { installation.client_key }
let(:params) do
{
clientKey: client_key,
baseUrl: 'https://test.atlassian.net'
}
end
it_behaves_like 'verifies asymmetric JWT token' do
let(:send_request) { post :uninstalled, params: params }
end
subject(:post_uninstalled) { post :uninstalled, params: params }
context 'when JWT is invalid' do
include_context 'invalid JWT token'
it 'does not delete the installation' do
expect { post_uninstalled }.not_to change { JiraConnectInstallation.count }
end
end
context 'when JWT is valid' do
include_context 'valid JWT token'
let(:jira_base_path) { '/-/jira_connect' }
let(:jira_event_path) { '/-/jira_connect/events/uninstalled' }
it 'calls the DestroyService and returns ok in case of success' do
expect_next_instance_of(JiraConnectInstallations::DestroyService, installation, jira_base_path, jira_event_path) do |destroy_service|
expect(destroy_service).to receive(:execute).and_return(true)
end
post_uninstalled
expect(response).to have_gitlab_http_status(:ok)
end
it 'calls the DestroyService and returns unprocessable_entity in case of failure' do
expect_next_instance_of(JiraConnectInstallations::DestroyService, installation, jira_base_path, jira_event_path) do |destroy_service|
expect(destroy_service).to receive(:execute).and_return(false)
end
post_uninstalled
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
end
end
|
