diff options
Diffstat (limited to 'spec/routing')
-rw-r--r-- | spec/routing/admin_routing_spec.rb | 68 | ||||
-rw-r--r-- | spec/routing/api_routing_spec.rb | 24 | ||||
-rw-r--r-- | spec/routing/environments_spec.rb | 38 | ||||
-rw-r--r-- | spec/routing/group_routing_spec.rb | 106 | ||||
-rw-r--r-- | spec/routing/import_routing_spec.rb | 90 | ||||
-rw-r--r-- | spec/routing/instance_statistics_routing_spec.rb | 6 | ||||
-rw-r--r-- | spec/routing/openid_connect_spec.rb | 16 | ||||
-rw-r--r-- | spec/routing/project_routing_spec.rb | 585 | ||||
-rw-r--r-- | spec/routing/routing_spec.rb | 148 |
9 files changed, 542 insertions, 539 deletions
diff --git a/spec/routing/admin_routing_spec.rb b/spec/routing/admin_routing_spec.rb index 77baaef7afd..16659f00735 100644 --- a/spec/routing/admin_routing_spec.rb +++ b/spec/routing/admin_routing_spec.rb @@ -1,4 +1,4 @@ -require 'spec_helper' +require "spec_helper" # block_admin_user PUT /admin/users/:id/block(.:format) admin/users#block # unblock_admin_user PUT /admin/users/:id/unblock(.:format) admin/users#unblock @@ -11,43 +11,43 @@ require 'spec_helper' # DELETE /admin/users/:id(.:format) admin/users#destroy describe Admin::UsersController, "routing" do it "to #block" do - expect(put("/admin/users/1/block")).to route_to('admin/users#block', id: '1') + expect(put("/admin/users/1/block")).to route_to("admin/users#block", id: "1") end it "to #unblock" do - expect(put("/admin/users/1/unblock")).to route_to('admin/users#unblock', id: '1') + expect(put("/admin/users/1/unblock")).to route_to("admin/users#unblock", id: "1") end it "to #index" do - expect(get("/admin/users")).to route_to('admin/users#index') + expect(get("/admin/users")).to route_to("admin/users#index") end it "to #show" do - expect(get("/admin/users/1")).to route_to('admin/users#show', id: '1') + expect(get("/admin/users/1")).to route_to("admin/users#show", id: "1") end it "to #create" do - expect(post("/admin/users")).to route_to('admin/users#create') + expect(post("/admin/users")).to route_to("admin/users#create") end it "to #new" do - expect(get("/admin/users/new")).to route_to('admin/users#new') + expect(get("/admin/users/new")).to route_to("admin/users#new") end it "to #edit" do - expect(get("/admin/users/1/edit")).to route_to('admin/users#edit', id: '1') + expect(get("/admin/users/1/edit")).to route_to("admin/users#edit", id: "1") end it "to #show" do - expect(get("/admin/users/1")).to route_to('admin/users#show', id: '1') + expect(get("/admin/users/1")).to route_to("admin/users#show", id: "1") end it "to #update" do - expect(put("/admin/users/1")).to route_to('admin/users#update', id: '1') + expect(put("/admin/users/1")).to route_to("admin/users#update", id: "1") end it "to #destroy" do - expect(delete("/admin/users/1")).to route_to('admin/users#destroy', id: '1') + expect(delete("/admin/users/1")).to route_to("admin/users#destroy", id: "1") end end @@ -62,12 +62,12 @@ end # DELETE /admin/projects/:id(.:format) admin/projects#destroy {id: /[^\/]+/} describe Admin::ProjectsController, "routing" do it "to #index" do - expect(get("/admin/projects")).to route_to('admin/projects#index') + expect(get("/admin/projects")).to route_to("admin/projects#index") end it "to #show" do - expect(get("/admin/projects/gitlab/gitlab-ce")).to route_to('admin/projects#show', namespace_id: 'gitlab', id: 'gitlab-ce') - expect(get("/admin/projects/gitlab/subgroup/gitlab-ce")).to route_to('admin/projects#show', namespace_id: 'gitlab/subgroup', id: 'gitlab-ce') + expect(get("/admin/projects/gitlab/gitlab-ce")).to route_to("admin/projects#show", namespace_id: "gitlab", id: "gitlab-ce") + expect(get("/admin/projects/gitlab/subgroup/gitlab-ce")).to route_to("admin/projects#show", namespace_id: "gitlab/subgroup", id: "gitlab-ce") end end @@ -79,83 +79,83 @@ end # edit_admin_hook GET /admin/hooks/:id(.:format) admin/hooks#edit describe Admin::HooksController, "routing" do it "to #test" do - expect(post("/admin/hooks/1/test")).to route_to('admin/hooks#test', id: '1') + expect(post("/admin/hooks/1/test")).to route_to("admin/hooks#test", id: "1") end it "to #index" do - expect(get("/admin/hooks")).to route_to('admin/hooks#index') + expect(get("/admin/hooks")).to route_to("admin/hooks#index") end it "to #create" do - expect(post("/admin/hooks")).to route_to('admin/hooks#create') + expect(post("/admin/hooks")).to route_to("admin/hooks#create") end it "to #edit" do - expect(get("/admin/hooks/1/edit")).to route_to('admin/hooks#edit', id: '1') + expect(get("/admin/hooks/1/edit")).to route_to("admin/hooks#edit", id: "1") end it "to #update" do - expect(put("/admin/hooks/1")).to route_to('admin/hooks#update', id: '1') + expect(put("/admin/hooks/1")).to route_to("admin/hooks#update", id: "1") end it "to #destroy" do - expect(delete("/admin/hooks/1")).to route_to('admin/hooks#destroy', id: '1') + expect(delete("/admin/hooks/1")).to route_to("admin/hooks#destroy", id: "1") end end # admin_hook_hook_log_retry POST /admin/hooks/:hook_id/hook_logs/:id/retry(.:format) admin/hook_logs#retry # admin_hook_hook_log GET /admin/hooks/:hook_id/hook_logs/:id(.:format) admin/hook_logs#show -describe Admin::HookLogsController, 'routing' do - it 'to #retry' do - expect(post('/admin/hooks/1/hook_logs/1/retry')).to route_to('admin/hook_logs#retry', hook_id: '1', id: '1') +describe Admin::HookLogsController, "routing" do + it "to #retry" do + expect(post("/admin/hooks/1/hook_logs/1/retry")).to route_to("admin/hook_logs#retry", hook_id: "1", id: "1") end - it 'to #show' do - expect(get('/admin/hooks/1/hook_logs/1')).to route_to('admin/hook_logs#show', hook_id: '1', id: '1') + it "to #show" do + expect(get("/admin/hooks/1/hook_logs/1")).to route_to("admin/hook_logs#show", hook_id: "1", id: "1") end end # admin_logs GET /admin/logs(.:format) admin/logs#show describe Admin::LogsController, "routing" do it "to #show" do - expect(get("/admin/logs")).to route_to('admin/logs#show') + expect(get("/admin/logs")).to route_to("admin/logs#show") end end # admin_background_jobs GET /admin/background_jobs(.:format) admin/background_jobs#show describe Admin::BackgroundJobsController, "routing" do it "to #show" do - expect(get("/admin/background_jobs")).to route_to('admin/background_jobs#show') + expect(get("/admin/background_jobs")).to route_to("admin/background_jobs#show") end end # admin_root /admin(.:format) admin/dashboard#index describe Admin::DashboardController, "routing" do it "to #index" do - expect(get("/admin")).to route_to('admin/dashboard#index') + expect(get("/admin")).to route_to("admin/dashboard#index") end end # admin_health_check GET /admin/health_check(.:format) admin/health_check#show describe Admin::HealthCheckController, "routing" do it "to #show" do - expect(get("/admin/health_check")).to route_to('admin/health_check#show') + expect(get("/admin/health_check")).to route_to("admin/health_check#show") end end describe Admin::GroupsController, "routing" do - let(:name) { 'complex.group-namegit' } + let(:name) { "complex.group-namegit" } it "to #index" do - expect(get("/admin/groups")).to route_to('admin/groups#index') + expect(get("/admin/groups")).to route_to("admin/groups#index") end it "to #show" do - expect(get("/admin/groups/#{name}")).to route_to('admin/groups#show', id: name) - expect(get("/admin/groups/#{name}/subgroup")).to route_to('admin/groups#show', id: "#{name}/subgroup") + expect(get("/admin/groups/#{name}")).to route_to("admin/groups#show", id: name) + expect(get("/admin/groups/#{name}/subgroup")).to route_to("admin/groups#show", id: "#{name}/subgroup") end it "to #edit" do - expect(get("/admin/groups/#{name}/edit")).to route_to('admin/groups#edit', id: name) + expect(get("/admin/groups/#{name}/edit")).to route_to("admin/groups#edit", id: name) end end diff --git a/spec/routing/api_routing_spec.rb b/spec/routing/api_routing_spec.rb index 5fde4bd885b..b89669172f1 100644 --- a/spec/routing/api_routing_spec.rb +++ b/spec/routing/api_routing_spec.rb @@ -1,31 +1,31 @@ -require 'spec_helper' +require "spec_helper" -describe 'api', 'routing' do - context 'when graphql is disabled' do +describe "api", "routing" do + context "when graphql is disabled" do before do stub_feature_flags(graphql: false) end - it 'does not route to the GraphqlController' do - expect(get('/api/graphql')).not_to route_to('graphql#execute') + it "does not route to the GraphqlController" do + expect(get("/api/graphql")).not_to route_to("graphql#execute") end - it 'does not expose graphiql' do - expect(get('/-/graphql-explorer')).not_to route_to('graphiql/rails/editors#show') + it "does not expose graphiql" do + expect(get("/-/graphql-explorer")).not_to route_to("graphiql/rails/editors#show") end end - context 'when graphql is disabled' do + context "when graphql is disabled" do before do stub_feature_flags(graphql: true) end - it 'routes to the GraphqlController' do - expect(get('/api/graphql')).not_to route_to('graphql#execute') + it "routes to the GraphqlController" do + expect(get("/api/graphql")).not_to route_to("graphql#execute") end - it 'exposes graphiql' do - expect(get('/-/graphql-explorer')).not_to route_to('graphiql/rails/editors#show') + it "exposes graphiql" do + expect(get("/-/graphql-explorer")).not_to route_to("graphiql/rails/editors#show") end end end diff --git a/spec/routing/environments_spec.rb b/spec/routing/environments_spec.rb index aacbe300966..a6843c557f5 100644 --- a/spec/routing/environments_spec.rb +++ b/spec/routing/environments_spec.rb @@ -1,36 +1,36 @@ -require 'spec_helper' +require "spec_helper" -describe 'environments routing' do +describe "environments routing" do let(:project) { create(:project) } let(:environment) do create(:environment, project: project, - name: 'staging-1.0/review') + name: "staging-1.0/review") end let(:environments_route) do "#{project.namespace.name}/#{project.name}/environments/" end - describe 'routing environment folders' do - context 'when using JSON format' do - it 'correctly matches environment name and JSON format' do - expect(get_folder('staging-1.0.json')) - .to route_to(*folder_action(id: 'staging-1.0', format: 'json')) + describe "routing environment folders" do + context "when using JSON format" do + it "correctly matches environment name and JSON format" do + expect(get_folder("staging-1.0.json")) + .to route_to(*folder_action(id: "staging-1.0", format: "json")) end end - context 'when using HTML format' do - it 'correctly matches environment name and HTML format' do - expect(get_folder('staging-1.0.html')) - .to route_to(*folder_action(id: 'staging-1.0', format: 'html')) + context "when using HTML format" do + it "correctly matches environment name and HTML format" do + expect(get_folder("staging-1.0.html")) + .to route_to(*folder_action(id: "staging-1.0", format: "html")) end end - context 'when using implicit format' do - it 'correctly matches environment name' do - expect(get_folder('staging-1.0')) - .to route_to(*folder_action(id: 'staging-1.0')) + context "when using implicit format" do + it "correctly matches environment name" do + expect(get_folder("staging-1.0")) + .to route_to(*folder_action(id: "staging-1.0")) end end end @@ -41,9 +41,9 @@ describe 'environments routing' do end def folder_action(**opts) - options = { namespace_id: project.namespace.name, - project_id: project.name } + options = {namespace_id: project.namespace.name, + project_id: project.name,} - ['projects/environments#folder', options.merge(opts)] + ["projects/environments#folder", options.merge(opts)] end end diff --git a/spec/routing/group_routing_spec.rb b/spec/routing/group_routing_spec.rb index 71788028cbf..30863bcb8c3 100644 --- a/spec/routing/group_routing_spec.rb +++ b/spec/routing/group_routing_spec.rb @@ -1,132 +1,132 @@ -require 'spec_helper' +require "spec_helper" describe "Groups", "routing" do - let(:group_path) { 'complex.group-namegit' } + let(:group_path) { "complex.group-namegit" } let!(:group) { create(:group, path: group_path) } it "to #show" do - expect(get("/groups/#{group_path}")).to route_to('groups#show', id: group_path) + expect(get("/groups/#{group_path}")).to route_to("groups#show", id: group_path) end it "also supports nested groups" do nested_group = create(:group, parent: group) - expect(get("/#{group_path}/#{nested_group.path}")).to route_to('groups#show', id: "#{group_path}/#{nested_group.path}") + expect(get("/#{group_path}/#{nested_group.path}")).to route_to("groups#show", id: "#{group_path}/#{nested_group.path}") end it "also display group#show on the short path" do - expect(get("/#{group_path}")).to route_to('groups#show', id: group_path) + expect(get("/#{group_path}")).to route_to("groups#show", id: group_path) end it "to #activity" do - expect(get("/groups/#{group_path}/-/activity")).to route_to('groups#activity', id: group_path) + expect(get("/groups/#{group_path}/-/activity")).to route_to("groups#activity", id: group_path) end it "to #issues" do - expect(get("/groups/#{group_path}/-/issues")).to route_to('groups#issues', id: group_path) + expect(get("/groups/#{group_path}/-/issues")).to route_to("groups#issues", id: group_path) end it "to #members" do - expect(get("/groups/#{group_path}/-/group_members")).to route_to('groups/group_members#index', group_id: group_path) + expect(get("/groups/#{group_path}/-/group_members")).to route_to("groups/group_members#index", group_id: group_path) end it "to #labels" do - expect(get("/groups/#{group_path}/-/labels")).to route_to('groups/labels#index', group_id: group_path) + expect(get("/groups/#{group_path}/-/labels")).to route_to("groups/labels#index", group_id: group_path) end it "to #milestones" do - expect(get("/groups/#{group_path}/-/milestones")).to route_to('groups/milestones#index', group_id: group_path) + expect(get("/groups/#{group_path}/-/milestones")).to route_to("groups/milestones#index", group_id: group_path) end - describe 'legacy redirection' do - describe 'labels' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/labels", "/groups/complex.group-namegit/-/labels" do - let(:resource) { create(:group, parent: group, path: 'labels') } + describe "legacy redirection" do + describe "labels" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/labels", "/groups/complex.group-namegit/-/labels" do + let(:resource) { create(:group, parent: group, path: "labels") } end - context 'when requesting JSON' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/labels.json", "/groups/complex.group-namegit/-/labels.json" do - let(:resource) { create(:group, parent: group, path: 'labels') } + context "when requesting JSON" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/labels.json", "/groups/complex.group-namegit/-/labels.json" do + let(:resource) { create(:group, parent: group, path: "labels") } end end end - describe 'group_members' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/group_members", "/groups/complex.group-namegit/-/group_members" do - let(:resource) { create(:group, parent: group, path: 'group_members') } + describe "group_members" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/group_members", "/groups/complex.group-namegit/-/group_members" do + let(:resource) { create(:group, parent: group, path: "group_members") } end end - describe 'avatar' do - it 'routes to the avatars controller' do + describe "avatar" do + it "routes to the avatars controller" do expect(delete("/groups/#{group_path}/-/avatar")) .to route_to(group_id: group_path, - controller: 'groups/avatars', - action: 'destroy') + controller: "groups/avatars", + action: "destroy") end end - describe 'milestones' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/milestones", "/groups/complex.group-namegit/-/milestones" do - let(:resource) { create(:group, parent: group, path: 'milestones') } + describe "milestones" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/milestones", "/groups/complex.group-namegit/-/milestones" do + let(:resource) { create(:group, parent: group, path: "milestones") } end - context 'nested routes' do + context "nested routes" do include RSpec::Rails::RequestExampleGroup let(:milestone) { create(:milestone, group: group) } - it 'redirects the nested routes' do + it "redirects the nested routes" do request = get("/groups/#{group_path}/milestones/#{milestone.id}/merge_requests") expect(request).to redirect_to("/groups/#{group_path}/-/milestones/#{milestone.id}/merge_requests") end end - context 'with a query string' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/milestones?hello=world", "/groups/complex.group-namegit/-/milestones?hello=world" do - let(:resource) { create(:group, parent: group, path: 'milestones') } + context "with a query string" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/milestones?hello=world", "/groups/complex.group-namegit/-/milestones?hello=world" do + let(:resource) { create(:group, parent: group, path: "milestones") } end - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/milestones?milestones=/milestones", "/groups/complex.group-namegit/-/milestones?milestones=/milestones" do - let(:resource) { create(:group, parent: group, path: 'milestones') } + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/milestones?milestones=/milestones", "/groups/complex.group-namegit/-/milestones?milestones=/milestones" do + let(:resource) { create(:group, parent: group, path: "milestones") } end end end - describe 'edit' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/edit", "/groups/complex.group-namegit/-/edit" do + describe "edit" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/edit", "/groups/complex.group-namegit/-/edit" do let(:resource) do - pending('still rejected because of the wildcard reserved word') - create(:group, parent: group, path: 'edit') + pending("still rejected because of the wildcard reserved word") + create(:group, parent: group, path: "edit") end end end - describe 'issues' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/issues", "/groups/complex.group-namegit/-/issues" do - let(:resource) { create(:group, parent: group, path: 'issues') } + describe "issues" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/issues", "/groups/complex.group-namegit/-/issues" do + let(:resource) { create(:group, parent: group, path: "issues") } end end - describe 'merge_requests' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/merge_requests", "/groups/complex.group-namegit/-/merge_requests" do - let(:resource) { create(:group, parent: group, path: 'merge_requests') } + describe "merge_requests" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/merge_requests", "/groups/complex.group-namegit/-/merge_requests" do + let(:resource) { create(:group, parent: group, path: "merge_requests") } end end - describe 'projects' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/projects", "/groups/complex.group-namegit/-/projects" do - let(:resource) { create(:group, parent: group, path: 'projects') } + describe "projects" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/projects", "/groups/complex.group-namegit/-/projects" do + let(:resource) { create(:group, parent: group, path: "projects") } end end - describe 'activity' do - it_behaves_like 'redirecting a legacy path', "/groups/complex.group-namegit/activity", "/groups/complex.group-namegit/-/activity" do - let(:resource) { create(:group, parent: group, path: 'activity') } + describe "activity" do + it_behaves_like "redirecting a legacy path", "/groups/complex.group-namegit/activity", "/groups/complex.group-namegit/-/activity" do + let(:resource) { create(:group, parent: group, path: "activity") } end - it_behaves_like 'redirecting a legacy path', "/groups/activity/activity", "/groups/activity/-/activity" do - let!(:parent) { create(:group, path: 'activity') } - let(:resource) { create(:group, parent: parent, path: 'activity') } + it_behaves_like "redirecting a legacy path", "/groups/activity/activity", "/groups/activity/-/activity" do + let!(:parent) { create(:group, path: "activity") } + let(:resource) { create(:group, parent: parent, path: "activity") } end end end diff --git a/spec/routing/import_routing_spec.rb b/spec/routing/import_routing_spec.rb index 106f92082e4..0923770ef52 100644 --- a/spec/routing/import_routing_spec.rb +++ b/spec/routing/import_routing_spec.rb @@ -1,4 +1,4 @@ -require 'spec_helper' +require "spec_helper" # Shared examples for a resource inside a Project # @@ -21,7 +21,7 @@ require 'spec_helper' # let(:actions) { [:index] } # let(:controller) { 'issues' } # end -shared_examples 'importer routing' do +shared_examples "importer routing" do let(:except_actions) { [] } let(:is_realtime) { false } @@ -29,27 +29,27 @@ shared_examples 'importer routing' do except_actions.push(is_realtime ? :jobs : :realtime_changes) end - it 'to #create' do + it "to #create" do expect(post("/import/#{provider}")).to route_to("import/#{provider}#create") unless except_actions.include?(:create) end - it 'to #new' do + it "to #new" do expect(get("/import/#{provider}/new")).to route_to("import/#{provider}#new") unless except_actions.include?(:new) end - it 'to #status' do + it "to #status" do expect(get("/import/#{provider}/status")).to route_to("import/#{provider}#status") unless except_actions.include?(:status) end - it 'to #callback' do + it "to #callback" do expect(get("/import/#{provider}/callback")).to route_to("import/#{provider}#callback") unless except_actions.include?(:callback) end - it 'to #jobs' do + it "to #jobs" do expect(get("/import/#{provider}/jobs")).to route_to("import/#{provider}#jobs") unless except_actions.include?(:jobs) end - it 'to #realtime_changes' do + it "to #realtime_changes" do expect(get("/import/#{provider}/realtime_changes")).to route_to("import/#{provider}#realtime_changes") unless except_actions.include?(:realtime_changes) end end @@ -60,14 +60,14 @@ end # realtime_changes_import_github GET /import/github/realtime_changes(.:format) import/github#jobs # import_github POST /import/github(.:format) import/github#create # new_import_github GET /import/github/new(.:format) import/github#new -describe Import::GithubController, 'routing' do - it_behaves_like 'importer routing' do - let(:provider) { 'github' } +describe Import::GithubController, "routing" do + it_behaves_like "importer routing" do + let(:provider) { "github" } let(:is_realtime) { true } end - it 'to #personal_access_token' do - expect(post('/import/github/personal_access_token')).to route_to('import/github#personal_access_token') + it "to #personal_access_token" do + expect(post("/import/github/personal_access_token")).to route_to("import/github#personal_access_token") end end @@ -76,15 +76,15 @@ end # realtime_changes_import_gitea GET /import/gitea/realtime_changes(.:format) import/gitea#jobs # import_gitea POST /import/gitea(.:format) import/gitea#create # new_import_gitea GET /import/gitea/new(.:format) import/gitea#new -describe Import::GiteaController, 'routing' do - it_behaves_like 'importer routing' do +describe Import::GiteaController, "routing" do + it_behaves_like "importer routing" do let(:except_actions) { [:callback] } - let(:provider) { 'gitea' } + let(:provider) { "gitea" } let(:is_realtime) { true } end - it 'to #personal_access_token' do - expect(post('/import/gitea/personal_access_token')).to route_to('import/gitea#personal_access_token') + it "to #personal_access_token" do + expect(post("/import/gitea/personal_access_token")).to route_to("import/gitea#personal_access_token") end end @@ -92,10 +92,10 @@ end # callback_import_gitlab GET /import/gitlab/callback(.:format) import/gitlab#callback # jobs_import_gitlab GET /import/gitlab/jobs(.:format) import/gitlab#jobs # import_gitlab POST /import/gitlab(.:format) import/gitlab#create -describe Import::GitlabController, 'routing' do - it_behaves_like 'importer routing' do +describe Import::GitlabController, "routing" do + it_behaves_like "importer routing" do let(:except_actions) { [:new] } - let(:provider) { 'gitlab' } + let(:provider) { "gitlab" } end end @@ -103,10 +103,10 @@ end # callback_import_bitbucket GET /import/bitbucket/callback(.:format) import/bitbucket#callback # jobs_import_bitbucket GET /import/bitbucket/jobs(.:format) import/bitbucket#jobs # import_bitbucket POST /import/bitbucket(.:format) import/bitbucket#create -describe Import::BitbucketController, 'routing' do - it_behaves_like 'importer routing' do +describe Import::BitbucketController, "routing" do + it_behaves_like "importer routing" do let(:except_actions) { [:new] } - let(:provider) { 'bitbucket' } + let(:provider) { "bitbucket" } end end @@ -117,22 +117,22 @@ end # create_user_map_import_google_code POST /import/google_code/user_map(.:format) import/google_code#create_user_map # import_google_code POST /import/google_code(.:format) import/google_code#create # new_import_google_code GET /import/google_code/new(.:format) import/google_code#new -describe Import::GoogleCodeController, 'routing' do - it_behaves_like 'importer routing' do +describe Import::GoogleCodeController, "routing" do + it_behaves_like "importer routing" do let(:except_actions) { [:callback] } - let(:provider) { 'google_code' } + let(:provider) { "google_code" } end - it 'to #callback' do + it "to #callback" do expect(post("/import/google_code/callback")).to route_to("import/google_code#callback") end - it 'to #new_user_map' do - expect(get('/import/google_code/user_map')).to route_to('import/google_code#new_user_map') + it "to #new_user_map" do + expect(get("/import/google_code/user_map")).to route_to("import/google_code#new_user_map") end - it 'to #create_user_map' do - expect(post('/import/google_code/user_map')).to route_to('import/google_code#create_user_map') + it "to #create_user_map" do + expect(post("/import/google_code/user_map")).to route_to("import/google_code#create_user_map") end end @@ -143,34 +143,34 @@ end # create_user_map_import_fogbugz POST /import/fogbugz/user_map(.:format) import/fogbugz#create_user_map # import_fogbugz POST /import/fogbugz(.:format) import/fogbugz#create # new_import_fogbugz GET /import/fogbugz/new(.:format) import/fogbugz#new -describe Import::FogbugzController, 'routing' do - it_behaves_like 'importer routing' do +describe Import::FogbugzController, "routing" do + it_behaves_like "importer routing" do let(:except_actions) { [:callback] } - let(:provider) { 'fogbugz' } + let(:provider) { "fogbugz" } end - it 'to #callback' do + it "to #callback" do expect(post("/import/fogbugz/callback")).to route_to("import/fogbugz#callback") end - it 'to #new_user_map' do - expect(get('/import/fogbugz/user_map')).to route_to('import/fogbugz#new_user_map') + it "to #new_user_map" do + expect(get("/import/fogbugz/user_map")).to route_to("import/fogbugz#new_user_map") end - it 'to #create_user_map' do - expect(post('/import/fogbugz/user_map')).to route_to('import/fogbugz#create_user_map') + it "to #create_user_map" do + expect(post("/import/fogbugz/user_map")).to route_to("import/fogbugz#create_user_map") end end # import_gitlab_project POST /import/gitlab_project(.:format) import/gitlab_projects#create # POST /import/gitlab_project(.:format) import/gitlab_projects#create # new_import_gitlab_project GET /import/gitlab_project/new(.:format) import/gitlab_projects#new -describe Import::GitlabProjectsController, 'routing' do - it 'to #create' do - expect(post('/import/gitlab_project')).to route_to('import/gitlab_projects#create') +describe Import::GitlabProjectsController, "routing" do + it "to #create" do + expect(post("/import/gitlab_project")).to route_to("import/gitlab_projects#create") end - it 'to #new' do - expect(get('/import/gitlab_project/new')).to route_to('import/gitlab_projects#new') + it "to #new" do + expect(get("/import/gitlab_project/new")).to route_to("import/gitlab_projects#new") end end diff --git a/spec/routing/instance_statistics_routing_spec.rb b/spec/routing/instance_statistics_routing_spec.rb index b94faabfa1d..142cbe9d949 100644 --- a/spec/routing/instance_statistics_routing_spec.rb +++ b/spec/routing/instance_statistics_routing_spec.rb @@ -1,11 +1,11 @@ # frozen_string_literal: true -require 'spec_helper' +require "spec_helper" -describe 'Instance Statistics', 'routing' do +describe "Instance Statistics", "routing" do include RSpec::Rails::RequestExampleGroup it "routes '/-/instance_statistics' to conversational development index" do - expect(get('/-/instance_statistics')).to redirect_to('/-/instance_statistics/conversational_development_index') + expect(get("/-/instance_statistics")).to redirect_to("/-/instance_statistics/conversational_development_index") end end diff --git a/spec/routing/openid_connect_spec.rb b/spec/routing/openid_connect_spec.rb index 2c3bc08f1a1..672c5511201 100644 --- a/spec/routing/openid_connect_spec.rb +++ b/spec/routing/openid_connect_spec.rb @@ -1,30 +1,30 @@ -require 'spec_helper' +require "spec_helper" # oauth_discovery_keys GET /oauth/discovery/keys(.:format) doorkeeper/openid_connect/discovery#keys # oauth_discovery_provider GET /.well-known/openid-configuration(.:format) doorkeeper/openid_connect/discovery#provider # oauth_discovery_webfinger GET /.well-known/webfinger(.:format) doorkeeper/openid_connect/discovery#webfinger -describe Doorkeeper::OpenidConnect::DiscoveryController, 'routing' do +describe Doorkeeper::OpenidConnect::DiscoveryController, "routing" do it "to #provider" do - expect(get('/.well-known/openid-configuration')).to route_to('doorkeeper/openid_connect/discovery#provider') + expect(get("/.well-known/openid-configuration")).to route_to("doorkeeper/openid_connect/discovery#provider") end it "to #webfinger" do - expect(get('/.well-known/webfinger')).to route_to('doorkeeper/openid_connect/discovery#webfinger') + expect(get("/.well-known/webfinger")).to route_to("doorkeeper/openid_connect/discovery#webfinger") end it "to #keys" do - expect(get('/oauth/discovery/keys')).to route_to('doorkeeper/openid_connect/discovery#keys') + expect(get("/oauth/discovery/keys")).to route_to("doorkeeper/openid_connect/discovery#keys") end end # oauth_userinfo GET /oauth/userinfo(.:format) doorkeeper/openid_connect/userinfo#show # POST /oauth/userinfo(.:format) doorkeeper/openid_connect/userinfo#show -describe Doorkeeper::OpenidConnect::UserinfoController, 'routing' do +describe Doorkeeper::OpenidConnect::UserinfoController, "routing" do it "to #show" do - expect(get('/oauth/userinfo')).to route_to('doorkeeper/openid_connect/userinfo#show') + expect(get("/oauth/userinfo")).to route_to("doorkeeper/openid_connect/userinfo#show") end it "to #show" do - expect(post('/oauth/userinfo')).to route_to('doorkeeper/openid_connect/userinfo#show') + expect(post("/oauth/userinfo")).to route_to("doorkeeper/openid_connect/userinfo#show") end end diff --git a/spec/routing/project_routing_spec.rb b/spec/routing/project_routing_spec.rb index a0d01fc8263..1853e65ef1e 100644 --- a/spec/routing/project_routing_spec.rb +++ b/spec/routing/project_routing_spec.rb @@ -1,9 +1,9 @@ -require 'spec_helper' +require "spec_helper" -describe 'project routing' do +describe "project routing" do before do allow(Project).to receive(:find_by_full_path).and_return(false) - allow(Project).to receive(:find_by_full_path).with('gitlab/gitlabhq', any_args).and_return(true) + allow(Project).to receive(:find_by_full_path).with("gitlab/gitlabhq", any_args).and_return(true) end # Shared examples for a resource inside a Project @@ -33,36 +33,36 @@ describe 'project routing' do # let(:controller) { 'pages_domains' } # let(:controller_path) { 'pages/domains' } # end - shared_examples 'RESTful project resources' do + shared_examples "RESTful project resources" do let(:actions) { [:index, :create, :new, :edit, :show, :update, :destroy] } let(:controller_path) { controller } - it 'to #index' do - expect(get("/gitlab/gitlabhq/#{controller_path}")).to route_to("projects/#{controller}#index", namespace_id: 'gitlab', project_id: 'gitlabhq') if actions.include?(:index) + it "to #index" do + expect(get("/gitlab/gitlabhq/#{controller_path}")).to route_to("projects/#{controller}#index", namespace_id: "gitlab", project_id: "gitlabhq") if actions.include?(:index) end - it 'to #create' do - expect(post("/gitlab/gitlabhq/#{controller_path}")).to route_to("projects/#{controller}#create", namespace_id: 'gitlab', project_id: 'gitlabhq') if actions.include?(:create) + it "to #create" do + expect(post("/gitlab/gitlabhq/#{controller_path}")).to route_to("projects/#{controller}#create", namespace_id: "gitlab", project_id: "gitlabhq") if actions.include?(:create) end - it 'to #new' do - expect(get("/gitlab/gitlabhq/#{controller_path}/new")).to route_to("projects/#{controller}#new", namespace_id: 'gitlab', project_id: 'gitlabhq') if actions.include?(:new) + it "to #new" do + expect(get("/gitlab/gitlabhq/#{controller_path}/new")).to route_to("projects/#{controller}#new", namespace_id: "gitlab", project_id: "gitlabhq") if actions.include?(:new) end - it 'to #edit' do - expect(get("/gitlab/gitlabhq/#{controller_path}/1/edit")).to route_to("projects/#{controller}#edit", namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') if actions.include?(:edit) + it "to #edit" do + expect(get("/gitlab/gitlabhq/#{controller_path}/1/edit")).to route_to("projects/#{controller}#edit", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") if actions.include?(:edit) end - it 'to #show' do - expect(get("/gitlab/gitlabhq/#{controller_path}/1")).to route_to("projects/#{controller}#show", namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') if actions.include?(:show) + it "to #show" do + expect(get("/gitlab/gitlabhq/#{controller_path}/1")).to route_to("projects/#{controller}#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") if actions.include?(:show) end - it 'to #update' do - expect(put("/gitlab/gitlabhq/#{controller_path}/1")).to route_to("projects/#{controller}#update", namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') if actions.include?(:update) + it "to #update" do + expect(put("/gitlab/gitlabhq/#{controller_path}/1")).to route_to("projects/#{controller}#update", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") if actions.include?(:update) end - it 'to #destroy' do - expect(delete("/gitlab/gitlabhq/#{controller_path}/1")).to route_to("projects/#{controller}#destroy", namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') if actions.include?(:destroy) + it "to #destroy" do + expect(delete("/gitlab/gitlabhq/#{controller_path}/1")).to route_to("projects/#{controller}#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") if actions.include?(:destroy) end end @@ -74,57 +74,57 @@ describe 'project routing' do # PUT /:id(.:format) projects#update # DELETE /:id(.:format) projects#destroy # preview_markdown_project POST /:id/preview_markdown(.:format) projects#preview_markdown - describe ProjectsController, 'routing' do - it 'to #create' do - expect(post('/projects')).to route_to('projects#create') + describe ProjectsController, "routing" do + it "to #create" do + expect(post("/projects")).to route_to("projects#create") end - it 'to #new' do - expect(get('/projects/new')).to route_to('projects#new') + it "to #new" do + expect(get("/projects/new")).to route_to("projects#new") end - it 'to #edit' do - expect(get('/gitlab/gitlabhq/edit')).to route_to('projects#edit', namespace_id: 'gitlab', id: 'gitlabhq') + it "to #edit" do + expect(get("/gitlab/gitlabhq/edit")).to route_to("projects#edit", namespace_id: "gitlab", id: "gitlabhq") end - describe 'to #show' do - context 'regular name' do - it { expect(get('/gitlab/gitlabhq')).to route_to('projects#show', namespace_id: 'gitlab', id: 'gitlabhq') } + describe "to #show" do + context "regular name" do + it { expect(get("/gitlab/gitlabhq")).to route_to("projects#show", namespace_id: "gitlab", id: "gitlabhq") } end - context 'name with dot' do + context "name with dot" do before do - allow(Project).to receive(:find_by_full_path).with('gitlab/gitlabhq.keys', any_args).and_return(true) + allow(Project).to receive(:find_by_full_path).with("gitlab/gitlabhq.keys", any_args).and_return(true) end - it { expect(get('/gitlab/gitlabhq.keys')).to route_to('projects#show', namespace_id: 'gitlab', id: 'gitlabhq.keys') } + it { expect(get("/gitlab/gitlabhq.keys")).to route_to("projects#show", namespace_id: "gitlab", id: "gitlabhq.keys") } end - context 'with nested group' do + context "with nested group" do before do - allow(Project).to receive(:find_by_full_path).with('gitlab/subgroup/gitlabhq', any_args).and_return(true) + allow(Project).to receive(:find_by_full_path).with("gitlab/subgroup/gitlabhq", any_args).and_return(true) end - it { expect(get('/gitlab/subgroup/gitlabhq')).to route_to('projects#show', namespace_id: 'gitlab/subgroup', id: 'gitlabhq') } + it { expect(get("/gitlab/subgroup/gitlabhq")).to route_to("projects#show", namespace_id: "gitlab/subgroup", id: "gitlabhq") } end end - it 'to #update' do - expect(put('/gitlab/gitlabhq')).to route_to('projects#update', namespace_id: 'gitlab', id: 'gitlabhq') + it "to #update" do + expect(put("/gitlab/gitlabhq")).to route_to("projects#update", namespace_id: "gitlab", id: "gitlabhq") end - it 'to #destroy' do - expect(delete('/gitlab/gitlabhq')).to route_to('projects#destroy', namespace_id: 'gitlab', id: 'gitlabhq') + it "to #destroy" do + expect(delete("/gitlab/gitlabhq")).to route_to("projects#destroy", namespace_id: "gitlab", id: "gitlabhq") end - it 'to #preview_markdown' do - expect(post('/gitlab/gitlabhq/preview_markdown')).to( - route_to('projects#preview_markdown', namespace_id: 'gitlab', id: 'gitlabhq') + it "to #preview_markdown" do + expect(post("/gitlab/gitlabhq/preview_markdown")).to( + route_to("projects#preview_markdown", namespace_id: "gitlab", id: "gitlabhq") ) end - it 'to #resolve' do - expect(get('/projects/1')).to route_to('projects#resolve', id: '1') + it "to #resolve" do + expect(get("/projects/1")).to route_to("projects#resolve", id: "1") end end @@ -135,10 +135,10 @@ describe 'project routing' do # milestones_namespace_project_autocomplete_sources_path GET /:project_id/autocomplete_sources/milestones(.:format) projects/autocomplete_sources#milestones # commands_namespace_project_autocomplete_sources_path GET /:project_id/autocomplete_sources/commands(.:format) projects/autocomplete_sources#commands # snippets_namespace_project_autocomplete_sources_path GET /:project_id/autocomplete_sources/snippets(.:format) projects/autocomplete_sources#snippets - describe Projects::AutocompleteSourcesController, 'routing' do + describe Projects::AutocompleteSourcesController, "routing" do [:members, :issues, :merge_requests, :labels, :milestones, :commands, :snippets].each do |action| it "to ##{action}" do - expect(get("/gitlab/gitlabhq/autocomplete_sources/#{action}")).to route_to("projects/autocomplete_sources##{action}", namespace_id: 'gitlab', project_id: 'gitlabhq') + expect(get("/gitlab/gitlabhq/autocomplete_sources/#{action}")).to route_to("projects/autocomplete_sources##{action}", namespace_id: "gitlab", project_id: "gitlabhq") end end end @@ -149,18 +149,18 @@ describe 'project routing' do # edit_project_wiki GET /:project_id/wikis/:id/edit(.:format) projects/wikis#edit # project_wiki GET /:project_id/wikis/:id(.:format) projects/wikis#show # DELETE /:project_id/wikis/:id(.:format) projects/wikis#destroy - describe Projects::WikisController, 'routing' do - it 'to #pages' do - expect(get('/gitlab/gitlabhq/wikis/pages')).to route_to('projects/wikis#pages', namespace_id: 'gitlab', project_id: 'gitlabhq') + describe Projects::WikisController, "routing" do + it "to #pages" do + expect(get("/gitlab/gitlabhq/wikis/pages")).to route_to("projects/wikis#pages", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #history' do - expect(get('/gitlab/gitlabhq/wikis/1/history')).to route_to('projects/wikis#history', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') + it "to #history" do + expect(get("/gitlab/gitlabhq/wikis/1/history")).to route_to("projects/wikis#history", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end - it_behaves_like 'RESTful project resources' do + it_behaves_like "RESTful project resources" do let(:actions) { [:create, :edit, :show, :destroy] } - let(:controller) { 'wikis' } + let(:controller) { "wikis" } end end @@ -168,61 +168,61 @@ describe 'project routing' do # tags_project_repository GET /:project_id/repository/tags(.:format) projects/repositories#tags # archive_project_repository GET /:project_id/repository/archive(.:format) projects/repositories#archive # edit_project_repository GET /:project_id/repository/edit(.:format) projects/repositories#edit - describe Projects::RepositoriesController, 'routing' do - it 'to #archive format:zip' do - expect(get('/gitlab/gitlabhq/-/archive/master/archive.zip')).to route_to('projects/repositories#archive', namespace_id: 'gitlab', project_id: 'gitlabhq', format: 'zip', id: 'master/archive') + describe Projects::RepositoriesController, "routing" do + it "to #archive format:zip" do + expect(get("/gitlab/gitlabhq/-/archive/master/archive.zip")).to route_to("projects/repositories#archive", namespace_id: "gitlab", project_id: "gitlabhq", format: "zip", id: "master/archive") end - it 'to #archive format:tar.bz2' do - expect(get('/gitlab/gitlabhq/-/archive/master/archive.tar.bz2')).to route_to('projects/repositories#archive', namespace_id: 'gitlab', project_id: 'gitlabhq', format: 'tar.bz2', id: 'master/archive') + it "to #archive format:tar.bz2" do + expect(get("/gitlab/gitlabhq/-/archive/master/archive.tar.bz2")).to route_to("projects/repositories#archive", namespace_id: "gitlab", project_id: "gitlabhq", format: "tar.bz2", id: "master/archive") end it 'to #archive with "/" in route' do - expect(get('/gitlab/gitlabhq/-/archive/improve/awesome/gitlabhq-improve-awesome.tar.gz')).to route_to('projects/repositories#archive', namespace_id: 'gitlab', project_id: 'gitlabhq', format: 'tar.gz', id: 'improve/awesome/gitlabhq-improve-awesome') + expect(get("/gitlab/gitlabhq/-/archive/improve/awesome/gitlabhq-improve-awesome.tar.gz")).to route_to("projects/repositories#archive", namespace_id: "gitlab", project_id: "gitlabhq", format: "tar.gz", id: "improve/awesome/gitlabhq-improve-awesome") end - it 'to #archive_alternative' do - expect(get('/gitlab/gitlabhq/repository/archive')).to route_to('projects/repositories#archive', namespace_id: 'gitlab', project_id: 'gitlabhq', append_sha: true) + it "to #archive_alternative" do + expect(get("/gitlab/gitlabhq/repository/archive")).to route_to("projects/repositories#archive", namespace_id: "gitlab", project_id: "gitlabhq", append_sha: true) end - it 'to #archive_deprecated' do - expect(get('/gitlab/gitlabhq/repository/master/archive')).to route_to('projects/repositories#archive', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master', append_sha: true) + it "to #archive_deprecated" do + expect(get("/gitlab/gitlabhq/repository/master/archive")).to route_to("projects/repositories#archive", namespace_id: "gitlab", project_id: "gitlabhq", id: "master", append_sha: true) end - it 'to #archive_deprecated format:zip' do - expect(get('/gitlab/gitlabhq/repository/master/archive.zip')).to route_to('projects/repositories#archive', namespace_id: 'gitlab', project_id: 'gitlabhq', format: 'zip', id: 'master', append_sha: true) + it "to #archive_deprecated format:zip" do + expect(get("/gitlab/gitlabhq/repository/master/archive.zip")).to route_to("projects/repositories#archive", namespace_id: "gitlab", project_id: "gitlabhq", format: "zip", id: "master", append_sha: true) end - it 'to #archive_deprecated format:tar.bz2' do - expect(get('/gitlab/gitlabhq/repository/master/archive.tar.bz2')).to route_to('projects/repositories#archive', namespace_id: 'gitlab', project_id: 'gitlabhq', format: 'tar.bz2', id: 'master', append_sha: true) + it "to #archive_deprecated format:tar.bz2" do + expect(get("/gitlab/gitlabhq/repository/master/archive.tar.bz2")).to route_to("projects/repositories#archive", namespace_id: "gitlab", project_id: "gitlabhq", format: "tar.bz2", id: "master", append_sha: true) end it 'to #archive_deprecated with "/" in route' do - expect(get('/gitlab/gitlabhq/repository/improve/awesome/archive')).to route_to('projects/repositories#archive', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'improve/awesome', append_sha: true) + expect(get("/gitlab/gitlabhq/repository/improve/awesome/archive")).to route_to("projects/repositories#archive", namespace_id: "gitlab", project_id: "gitlabhq", id: "improve/awesome", append_sha: true) end end - describe Projects::BranchesController, 'routing' do - it 'to #branches' do - expect(get('/gitlab/gitlabhq/branches')).to route_to('projects/branches#index', namespace_id: 'gitlab', project_id: 'gitlabhq') - expect(delete('/gitlab/gitlabhq/branches/feature%2345')).to route_to('projects/branches#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature#45') - expect(delete('/gitlab/gitlabhq/branches/feature%2B45')).to route_to('projects/branches#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature+45') - expect(delete('/gitlab/gitlabhq/branches/feature@45')).to route_to('projects/branches#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature@45') - expect(delete('/gitlab/gitlabhq/branches/feature%2345/foo/bar/baz')).to route_to('projects/branches#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature#45/foo/bar/baz') - expect(delete('/gitlab/gitlabhq/branches/feature%2B45/foo/bar/baz')).to route_to('projects/branches#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature+45/foo/bar/baz') - expect(delete('/gitlab/gitlabhq/branches/feature@45/foo/bar/baz')).to route_to('projects/branches#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature@45/foo/bar/baz') + describe Projects::BranchesController, "routing" do + it "to #branches" do + expect(get("/gitlab/gitlabhq/branches")).to route_to("projects/branches#index", namespace_id: "gitlab", project_id: "gitlabhq") + expect(delete("/gitlab/gitlabhq/branches/feature%2345")).to route_to("projects/branches#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature#45") + expect(delete("/gitlab/gitlabhq/branches/feature%2B45")).to route_to("projects/branches#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature+45") + expect(delete("/gitlab/gitlabhq/branches/feature@45")).to route_to("projects/branches#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature@45") + expect(delete("/gitlab/gitlabhq/branches/feature%2345/foo/bar/baz")).to route_to("projects/branches#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature#45/foo/bar/baz") + expect(delete("/gitlab/gitlabhq/branches/feature%2B45/foo/bar/baz")).to route_to("projects/branches#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature+45/foo/bar/baz") + expect(delete("/gitlab/gitlabhq/branches/feature@45/foo/bar/baz")).to route_to("projects/branches#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature@45/foo/bar/baz") end end - describe Projects::TagsController, 'routing' do - it 'to #tags' do - expect(get('/gitlab/gitlabhq/tags')).to route_to('projects/tags#index', namespace_id: 'gitlab', project_id: 'gitlabhq') - expect(delete('/gitlab/gitlabhq/tags/feature%2345')).to route_to('projects/tags#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature#45') - expect(delete('/gitlab/gitlabhq/tags/feature%2B45')).to route_to('projects/tags#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature+45') - expect(delete('/gitlab/gitlabhq/tags/feature@45')).to route_to('projects/tags#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature@45') - expect(delete('/gitlab/gitlabhq/tags/feature%2345/foo/bar/baz')).to route_to('projects/tags#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature#45/foo/bar/baz') - expect(delete('/gitlab/gitlabhq/tags/feature%2B45/foo/bar/baz')).to route_to('projects/tags#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature+45/foo/bar/baz') - expect(delete('/gitlab/gitlabhq/tags/feature@45/foo/bar/baz')).to route_to('projects/tags#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature@45/foo/bar/baz') + describe Projects::TagsController, "routing" do + it "to #tags" do + expect(get("/gitlab/gitlabhq/tags")).to route_to("projects/tags#index", namespace_id: "gitlab", project_id: "gitlabhq") + expect(delete("/gitlab/gitlabhq/tags/feature%2345")).to route_to("projects/tags#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature#45") + expect(delete("/gitlab/gitlabhq/tags/feature%2B45")).to route_to("projects/tags#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature+45") + expect(delete("/gitlab/gitlabhq/tags/feature@45")).to route_to("projects/tags#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature@45") + expect(delete("/gitlab/gitlabhq/tags/feature%2345/foo/bar/baz")).to route_to("projects/tags#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature#45/foo/bar/baz") + expect(delete("/gitlab/gitlabhq/tags/feature%2B45/foo/bar/baz")).to route_to("projects/tags#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature+45/foo/bar/baz") + expect(delete("/gitlab/gitlabhq/tags/feature@45/foo/bar/baz")).to route_to("projects/tags#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature@45/foo/bar/baz") end end @@ -233,111 +233,111 @@ describe 'project routing' do # edit_project_deploy_key GET /:project_id/deploy_keys/:id/edit(.:format) deploy_keys#edit # project_deploy_key PATCH /:project_id/deploy_keys/:id(.:format) deploy_keys#update # DELETE /:project_id/deploy_keys/:id(.:format) deploy_keys#destroy - describe Projects::DeployKeysController, 'routing' do - it_behaves_like 'RESTful project resources' do + describe Projects::DeployKeysController, "routing" do + it_behaves_like "RESTful project resources" do let(:actions) { [:index, :new, :create, :edit, :update] } - let(:controller) { 'deploy_keys' } + let(:controller) { "deploy_keys" } end end # project_protected_branches GET /:project_id/protected_branches(.:format) protected_branches#index # POST /:project_id/protected_branches(.:format) protected_branches#create # project_protected_branch DELETE /:project_id/protected_branches/:id(.:format) protected_branches#destroy - describe Projects::ProtectedBranchesController, 'routing' do - it_behaves_like 'RESTful project resources' do + describe Projects::ProtectedBranchesController, "routing" do + it_behaves_like "RESTful project resources" do let(:actions) { [:index, :create, :destroy] } - let(:controller) { 'protected_branches' } + let(:controller) { "protected_branches" } end end # switch_project_refs GET /:project_id/refs/switch(.:format) refs#switch # logs_tree_project_ref GET /:project_id/refs/:id/logs_tree(.:format) refs#logs_tree # logs_file_project_ref GET /:project_id/refs/:id/logs_tree/:path(.:format) refs#logs_tree - describe Projects::RefsController, 'routing' do - it 'to #switch' do - expect(get('/gitlab/gitlabhq/refs/switch')).to route_to('projects/refs#switch', namespace_id: 'gitlab', project_id: 'gitlabhq') + describe Projects::RefsController, "routing" do + it "to #switch" do + expect(get("/gitlab/gitlabhq/refs/switch")).to route_to("projects/refs#switch", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #logs_tree' do - expect(get('/gitlab/gitlabhq/refs/stable/logs_tree')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'stable') - expect(get('/gitlab/gitlabhq/refs/feature%2345/logs_tree')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature#45') - expect(get('/gitlab/gitlabhq/refs/feature%2B45/logs_tree')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature+45') - expect(get('/gitlab/gitlabhq/refs/feature@45/logs_tree')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature@45') - expect(get('/gitlab/gitlabhq/refs/stable/logs_tree/foo/bar/baz')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'stable', path: 'foo/bar/baz') - expect(get('/gitlab/gitlabhq/refs/feature%2345/logs_tree/foo/bar/baz')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature#45', path: 'foo/bar/baz') - expect(get('/gitlab/gitlabhq/refs/feature%2B45/logs_tree/foo/bar/baz')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature+45', path: 'foo/bar/baz') - expect(get('/gitlab/gitlabhq/refs/feature@45/logs_tree/foo/bar/baz')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'feature@45', path: 'foo/bar/baz') - expect(get('/gitlab/gitlabhq/refs/stable/logs_tree/files.scss')).to route_to('projects/refs#logs_tree', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'stable', path: 'files.scss') + it "to #logs_tree" do + expect(get("/gitlab/gitlabhq/refs/stable/logs_tree")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "stable") + expect(get("/gitlab/gitlabhq/refs/feature%2345/logs_tree")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature#45") + expect(get("/gitlab/gitlabhq/refs/feature%2B45/logs_tree")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature+45") + expect(get("/gitlab/gitlabhq/refs/feature@45/logs_tree")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature@45") + expect(get("/gitlab/gitlabhq/refs/stable/logs_tree/foo/bar/baz")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "stable", path: "foo/bar/baz") + expect(get("/gitlab/gitlabhq/refs/feature%2345/logs_tree/foo/bar/baz")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature#45", path: "foo/bar/baz") + expect(get("/gitlab/gitlabhq/refs/feature%2B45/logs_tree/foo/bar/baz")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature+45", path: "foo/bar/baz") + expect(get("/gitlab/gitlabhq/refs/feature@45/logs_tree/foo/bar/baz")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "feature@45", path: "foo/bar/baz") + expect(get("/gitlab/gitlabhq/refs/stable/logs_tree/files.scss")).to route_to("projects/refs#logs_tree", namespace_id: "gitlab", project_id: "gitlabhq", id: "stable", path: "files.scss") end end - describe Projects::MergeRequestsController, 'routing' do - it 'to #commits' do - expect(get('/gitlab/gitlabhq/merge_requests/1/commits.json')).to route_to('projects/merge_requests#commits', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1', format: 'json') + describe Projects::MergeRequestsController, "routing" do + it "to #commits" do + expect(get("/gitlab/gitlabhq/merge_requests/1/commits.json")).to route_to("projects/merge_requests#commits", namespace_id: "gitlab", project_id: "gitlabhq", id: "1", format: "json") end - it 'to #pipelines' do - expect(get('/gitlab/gitlabhq/merge_requests/1/pipelines.json')).to route_to('projects/merge_requests#pipelines', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1', format: 'json') + it "to #pipelines" do + expect(get("/gitlab/gitlabhq/merge_requests/1/pipelines.json")).to route_to("projects/merge_requests#pipelines", namespace_id: "gitlab", project_id: "gitlabhq", id: "1", format: "json") end - it 'to #merge' do - expect(post('/gitlab/gitlabhq/merge_requests/1/merge')).to route_to( - 'projects/merge_requests#merge', - namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1' + it "to #merge" do + expect(post("/gitlab/gitlabhq/merge_requests/1/merge")).to route_to( + "projects/merge_requests#merge", + namespace_id: "gitlab", project_id: "gitlabhq", id: "1" ) end - it 'to #show' do - expect(get('/gitlab/gitlabhq/merge_requests/1.diff')).to route_to('projects/merge_requests#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1', format: 'diff') - expect(get('/gitlab/gitlabhq/merge_requests/1.patch')).to route_to('projects/merge_requests#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1', format: 'patch') - expect(get('/gitlab/gitlabhq/merge_requests/1/diffs')).to route_to('projects/merge_requests#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1', tab: 'diffs') - expect(get('/gitlab/gitlabhq/merge_requests/1/commits')).to route_to('projects/merge_requests#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1', tab: 'commits') - expect(get('/gitlab/gitlabhq/merge_requests/1/pipelines')).to route_to('projects/merge_requests#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1', tab: 'pipelines') + it "to #show" do + expect(get("/gitlab/gitlabhq/merge_requests/1.diff")).to route_to("projects/merge_requests#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1", format: "diff") + expect(get("/gitlab/gitlabhq/merge_requests/1.patch")).to route_to("projects/merge_requests#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1", format: "patch") + expect(get("/gitlab/gitlabhq/merge_requests/1/diffs")).to route_to("projects/merge_requests#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1", tab: "diffs") + expect(get("/gitlab/gitlabhq/merge_requests/1/commits")).to route_to("projects/merge_requests#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1", tab: "commits") + expect(get("/gitlab/gitlabhq/merge_requests/1/pipelines")).to route_to("projects/merge_requests#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1", tab: "pipelines") end - it_behaves_like 'RESTful project resources' do - let(:controller) { 'merge_requests' } + it_behaves_like "RESTful project resources" do + let(:controller) { "merge_requests" } let(:actions) { [:index, :edit, :show, :update] } end end - describe Projects::MergeRequests::CreationsController, 'routing' do - it 'to #new' do - expect(get('/gitlab/gitlabhq/merge_requests/new')).to route_to('projects/merge_requests/creations#new', namespace_id: 'gitlab', project_id: 'gitlabhq') - expect(get('/gitlab/gitlabhq/merge_requests/new/diffs')).to route_to('projects/merge_requests/creations#new', namespace_id: 'gitlab', project_id: 'gitlabhq', tab: 'diffs') - expect(get('/gitlab/gitlabhq/merge_requests/new/pipelines')).to route_to('projects/merge_requests/creations#new', namespace_id: 'gitlab', project_id: 'gitlabhq', tab: 'pipelines') + describe Projects::MergeRequests::CreationsController, "routing" do + it "to #new" do + expect(get("/gitlab/gitlabhq/merge_requests/new")).to route_to("projects/merge_requests/creations#new", namespace_id: "gitlab", project_id: "gitlabhq") + expect(get("/gitlab/gitlabhq/merge_requests/new/diffs")).to route_to("projects/merge_requests/creations#new", namespace_id: "gitlab", project_id: "gitlabhq", tab: "diffs") + expect(get("/gitlab/gitlabhq/merge_requests/new/pipelines")).to route_to("projects/merge_requests/creations#new", namespace_id: "gitlab", project_id: "gitlabhq", tab: "pipelines") end - it 'to #create' do - expect(post('/gitlab/gitlabhq/merge_requests')).to route_to('projects/merge_requests/creations#create', namespace_id: 'gitlab', project_id: 'gitlabhq') + it "to #create" do + expect(post("/gitlab/gitlabhq/merge_requests")).to route_to("projects/merge_requests/creations#create", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #branch_from' do - expect(get('/gitlab/gitlabhq/merge_requests/new/branch_from')).to route_to('projects/merge_requests/creations#branch_from', namespace_id: 'gitlab', project_id: 'gitlabhq') + it "to #branch_from" do + expect(get("/gitlab/gitlabhq/merge_requests/new/branch_from")).to route_to("projects/merge_requests/creations#branch_from", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #branch_to' do - expect(get('/gitlab/gitlabhq/merge_requests/new/branch_to')).to route_to('projects/merge_requests/creations#branch_to', namespace_id: 'gitlab', project_id: 'gitlabhq') + it "to #branch_to" do + expect(get("/gitlab/gitlabhq/merge_requests/new/branch_to")).to route_to("projects/merge_requests/creations#branch_to", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #pipelines' do - expect(get('/gitlab/gitlabhq/merge_requests/new/pipelines.json')).to route_to('projects/merge_requests/creations#pipelines', namespace_id: 'gitlab', project_id: 'gitlabhq', format: 'json') + it "to #pipelines" do + expect(get("/gitlab/gitlabhq/merge_requests/new/pipelines.json")).to route_to("projects/merge_requests/creations#pipelines", namespace_id: "gitlab", project_id: "gitlabhq", format: "json") end - it 'to #diffs' do - expect(get('/gitlab/gitlabhq/merge_requests/new/diffs.json')).to route_to('projects/merge_requests/creations#diffs', namespace_id: 'gitlab', project_id: 'gitlabhq', format: 'json') + it "to #diffs" do + expect(get("/gitlab/gitlabhq/merge_requests/new/diffs.json")).to route_to("projects/merge_requests/creations#diffs", namespace_id: "gitlab", project_id: "gitlabhq", format: "json") end end - describe Projects::MergeRequests::DiffsController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/merge_requests/1/diffs.json')).to route_to('projects/merge_requests/diffs#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1', format: 'json') + describe Projects::MergeRequests::DiffsController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/merge_requests/1/diffs.json")).to route_to("projects/merge_requests/diffs#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1", format: "json") end end - describe Projects::MergeRequests::ConflictsController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/merge_requests/1/conflicts')).to route_to('projects/merge_requests/conflicts#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') + describe Projects::MergeRequests::ConflictsController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/merge_requests/1/conflicts")).to route_to("projects/merge_requests/conflicts#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end end # raw_project_snippet GET /:project_id/snippets/:id/raw(.:format) snippets#raw @@ -348,37 +348,37 @@ describe 'project routing' do # project_snippet GET /:project_id/snippets/:id(.:format) snippets#show # PUT /:project_id/snippets/:id(.:format) snippets#update # DELETE /:project_id/snippets/:id(.:format) snippets#destroy - describe SnippetsController, 'routing' do - it 'to #raw' do - expect(get('/gitlab/gitlabhq/snippets/1/raw')).to route_to('projects/snippets#raw', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') + describe SnippetsController, "routing" do + it "to #raw" do + expect(get("/gitlab/gitlabhq/snippets/1/raw")).to route_to("projects/snippets#raw", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end - it 'to #index' do - expect(get('/gitlab/gitlabhq/snippets')).to route_to('projects/snippets#index', namespace_id: 'gitlab', project_id: 'gitlabhq') + it "to #index" do + expect(get("/gitlab/gitlabhq/snippets")).to route_to("projects/snippets#index", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #create' do - expect(post('/gitlab/gitlabhq/snippets')).to route_to('projects/snippets#create', namespace_id: 'gitlab', project_id: 'gitlabhq') + it "to #create" do + expect(post("/gitlab/gitlabhq/snippets")).to route_to("projects/snippets#create", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #new' do - expect(get('/gitlab/gitlabhq/snippets/new')).to route_to('projects/snippets#new', namespace_id: 'gitlab', project_id: 'gitlabhq') + it "to #new" do + expect(get("/gitlab/gitlabhq/snippets/new")).to route_to("projects/snippets#new", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #edit' do - expect(get('/gitlab/gitlabhq/snippets/1/edit')).to route_to('projects/snippets#edit', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') + it "to #edit" do + expect(get("/gitlab/gitlabhq/snippets/1/edit")).to route_to("projects/snippets#edit", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end - it 'to #show' do - expect(get('/gitlab/gitlabhq/snippets/1')).to route_to('projects/snippets#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') + it "to #show" do + expect(get("/gitlab/gitlabhq/snippets/1")).to route_to("projects/snippets#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end - it 'to #update' do - expect(put('/gitlab/gitlabhq/snippets/1')).to route_to('projects/snippets#update', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') + it "to #update" do + expect(put("/gitlab/gitlabhq/snippets/1")).to route_to("projects/snippets#update", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end - it 'to #destroy' do - expect(delete('/gitlab/gitlabhq/snippets/1')).to route_to('projects/snippets#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') + it "to #destroy" do + expect(delete("/gitlab/gitlabhq/snippets/1")).to route_to("projects/snippets#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end end @@ -388,36 +388,36 @@ describe 'project routing' do # edit_project_hook GET /:project_id/hooks/:id/edit(.:format) hooks#edit # project_hook PUT /:project_id/hooks/:id(.:format) hooks#update # DELETE /:project_id/hooks/:id(.:format) hooks#destroy - describe Projects::HooksController, 'routing' do - it 'to #test' do - expect(post('/gitlab/gitlabhq/hooks/1/test')).to route_to('projects/hooks#test', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '1') + describe Projects::HooksController, "routing" do + it "to #test" do + expect(post("/gitlab/gitlabhq/hooks/1/test")).to route_to("projects/hooks#test", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end - it_behaves_like 'RESTful project resources' do + it_behaves_like "RESTful project resources" do let(:actions) { [:index, :create, :destroy, :edit, :update] } - let(:controller) { 'hooks' } + let(:controller) { "hooks" } end end # retry_namespace_project_hook_hook_log POST /:project_id/hooks/:hook_id/hook_logs/:id/retry(.:format) projects/hook_logs#retry # namespace_project_hook_hook_log GET /:project_id/hooks/:hook_id/hook_logs/:id(.:format) projects/hook_logs#show - describe Projects::HookLogsController, 'routing' do - it 'to #retry' do - expect(post('/gitlab/gitlabhq/hooks/1/hook_logs/1/retry')).to route_to('projects/hook_logs#retry', namespace_id: 'gitlab', project_id: 'gitlabhq', hook_id: '1', id: '1') + describe Projects::HookLogsController, "routing" do + it "to #retry" do + expect(post("/gitlab/gitlabhq/hooks/1/hook_logs/1/retry")).to route_to("projects/hook_logs#retry", namespace_id: "gitlab", project_id: "gitlabhq", hook_id: "1", id: "1") end - it 'to #show' do - expect(get('/gitlab/gitlabhq/hooks/1/hook_logs/1')).to route_to('projects/hook_logs#show', namespace_id: 'gitlab', project_id: 'gitlabhq', hook_id: '1', id: '1') + it "to #show" do + expect(get("/gitlab/gitlabhq/hooks/1/hook_logs/1")).to route_to("projects/hook_logs#show", namespace_id: "gitlab", project_id: "gitlabhq", hook_id: "1", id: "1") end end # project_commit GET /:project_id/commit/:id(.:format) commit#show {id: /\h{7,40}/, project_id: /[^\/]+/} - describe Projects::CommitController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/commit/4246fbd')).to route_to('projects/commit#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '4246fbd') - expect(get('/gitlab/gitlabhq/commit/4246fbd.diff')).to route_to('projects/commit#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '4246fbd', format: 'diff') - expect(get('/gitlab/gitlabhq/commit/4246fbd.patch')).to route_to('projects/commit#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '4246fbd', format: 'patch') - expect(get('/gitlab/gitlabhq/commit/4246fbd13872934f72a8fd0d6fb1317b47b59cb5')).to route_to('projects/commit#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: '4246fbd13872934f72a8fd0d6fb1317b47b59cb5') + describe Projects::CommitController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/commit/4246fbd")).to route_to("projects/commit#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "4246fbd") + expect(get("/gitlab/gitlabhq/commit/4246fbd.diff")).to route_to("projects/commit#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "4246fbd", format: "diff") + expect(get("/gitlab/gitlabhq/commit/4246fbd.patch")).to route_to("projects/commit#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "4246fbd", format: "patch") + expect(get("/gitlab/gitlabhq/commit/4246fbd13872934f72a8fd0d6fb1317b47b59cb5")).to route_to("projects/commit#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "4246fbd13872934f72a8fd0d6fb1317b47b59cb5") end end @@ -425,14 +425,14 @@ describe 'project routing' do # project_commits GET /:project_id/commits(.:format) commits#index # POST /:project_id/commits(.:format) commits#create # project_commit GET /:project_id/commits/:id(.:format) commits#show - describe Projects::CommitsController, 'routing' do - it_behaves_like 'RESTful project resources' do + describe Projects::CommitsController, "routing" do + it_behaves_like "RESTful project resources" do let(:actions) { [:show] } - let(:controller) { 'commits' } + let(:controller) { "commits" } end - it 'to #show' do - expect(get('/gitlab/gitlabhq/commits/master.atom')).to route_to('projects/commits#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master.atom') + it "to #show" do + expect(get("/gitlab/gitlabhq/commits/master.atom")).to route_to("projects/commits#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master.atom") end end @@ -440,10 +440,10 @@ describe 'project routing' do # POST /:project_id/project_members(.:format) project_members#create # PUT /:project_id/project_members/:id(.:format) project_members#update # DELETE /:project_id/project_members/:id(.:format) project_members#destroy - describe Projects::ProjectMembersController, 'routing' do - it_behaves_like 'RESTful project resources' do + describe Projects::ProjectMembersController, "routing" do + it_behaves_like "RESTful project resources" do let(:actions) { [:index, :create, :update, :destroy] } - let(:controller) { 'project_members' } + let(:controller) { "project_members" } end end @@ -455,21 +455,21 @@ describe 'project routing' do # PUT /:project_id/milestones/:id(.:format) milestones#update # DELETE /:project_id/milestones/:id(.:format) milestones#destroy # promote_project_milestone POST /:project_id/milestones/:id/promote milestones#promote - describe Projects::MilestonesController, 'routing' do - it_behaves_like 'RESTful project resources' do - let(:controller) { 'milestones' } + describe Projects::MilestonesController, "routing" do + it_behaves_like "RESTful project resources" do + let(:controller) { "milestones" } let(:actions) { [:index, :create, :new, :edit, :show, :update] } end - it 'to #promote' do - expect(post('/gitlab/gitlabhq/milestones/1/promote')).to route_to('projects/milestones#promote', namespace_id: 'gitlab', project_id: 'gitlabhq', id: "1") + it "to #promote" do + expect(post("/gitlab/gitlabhq/milestones/1/promote")).to route_to("projects/milestones#promote", namespace_id: "gitlab", project_id: "gitlabhq", id: "1") end end # project_labels GET /:project_id/labels(.:format) labels#index - describe Projects::LabelsController, 'routing' do - it 'to #index' do - expect(get('/gitlab/gitlabhq/labels')).to route_to('projects/labels#index', namespace_id: 'gitlab', project_id: 'gitlabhq') + describe Projects::LabelsController, "routing" do + it "to #index" do + expect(get("/gitlab/gitlabhq/labels")).to route_to("projects/labels#index", namespace_id: "gitlab", project_id: "gitlabhq") end end @@ -483,13 +483,13 @@ describe 'project routing' do # project_issue GET /:project_id/issues/:id(.:format) issues#show # PUT /:project_id/issues/:id(.:format) issues#update # DELETE /:project_id/issues/:id(.:format) issues#destroy - describe Projects::IssuesController, 'routing' do - it 'to #bulk_update' do - expect(post('/gitlab/gitlabhq/issues/bulk_update')).to route_to('projects/issues#bulk_update', namespace_id: 'gitlab', project_id: 'gitlabhq') + describe Projects::IssuesController, "routing" do + it "to #bulk_update" do + expect(post("/gitlab/gitlabhq/issues/bulk_update")).to route_to("projects/issues#bulk_update", namespace_id: "gitlab", project_id: "gitlabhq") end - it_behaves_like 'RESTful project resources' do - let(:controller) { 'issues' } + it_behaves_like "RESTful project resources" do + let(:controller) { "issues" } let(:actions) { [:index, :create, :new, :edit, :show, :update] } end end @@ -497,167 +497,170 @@ describe 'project routing' do # project_noteable_notes GET /:project_id/noteable/:target_type/:target_id/notes notes#index # POST /:project_id/notes(.:format) notes#create # project_note DELETE /:project_id/notes/:id(.:format) notes#destroy - describe Projects::NotesController, 'routing' do - it 'to #index' do - expect(get('/gitlab/gitlabhq/noteable/issue/1/notes')).to route_to( - 'projects/notes#index', - namespace_id: 'gitlab', - project_id: 'gitlabhq', - target_type: 'issue', - target_id: '1' + describe Projects::NotesController, "routing" do + it "to #index" do + expect(get("/gitlab/gitlabhq/noteable/issue/1/notes")).to route_to( + "projects/notes#index", + namespace_id: "gitlab", + project_id: "gitlabhq", + target_type: "issue", + target_id: "1" ) end - it_behaves_like 'RESTful project resources' do + it_behaves_like "RESTful project resources" do let(:actions) { [:create, :destroy] } - let(:controller) { 'notes' } + let(:controller) { "notes" } end end # project_blame GET /:project_id/blame/:id(.:format) blame#show {id: /.+/, project_id: /[^\/]+/} - describe Projects::BlameController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/blame/master/app/models/project.rb')).to route_to('projects/blame#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/app/models/project.rb') - expect(get('/gitlab/gitlabhq/blame/master/files.scss')).to route_to('projects/blame#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/files.scss') + describe Projects::BlameController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/blame/master/app/models/project.rb")).to route_to("projects/blame#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/app/models/project.rb") + expect(get("/gitlab/gitlabhq/blame/master/files.scss")).to route_to("projects/blame#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/files.scss") end end # project_blob GET /:project_id/blob/:id(.:format) blob#show {id: /.+/, project_id: /[^\/]+/} - describe Projects::BlobController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/blob/master/app/models/project.rb')).to route_to('projects/blob#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/app/models/project.rb') - expect(get('/gitlab/gitlabhq/blob/master/app/models/compare.rb')).to route_to('projects/blob#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/app/models/compare.rb') - expect(get('/gitlab/gitlabhq/blob/master/app/models/diff.js')).to route_to('projects/blob#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/app/models/diff.js') - expect(get('/gitlab/gitlabhq/blob/master/files.scss')).to route_to('projects/blob#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/files.scss') - expect(get('/gitlab/gitlabhq/blob/master/blob/index.js')).to route_to('projects/blob#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/blob/index.js') - expect(get('/gitlab/gitlabhq/blob/blob/master/blob/index.js')).to route_to('projects/blob#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'blob/master/blob/index.js') + describe Projects::BlobController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/blob/master/app/models/project.rb")).to route_to("projects/blob#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/app/models/project.rb") + expect(get("/gitlab/gitlabhq/blob/master/app/models/compare.rb")).to route_to("projects/blob#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/app/models/compare.rb") + expect(get("/gitlab/gitlabhq/blob/master/app/models/diff.js")).to route_to("projects/blob#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/app/models/diff.js") + expect(get("/gitlab/gitlabhq/blob/master/files.scss")).to route_to("projects/blob#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/files.scss") + expect(get("/gitlab/gitlabhq/blob/master/blob/index.js")).to route_to("projects/blob#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/blob/index.js") + expect(get("/gitlab/gitlabhq/blob/blob/master/blob/index.js")).to route_to("projects/blob#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "blob/master/blob/index.js") end end # project_tree GET /:project_id/tree/:id(.:format) tree#show {id: /.+/, project_id: /[^\/]+/} - describe Projects::TreeController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/tree/master/app/models/project.rb')).to route_to('projects/tree#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/app/models/project.rb') - expect(get('/gitlab/gitlabhq/tree/master/files.scss')).to route_to('projects/tree#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/files.scss') - expect(get('/gitlab/gitlabhq/tree/master/tree/files')).to route_to('projects/tree#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master/tree/files') - expect(get('/gitlab/gitlabhq/tree/tree/master/tree/files')).to route_to('projects/tree#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'tree/master/tree/files') + describe Projects::TreeController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/tree/master/app/models/project.rb")).to route_to("projects/tree#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/app/models/project.rb") + expect(get("/gitlab/gitlabhq/tree/master/files.scss")).to route_to("projects/tree#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/files.scss") + expect(get("/gitlab/gitlabhq/tree/master/tree/files")).to route_to("projects/tree#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master/tree/files") + expect(get("/gitlab/gitlabhq/tree/tree/master/tree/files")).to route_to("projects/tree#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "tree/master/tree/files") end end # project_find_file GET /:namespace_id/:project_id/find_file/*id(.:format) projects/find_file#show {:id=>/.+/, :namespace_id=>/[a-zA-Z.0-9_\-]+/, :project_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :format=>/html/} # project_files GET /:namespace_id/:project_id/files/*id(.:format) projects/find_file#list {:id=>/(?:[^.]|\.(?!json$))+/, :namespace_id=>/[a-zA-Z.0-9_\-]+/, :project_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :format=>/json/} - describe Projects::FindFileController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/find_file/master')).to route_to('projects/find_file#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master') + describe Projects::FindFileController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/find_file/master")).to route_to("projects/find_file#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master") end - it 'to #list' do - expect(get('/gitlab/gitlabhq/files/master.json')).to route_to('projects/find_file#list', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master.json') + it "to #list" do + expect(get("/gitlab/gitlabhq/files/master.json")).to route_to("projects/find_file#list", namespace_id: "gitlab", project_id: "gitlabhq", id: "master.json") end end - describe Projects::BlobController, 'routing' do - it 'to #edit' do - expect(get('/gitlab/gitlabhq/edit/master/app/models/project.rb')).to( - route_to('projects/blob#edit', - namespace_id: 'gitlab', project_id: 'gitlabhq', - id: 'master/app/models/project.rb')) + describe Projects::BlobController, "routing" do + it "to #edit" do + expect(get("/gitlab/gitlabhq/edit/master/app/models/project.rb")).to( + route_to("projects/blob#edit", + namespace_id: "gitlab", project_id: "gitlabhq", + id: "master/app/models/project.rb") + ) end - it 'to #preview' do - expect(post('/gitlab/gitlabhq/preview/master/app/models/project.rb')).to( - route_to('projects/blob#preview', - namespace_id: 'gitlab', project_id: 'gitlabhq', - id: 'master/app/models/project.rb')) + it "to #preview" do + expect(post("/gitlab/gitlabhq/preview/master/app/models/project.rb")).to( + route_to("projects/blob#preview", + namespace_id: "gitlab", project_id: "gitlabhq", + id: "master/app/models/project.rb") + ) end end # project_compare_index GET /:project_id/compare(.:format) compare#index {id: /[^\/]+/, project_id: /[^\/]+/} # POST /:project_id/compare(.:format) compare#create {id: /[^\/]+/, project_id: /[^\/]+/} # project_compare /:project_id/compare/:from...:to(.:format) compare#show {from: /.+/, to: /.+/, id: /[^\/]+/, project_id: /[^\/]+/} - describe Projects::CompareController, 'routing' do - it 'to #index' do - expect(get('/gitlab/gitlabhq/compare')).to route_to('projects/compare#index', namespace_id: 'gitlab', project_id: 'gitlabhq') + describe Projects::CompareController, "routing" do + it "to #index" do + expect(get("/gitlab/gitlabhq/compare")).to route_to("projects/compare#index", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #compare' do - expect(post('/gitlab/gitlabhq/compare')).to route_to('projects/compare#create', namespace_id: 'gitlab', project_id: 'gitlabhq') + it "to #compare" do + expect(post("/gitlab/gitlabhq/compare")).to route_to("projects/compare#create", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #show' do - expect(get('/gitlab/gitlabhq/compare/master...stable')).to route_to('projects/compare#show', namespace_id: 'gitlab', project_id: 'gitlabhq', from: 'master', to: 'stable') - expect(get('/gitlab/gitlabhq/compare/issue/1234...stable')).to route_to('projects/compare#show', namespace_id: 'gitlab', project_id: 'gitlabhq', from: 'issue/1234', to: 'stable') + it "to #show" do + expect(get("/gitlab/gitlabhq/compare/master...stable")).to route_to("projects/compare#show", namespace_id: "gitlab", project_id: "gitlabhq", from: "master", to: "stable") + expect(get("/gitlab/gitlabhq/compare/issue/1234...stable")).to route_to("projects/compare#show", namespace_id: "gitlab", project_id: "gitlabhq", from: "issue/1234", to: "stable") end end - describe Projects::NetworkController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/network/master')).to route_to('projects/network#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master') - expect(get('/gitlab/gitlabhq/network/ends-with.json')).to route_to('projects/network#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'ends-with.json') - expect(get('/gitlab/gitlabhq/network/master?format=json')).to route_to('projects/network#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master', format: 'json') + describe Projects::NetworkController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/network/master")).to route_to("projects/network#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master") + expect(get("/gitlab/gitlabhq/network/ends-with.json")).to route_to("projects/network#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "ends-with.json") + expect(get("/gitlab/gitlabhq/network/master?format=json")).to route_to("projects/network#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master", format: "json") end end - describe Projects::GraphsController, 'routing' do - it 'to #show' do - expect(get('/gitlab/gitlabhq/graphs/master')).to route_to('projects/graphs#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master') - expect(get('/gitlab/gitlabhq/graphs/ends-with.json')).to route_to('projects/graphs#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'ends-with.json') - expect(get('/gitlab/gitlabhq/graphs/master?format=json')).to route_to('projects/graphs#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'master', format: 'json') + describe Projects::GraphsController, "routing" do + it "to #show" do + expect(get("/gitlab/gitlabhq/graphs/master")).to route_to("projects/graphs#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master") + expect(get("/gitlab/gitlabhq/graphs/ends-with.json")).to route_to("projects/graphs#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "ends-with.json") + expect(get("/gitlab/gitlabhq/graphs/master?format=json")).to route_to("projects/graphs#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "master", format: "json") end end - describe Projects::ForksController, 'routing' do - it 'to #new' do - expect(get('/gitlab/gitlabhq/forks/new')).to route_to('projects/forks#new', namespace_id: 'gitlab', project_id: 'gitlabhq') + describe Projects::ForksController, "routing" do + it "to #new" do + expect(get("/gitlab/gitlabhq/forks/new")).to route_to("projects/forks#new", namespace_id: "gitlab", project_id: "gitlabhq") end - it 'to #create' do - expect(post('/gitlab/gitlabhq/forks')).to route_to('projects/forks#create', namespace_id: 'gitlab', project_id: 'gitlabhq') + it "to #create" do + expect(post("/gitlab/gitlabhq/forks")).to route_to("projects/forks#create", namespace_id: "gitlab", project_id: "gitlabhq") end end # project_avatar DELETE /project/avatar(.:format) projects/avatars#destroy - describe Projects::AvatarsController, 'routing' do - it 'to #destroy' do - expect(delete('/gitlab/gitlabhq/avatar')).to route_to( - 'projects/avatars#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq') + describe Projects::AvatarsController, "routing" do + it "to #destroy" do + expect(delete("/gitlab/gitlabhq/avatar")).to route_to( + "projects/avatars#destroy", namespace_id: "gitlab", project_id: "gitlabhq" + ) end end - describe Projects::PagesDomainsController, 'routing' do - it_behaves_like 'RESTful project resources' do + describe Projects::PagesDomainsController, "routing" do + it_behaves_like "RESTful project resources" do let(:actions) { [:show, :new, :create, :destroy] } - let(:controller) { 'pages_domains' } - let(:controller_path) { 'pages/domains' } + let(:controller) { "pages_domains" } + let(:controller_path) { "pages/domains" } end - it 'to #destroy with a valid domain name' do - expect(delete('/gitlab/gitlabhq/pages/domains/my.domain.com')).to route_to('projects/pages_domains#destroy', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'my.domain.com') + it "to #destroy with a valid domain name" do + expect(delete("/gitlab/gitlabhq/pages/domains/my.domain.com")).to route_to("projects/pages_domains#destroy", namespace_id: "gitlab", project_id: "gitlabhq", id: "my.domain.com") end - it 'to #show with a valid domain' do - expect(get('/gitlab/gitlabhq/pages/domains/my.domain.com')).to route_to('projects/pages_domains#show', namespace_id: 'gitlab', project_id: 'gitlabhq', id: 'my.domain.com') + it "to #show with a valid domain" do + expect(get("/gitlab/gitlabhq/pages/domains/my.domain.com")).to route_to("projects/pages_domains#show", namespace_id: "gitlab", project_id: "gitlabhq", id: "my.domain.com") end end - describe Projects::Registry::TagsController, 'routing' do - describe '#destroy' do - it 'correctly routes to a destroy action' do - expect(delete('/gitlab/gitlabhq/registry/repository/1/tags/rc1')) - .to route_to('projects/registry/tags#destroy', - namespace_id: 'gitlab', - project_id: 'gitlabhq', - repository_id: '1', - id: 'rc1') + describe Projects::Registry::TagsController, "routing" do + describe "#destroy" do + it "correctly routes to a destroy action" do + expect(delete("/gitlab/gitlabhq/registry/repository/1/tags/rc1")) + .to route_to("projects/registry/tags#destroy", + namespace_id: "gitlab", + project_id: "gitlabhq", + repository_id: "1", + id: "rc1") end - it 'takes registry tag name constrains into account' do - expect(delete('/gitlab/gitlabhq/registry/repository/1/tags/-rc1')) - .not_to route_to('projects/registry/tags#destroy', - namespace_id: 'gitlab', - project_id: 'gitlabhq', - repository_id: '1', - id: '-rc1') + it "takes registry tag name constrains into account" do + expect(delete("/gitlab/gitlabhq/registry/repository/1/tags/-rc1")) + .not_to route_to("projects/registry/tags#destroy", + namespace_id: "gitlab", + project_id: "gitlabhq", + repository_id: "1", + id: "-rc1") end end end diff --git a/spec/routing/routing_spec.rb b/spec/routing/routing_spec.rb index a170bb14144..2e427eac600 100644 --- a/spec/routing/routing_spec.rb +++ b/spec/routing/routing_spec.rb @@ -1,4 +1,4 @@ -require 'spec_helper' +require "spec_helper" # user GET /u/:username/ # user_groups GET /u/:username/groups(.:format) @@ -11,46 +11,46 @@ describe UsersController, "routing" do it "to #show" do allow_any_instance_of(::Constraints::UserUrlConstrainer).to receive(:matches?).and_return(true) - expect(get("/User")).to route_to('users#show', username: 'User') + expect(get("/User")).to route_to("users#show", username: "User") end it "to #groups" do - expect(get("/users/User/groups")).to route_to('users#groups', username: 'User') + expect(get("/users/User/groups")).to route_to("users#groups", username: "User") end it "to #projects" do - expect(get("/users/User/projects")).to route_to('users#projects', username: 'User') + expect(get("/users/User/projects")).to route_to("users#projects", username: "User") end it "to #contributed" do - expect(get("/users/User/contributed")).to route_to('users#contributed', username: 'User') + expect(get("/users/User/contributed")).to route_to("users#contributed", username: "User") end it "to #snippets" do - expect(get("/users/User/snippets")).to route_to('users#snippets', username: 'User') + expect(get("/users/User/snippets")).to route_to("users#snippets", username: "User") end it "to #calendar" do - expect(get("/users/User/calendar")).to route_to('users#calendar', username: 'User') + expect(get("/users/User/calendar")).to route_to("users#calendar", username: "User") end it "to #calendar_activities" do - expect(get("/users/User/calendar_activities")).to route_to('users#calendar_activities', username: 'User') + expect(get("/users/User/calendar_activities")).to route_to("users#calendar_activities", username: "User") end - describe 'redirect alias routes' do + describe "redirect alias routes" do include RSpec::Rails::RequestExampleGroup - it '/u/user1 redirects to /user1' do - expect(get("/u/user1")).to redirect_to('/user1') + it "/u/user1 redirects to /user1" do + expect(get("/u/user1")).to redirect_to("/user1") end - it '/u/user1/groups redirects to /user1/groups' do - expect(get("/u/user1/groups")).to redirect_to('/users/user1/groups') + it "/u/user1/groups redirects to /user1/groups" do + expect(get("/u/user1/groups")).to redirect_to("/users/user1/groups") end - it '/u/user1/projects redirects to /user1/projects' do - expect(get("/u/user1/projects")).to redirect_to('/users/user1/projects') + it "/u/user1/projects redirects to /user1/projects" do + expect(get("/u/user1/projects")).to redirect_to("/users/user1/projects") end end end @@ -58,7 +58,7 @@ end # search GET /search(.:format) search#show describe SearchController, "routing" do it "to #show" do - expect(get("/search")).to route_to('search#show') + expect(get("/search")).to route_to("search#show") end end @@ -83,35 +83,35 @@ end # DELETE /snippets/:id(.:format) snippets#destroy describe SnippetsController, "routing" do it "to #raw" do - expect(get("/snippets/1/raw")).to route_to('snippets#raw', id: '1') + expect(get("/snippets/1/raw")).to route_to("snippets#raw", id: "1") end it "to #index" do - expect(get("/snippets")).to route_to('snippets#index') + expect(get("/snippets")).to route_to("snippets#index") end it "to #create" do - expect(post("/snippets")).to route_to('snippets#create') + expect(post("/snippets")).to route_to("snippets#create") end it "to #new" do - expect(get("/snippets/new")).to route_to('snippets#new') + expect(get("/snippets/new")).to route_to("snippets#new") end it "to #edit" do - expect(get("/snippets/1/edit")).to route_to('snippets#edit', id: '1') + expect(get("/snippets/1/edit")).to route_to("snippets#edit", id: "1") end it "to #show" do - expect(get("/snippets/1")).to route_to('snippets#show', id: '1') + expect(get("/snippets/1")).to route_to("snippets#show", id: "1") end it "to #update" do - expect(put("/snippets/1")).to route_to('snippets#update', id: '1') + expect(put("/snippets/1")).to route_to("snippets#update", id: "1") end it "to #destroy" do - expect(delete("/snippets/1")).to route_to('snippets#destroy', id: '1') + expect(delete("/snippets/1")).to route_to("snippets#destroy", id: "1") end end @@ -121,22 +121,22 @@ end # help_ui GET /help/ui(.:format) help#ui describe HelpController, "routing" do it "to #index" do - expect(get("/help")).to route_to('help#index') + expect(get("/help")).to route_to("help#index") end - it 'to #show' do - path = '/help/user/markdown.md' - expect(get(path)).to route_to('help#show', - path: 'user/markdown', - format: 'md') + it "to #show" do + path = "/help/user/markdown.md" + expect(get(path)).to route_to("help#show", + path: "user/markdown", + format: "md") - path = '/help/workflow/protected_branches/protected_branches1.png' - expect(get(path)).to route_to('help#show', - path: 'workflow/protected_branches/protected_branches1', - format: 'png') + path = "/help/workflow/protected_branches/protected_branches1.png" + expect(get(path)).to route_to("help#show", + path: "workflow/protected_branches/protected_branches1", + format: "png") - path = '/help/ui' - expect(get(path)).to route_to('help#ui') + path = "/help/ui" + expect(get(path)).to route_to("help#ui") end end @@ -148,33 +148,33 @@ end # profile_update PUT /profile/update(.:format) profile#update describe ProfilesController, "routing" do it "to #account" do - expect(get("/profile/account")).to route_to('profiles/accounts#show') + expect(get("/profile/account")).to route_to("profiles/accounts#show") end it "to #audit_log" do - expect(get("/profile/audit_log")).to route_to('profiles#audit_log') + expect(get("/profile/audit_log")).to route_to("profiles#audit_log") end it "to #reset_feed_token" do - expect(put("/profile/reset_feed_token")).to route_to('profiles#reset_feed_token') + expect(put("/profile/reset_feed_token")).to route_to("profiles#reset_feed_token") end it "to #show" do - expect(get("/profile")).to route_to('profiles#show') + expect(get("/profile")).to route_to("profiles#show") end end # profile_preferences GET /profile/preferences(.:format) profiles/preferences#show # PATCH /profile/preferences(.:format) profiles/preferences#update # PUT /profile/preferences(.:format) profiles/preferences#update -describe Profiles::PreferencesController, 'routing' do - it 'to #show' do - expect(get('/profile/preferences')).to route_to('profiles/preferences#show') +describe Profiles::PreferencesController, "routing" do + it "to #show" do + expect(get("/profile/preferences")).to route_to("profiles/preferences#show") end - it 'to #update' do - expect(put('/profile/preferences')).to route_to('profiles/preferences#update') - expect(patch('/profile/preferences')).to route_to('profiles/preferences#update') + it "to #update" do + expect(put("/profile/preferences")).to route_to("profiles/preferences#update") + expect(patch("/profile/preferences")).to route_to("profiles/preferences#update") end end @@ -186,26 +186,26 @@ end # DELETE /keys/:id(.:format) keys#destroy describe Profiles::KeysController, "routing" do it "to #index" do - expect(get("/profile/keys")).to route_to('profiles/keys#index') + expect(get("/profile/keys")).to route_to("profiles/keys#index") end it "to #create" do - expect(post("/profile/keys")).to route_to('profiles/keys#create') + expect(post("/profile/keys")).to route_to("profiles/keys#create") end it "to #show" do - expect(get("/profile/keys/1")).to route_to('profiles/keys#show', id: '1') + expect(get("/profile/keys/1")).to route_to("profiles/keys#show", id: "1") end it "to #destroy" do - expect(delete("/profile/keys/1")).to route_to('profiles/keys#destroy', id: '1') + expect(delete("/profile/keys/1")).to route_to("profiles/keys#destroy", id: "1") end # get all the ssh-keys of a user it "to #get_keys" do allow_any_instance_of(::Constraints::UserUrlConstrainer).to receive(:matches?).and_return(true) - expect(get("/foo.keys")).to route_to('profiles/keys#get_keys', username: 'foo') + expect(get("/foo.keys")).to route_to("profiles/keys#get_keys", username: "foo") end end @@ -214,22 +214,22 @@ end # DELETE /keys/:id(.:format) keys#destroy describe Profiles::EmailsController, "routing" do it "to #index" do - expect(get("/profile/emails")).to route_to('profiles/emails#index') + expect(get("/profile/emails")).to route_to("profiles/emails#index") end it "to #create" do - expect(post("/profile/emails")).to route_to('profiles/emails#create') + expect(post("/profile/emails")).to route_to("profiles/emails#create") end it "to #destroy" do - expect(delete("/profile/emails/1")).to route_to('profiles/emails#destroy', id: '1') + expect(delete("/profile/emails/1")).to route_to("profiles/emails#destroy", id: "1") end end # profile_avatar DELETE /profile/avatar(.:format) profiles/avatars#destroy describe Profiles::AvatarsController, "routing" do it "to #destroy" do - expect(delete("/profile/avatar")).to route_to('profiles/avatars#destroy') + expect(delete("/profile/avatar")).to route_to("profiles/avatars#destroy") end end @@ -238,67 +238,67 @@ end # dashboard_merge_requests GET /dashboard/merge_requests(.:format) dashboard#merge_requests describe DashboardController, "routing" do it "to #index" do - expect(get("/dashboard")).to route_to('dashboard/projects#index') + expect(get("/dashboard")).to route_to("dashboard/projects#index") end it "to #issues" do - expect(get("/dashboard/issues.html")).to route_to('dashboard#issues', format: 'html') + expect(get("/dashboard/issues.html")).to route_to("dashboard#issues", format: "html") end it "to #calendar_issues" do - expect(get("/dashboard/issues.ics")).to route_to('dashboard#issues_calendar', format: 'ics') + expect(get("/dashboard/issues.ics")).to route_to("dashboard#issues_calendar", format: "ics") end it "to #merge_requests" do - expect(get("/dashboard/merge_requests")).to route_to('dashboard#merge_requests') + expect(get("/dashboard/merge_requests")).to route_to("dashboard#merge_requests") end end # root / root#show -describe RootController, 'routing' do - it 'to #index' do - expect(get('/')).to route_to('root#index') +describe RootController, "routing" do + it "to #index" do + expect(get("/")).to route_to("root#index") end end describe "Authentication", "routing" do it "GET /users/sign_in" do - expect(get("/users/sign_in")).to route_to('sessions#new') + expect(get("/users/sign_in")).to route_to("sessions#new") end it "POST /users/sign_in" do - expect(post("/users/sign_in")).to route_to('sessions#create') + expect(post("/users/sign_in")).to route_to("sessions#create") end # sign_out with GET instead of DELETE facilitates ad-hoc single-sign-out processes # (https://gitlab.com/gitlab-org/gitlab-ce/issues/39708) it "GET /users/sign_out" do - expect(get("/users/sign_out")).to route_to('sessions#destroy') + expect(get("/users/sign_out")).to route_to("sessions#destroy") end it "POST /users/password" do - expect(post("/users/password")).to route_to('passwords#create') + expect(post("/users/password")).to route_to("passwords#create") end it "GET /users/password/new" do - expect(get("/users/password/new")).to route_to('passwords#new') + expect(get("/users/password/new")).to route_to("passwords#new") end it "GET /users/password/edit" do - expect(get("/users/password/edit")).to route_to('passwords#edit') + expect(get("/users/password/edit")).to route_to("passwords#edit") end it "PUT /users/password" do - expect(put("/users/password")).to route_to('passwords#update') + expect(put("/users/password")).to route_to("passwords#update") end end -describe HealthCheckController, 'routing' do - it 'to #index' do - expect(get('/health_check')).to route_to('health_check#index') +describe HealthCheckController, "routing" do + it "to #index" do + expect(get("/health_check")).to route_to("health_check#index") end - it 'also supports passing checks in the url' do - expect(get('/health_check/email')).to route_to('health_check#index', checks: 'email') + it "also supports passing checks in the url" do + expect(get("/health_check/email")).to route_to("health_check#index", checks: "email") end end |