diff options
Diffstat (limited to 'spec/requests/api/namespaces_spec.rb')
-rw-r--r-- | spec/requests/api/namespaces_spec.rb | 104 |
1 files changed, 52 insertions, 52 deletions
diff --git a/spec/requests/api/namespaces_spec.rb b/spec/requests/api/namespaces_spec.rb index 2e376109b42..64a47f51a92 100644 --- a/spec/requests/api/namespaces_spec.rb +++ b/spec/requests/api/namespaces_spec.rb @@ -1,9 +1,9 @@ -require 'spec_helper' +require "spec_helper" describe API::Namespaces do let(:admin) { create(:admin) } let(:user) { create(:user) } - let!(:group1) { create(:group, name: 'group.one') } + let!(:group1) { create(:group, name: "group.one") } let!(:group2) { create(:group, :nested) } describe "GET /namespaces" do @@ -18,15 +18,15 @@ describe API::Namespaces do it "returns correct attributes" do get api("/namespaces", admin) - group_kind_json_response = json_response.find { |resource| resource['kind'] == 'group' } - user_kind_json_response = json_response.find { |resource| resource['kind'] == 'user' } + group_kind_json_response = json_response.find { |resource| resource["kind"] == "group" } + user_kind_json_response = json_response.find { |resource| resource["kind"] == "user" } expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers - expect(group_kind_json_response.keys).to include('id', 'kind', 'name', 'path', 'full_path', - 'parent_id', 'members_count_with_descendants') + expect(group_kind_json_response.keys).to include("id", "kind", "name", "path", "full_path", + "parent_id", "members_count_with_descendants") - expect(user_kind_json_response.keys).to include('id', 'kind', 'name', 'path', 'full_path', 'parent_id') + expect(user_kind_json_response.keys).to include("id", "kind", "name", "path", "full_path", "parent_id") end it "admin: returns an array of all namespaces" do @@ -45,8 +45,8 @@ describe API::Namespaces do expect(response).to include_pagination_headers expect(json_response).to be_an Array expect(json_response.length).to eq(1) - expect(json_response.last['path']).to eq(group2.path) - expect(json_response.last['full_path']).to eq(group2.full_path) + expect(json_response.last["path"]).to eq(group2.path) + expect(json_response.last["full_path"]).to eq(group2.full_path) end end @@ -56,10 +56,10 @@ describe API::Namespaces do get api("/namespaces", user) - owned_group_response = json_response.find { |resource| resource['id'] == group1.id } + owned_group_response = json_response.find { |resource| resource["id"] == group1.id } - expect(owned_group_response.keys).to include('id', 'kind', 'name', 'path', 'full_path', - 'parent_id', 'members_count_with_descendants') + expect(owned_group_response.keys).to include("id", "kind", "name", "path", "full_path", + "parent_id", "members_count_with_descendants") end it "returns correct attributes when user cannot admin group" do @@ -67,9 +67,9 @@ describe API::Namespaces do get api("/namespaces", user) - guest_group_response = json_response.find { |resource| resource['id'] == group1.id } + guest_group_response = json_response.find { |resource| resource["id"] == group1.id } - expect(guest_group_response.keys).to include('id', 'kind', 'name', 'path', 'full_path', 'parent_id') + expect(guest_group_response.keys).to include("id", "kind", "name", "path", "full_path", "parent_id") end it "user: returns an array of namespaces" do @@ -92,92 +92,92 @@ describe API::Namespaces do end end - describe 'GET /namespaces/:id' do + describe "GET /namespaces/:id" do let(:owned_group) { group1 } let(:user2) { create(:user) } - shared_examples 'can access namespace' do - it 'returns namespace details' do + shared_examples "can access namespace" do + it "returns namespace details" do get api("/namespaces/#{namespace_id}", request_actor) expect(response).to have_gitlab_http_status(200) - expect(json_response['id']).to eq(requested_namespace.id) - expect(json_response['path']).to eq(requested_namespace.path) - expect(json_response['name']).to eq(requested_namespace.name) + expect(json_response["id"]).to eq(requested_namespace.id) + expect(json_response["path"]).to eq(requested_namespace.path) + expect(json_response["name"]).to eq(requested_namespace.name) end end - shared_examples 'namespace reader' do + shared_examples "namespace reader" do let(:requested_namespace) { owned_group } before do owned_group.add_owner(request_actor) end - context 'when namespace exists' do - context 'when requested by ID' do - context 'when requesting group' do + context "when namespace exists" do + context "when requested by ID" do + context "when requesting group" do let(:namespace_id) { owned_group.id } - it_behaves_like 'can access namespace' + it_behaves_like "can access namespace" end - context 'when requesting personal namespace' do + context "when requesting personal namespace" do let(:namespace_id) { request_actor.namespace.id } let(:requested_namespace) { request_actor.namespace } - it_behaves_like 'can access namespace' + it_behaves_like "can access namespace" end end - context 'when requested by path' do - context 'when requesting group' do + context "when requested by path" do + context "when requesting group" do let(:namespace_id) { owned_group.path } - it_behaves_like 'can access namespace' + it_behaves_like "can access namespace" end - context 'when requesting personal namespace' do + context "when requesting personal namespace" do let(:namespace_id) { request_actor.namespace.path } let(:requested_namespace) { request_actor.namespace } - it_behaves_like 'can access namespace' + it_behaves_like "can access namespace" end end end context "when namespace doesn't exist" do - it 'returns not-found' do - get api('/namespaces/0', request_actor) + it "returns not-found" do + get api("/namespaces/0", request_actor) expect(response).to have_gitlab_http_status(404) end end end - context 'when unauthenticated' do - it 'returns authentication error' do + context "when unauthenticated" do + it "returns authentication error" do get api("/namespaces/#{group1.id}") expect(response).to have_gitlab_http_status(401) end end - context 'when authenticated as regular user' do + context "when authenticated as regular user" do let(:request_actor) { user } - context 'when requested namespace is not owned by user' do - context 'when requesting group' do - it 'returns not-found' do + context "when requested namespace is not owned by user" do + context "when requesting group" do + it "returns not-found" do get api("/namespaces/#{group2.id}", request_actor) expect(response).to have_gitlab_http_status(404) end end - context 'when requesting personal namespace' do - it 'returns not-found' do + context "when requesting personal namespace" do + it "returns not-found" do get api("/namespaces/#{user2.namespace.id}", request_actor) expect(response).to have_gitlab_http_status(404) @@ -185,32 +185,32 @@ describe API::Namespaces do end end - context 'when requested namespace is owned by user' do - it_behaves_like 'namespace reader' + context "when requested namespace is owned by user" do + it_behaves_like "namespace reader" end end - context 'when authenticated as admin' do + context "when authenticated as admin" do let(:request_actor) { admin } - context 'when requested namespace is not owned by user' do - context 'when requesting group' do + context "when requested namespace is not owned by user" do + context "when requesting group" do let(:namespace_id) { group2.id } let(:requested_namespace) { group2 } - it_behaves_like 'can access namespace' + it_behaves_like "can access namespace" end - context 'when requesting personal namespace' do + context "when requesting personal namespace" do let(:namespace_id) { user2.namespace.id } let(:requested_namespace) { user2.namespace } - it_behaves_like 'can access namespace' + it_behaves_like "can access namespace" end end - context 'when requested namespace is owned by user' do - it_behaves_like 'namespace reader' + context "when requested namespace is owned by user" do + it_behaves_like "namespace reader" end end end |