diff options
Diffstat (limited to 'spec/requests/api/groups_spec.rb')
| -rw-r--r-- | spec/requests/api/groups_spec.rb | 376 |
1 files changed, 188 insertions, 188 deletions
diff --git a/spec/requests/api/groups_spec.rb b/spec/requests/api/groups_spec.rb index 7176bc23e34..aa2aa59688b 100644 --- a/spec/requests/api/groups_spec.rb +++ b/spec/requests/api/groups_spec.rb @@ -1,4 +1,4 @@ -require 'spec_helper' +require "spec_helper" describe API::Groups do include UploadHelpers @@ -11,7 +11,7 @@ describe API::Groups do let!(:group2) { create(:group, :private) } let!(:project1) { create(:project, namespace: group1) } let!(:project2) { create(:project, namespace: group2) } - let!(:project3) { create(:project, namespace: group1, path: 'test', visibility_level: Gitlab::VisibilityLevel::PRIVATE) } + let!(:project3) { create(:project, namespace: group1, path: "test", visibility_level: Gitlab::VisibilityLevel::PRIVATE) } before do group1.add_owner(user1) @@ -28,22 +28,22 @@ describe API::Groups do expect(json_response).to be_an Array expect(json_response.length).to eq(1) expect(json_response) - .to satisfy_one { |group| group['name'] == group1.name } + .to satisfy_one { |group| group["name"] == group1.name } end - it 'avoids N+1 queries' do + it "avoids N+1 queries" do # Establish baseline get api("/groups", admin) - control = ActiveRecord::QueryRecorder.new do + control = ActiveRecord::QueryRecorder.new { get api("/groups", admin) - end + } create(:group) - expect do + expect { get api("/groups", admin) - end.not_to exceed_query_limit(control) + }.not_to exceed_query_limit(control) end end @@ -56,16 +56,16 @@ describe API::Groups do expect(json_response).to be_an Array expect(json_response.length).to eq(1) expect(json_response) - .to satisfy_one { |group| group['name'] == group1.name } + .to satisfy_one { |group| group["name"] == group1.name } end it "does not include statistics" do - get api("/groups", user1), params: { statistics: true } + get api("/groups", user1), params: {statistics: true} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array - expect(json_response.first).not_to include 'statistics' + expect(json_response.first).not_to include "statistics" end end @@ -85,7 +85,7 @@ describe API::Groups do expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array - expect(json_response.first).not_to include('statistics') + expect(json_response.first).not_to include("statistics") end it "includes statistics if requested" do @@ -93,26 +93,26 @@ describe API::Groups do storage_size: 702, repository_size: 123, lfs_objects_size: 234, - build_artifacts_size: 345 + build_artifacts_size: 345, }.stringify_keys exposed_attributes = attributes.dup - exposed_attributes['job_artifacts_size'] = exposed_attributes.delete('build_artifacts_size') + exposed_attributes["job_artifacts_size"] = exposed_attributes.delete("build_artifacts_size") project1.statistics.update!(attributes) - get api("/groups", admin), params: { statistics: true } + get api("/groups", admin), params: {statistics: true} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array expect(json_response) - .to satisfy_one { |group| group['statistics'] == exposed_attributes } + .to satisfy_one { |group| group["statistics"] == exposed_attributes } end end context "when using skip_groups in request" do it "returns all groups excluding skipped groups" do - get api("/groups", admin), params: { skip_groups: [group2.id] } + get api("/groups", admin), params: {skip_groups: [group2.id]} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -122,12 +122,12 @@ describe API::Groups do end context "when using all_available in request" do - let(:response_groups) { json_response.map { |group| group['name'] } } + let(:response_groups) { json_response.map { |group| group["name"] } } it "returns all groups you have access to" do public_group = create :group, :public - get api("/groups", user1), params: { all_available: true } + get api("/groups", user1), params: {all_available: true} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -140,8 +140,8 @@ describe API::Groups do let(:group3) { create(:group, name: "a#{group1.name}", path: "z#{group1.path}") } let(:group4) { create(:group, name: "same-name", path: "y#{group1.path}") } let(:group5) { create(:group, name: "same-name") } - let(:response_groups) { json_response.map { |group| group['name'] } } - let(:response_groups_ids) { json_response.map { |group| group['id'] } } + let(:response_groups) { json_response.map { |group| group["name"] } } + let(:response_groups_ids) { json_response.map { |group| group["id"] } } before do group3.add_owner(user1) @@ -159,7 +159,7 @@ describe API::Groups do end it "sorts in descending order when passed" do - get api("/groups", user1), params: { sort: "desc" } + get api("/groups", user1), params: {sort: "desc"} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -168,7 +168,7 @@ describe API::Groups do end it "sorts by path in order_by param" do - get api("/groups", user1), params: { order_by: "path" } + get api("/groups", user1), params: {order_by: "path"} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -177,7 +177,7 @@ describe API::Groups do end it "sorts by id in the order_by param" do - get api("/groups", user1), params: { order_by: "id" } + get api("/groups", user1), params: {order_by: "id"} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -186,7 +186,7 @@ describe API::Groups do end it "sorts also by descending id with pagination fix" do - get api("/groups", user1), params: { order_by: "id", sort: "desc" } + get api("/groups", user1), params: {order_by: "id", sort: "desc"} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -195,21 +195,21 @@ describe API::Groups do end it "sorts identical keys by id for good pagination" do - get api("/groups", user1), params: { search: "same-name", order_by: "name" } + get api("/groups", user1), params: {search: "same-name", order_by: "name"} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array - expect(response_groups_ids).to eq(Group.select { |group| group['name'] == 'same-name' }.map { |group| group['id'] }.sort) + expect(response_groups_ids).to eq(Group.select { |group| group["name"] == "same-name" }.map { |group| group["id"] }.sort) end it "sorts descending identical keys by id for good pagination" do - get api("/groups", user1), params: { search: "same-name", order_by: "name", sort: "desc" } + get api("/groups", user1), params: {search: "same-name", order_by: "name", sort: "desc"} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array - expect(response_groups_ids).to eq(Group.select { |group| group['name'] == 'same-name' }.map { |group| group['id'] }.sort) + expect(response_groups_ids).to eq(Group.select { |group| group["name"] == "same-name" }.map { |group| group["id"] }.sort) end def groups_visible_to_user(user) @@ -217,31 +217,31 @@ describe API::Groups do end end - context 'when using owned in the request' do - it 'returns an array of groups the user owns' do + context "when using owned in the request" do + it "returns an array of groups the user owns" do group1.add_maintainer(user2) - get api('/groups', user2), params: { owned: true } + get api("/groups", user2), params: {owned: true} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array expect(json_response.length).to eq(1) - expect(json_response.first['name']).to eq(group2.name) + expect(json_response.first["name"]).to eq(group2.name) end end - context 'when using min_access_level in the request' do + context "when using min_access_level in the request" do let!(:group3) { create(:group, :private) } - let(:response_groups) { json_response.map { |group| group['id'] } } + let(:response_groups) { json_response.map { |group| group["id"] } } before do group1.add_developer(user2) group3.add_master(user2) end - it 'returns an array of groups the user has at least master access' do - get api('/groups', user2), params: { min_access_level: 40 } + it "returns an array of groups the user has at least master access" do + get api("/groups", user2), params: {min_access_level: 40} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -260,9 +260,9 @@ describe API::Groups do # Returns a Hash of visibility_level => Project pairs def add_projects_to_group(group, share_with: nil) projects = { - public: create(:project, :public, namespace: group), + public: create(:project, :public, namespace: group), internal: create(:project, :internal, namespace: group), - private: create(:project, :private, namespace: group) + private: create(:project, :private, namespace: group), } if share_with @@ -276,79 +276,79 @@ describe API::Groups do def response_project_ids(json_response, key) json_response[key].map do |project| - project['id'].to_i + project["id"].to_i end end - context 'when unauthenticated' do - it 'returns 404 for a private group' do + context "when unauthenticated" do + it "returns 404 for a private group" do get api("/groups/#{group2.id}") expect(response).to have_gitlab_http_status(404) end - it 'returns 200 for a public group' do + it "returns 200 for a public group" do get api("/groups/#{group1.id}") expect(response).to have_gitlab_http_status(200) end - it 'returns only public projects in the group' do + it "returns only public projects in the group" do public_group = create(:group, :public) projects = add_projects_to_group(public_group) get api("/groups/#{public_group.id}") - expect(response_project_ids(json_response, 'projects')) + expect(response_project_ids(json_response, "projects")) .to contain_exactly(projects[:public].id) end - it 'returns only public projects shared with the group' do + it "returns only public projects shared with the group" do public_group = create(:group, :public) projects = add_projects_to_group(public_group, share_with: group1) get api("/groups/#{group1.id}") - expect(response_project_ids(json_response, 'shared_projects')) + expect(response_project_ids(json_response, "shared_projects")) .to contain_exactly(projects[:public].id) end end context "when authenticated as user" do it "returns one of user1's groups" do - project = create(:project, namespace: group2, path: 'Foo') + project = create(:project, namespace: group2, path: "Foo") create(:project_group_link, project: project, group: group1) get api("/groups/#{group1.id}", user1) expect(response).to have_gitlab_http_status(200) - expect(json_response['id']).to eq(group1.id) - expect(json_response['name']).to eq(group1.name) - expect(json_response['path']).to eq(group1.path) - expect(json_response['description']).to eq(group1.description) - expect(json_response['visibility']).to eq(Gitlab::VisibilityLevel.string_level(group1.visibility_level)) - expect(json_response['avatar_url']).to eq(group1.avatar_url(only_path: false)) - expect(json_response['web_url']).to eq(group1.web_url) - expect(json_response['request_access_enabled']).to eq(group1.request_access_enabled) - expect(json_response['full_name']).to eq(group1.full_name) - expect(json_response['full_path']).to eq(group1.full_path) - expect(json_response['parent_id']).to eq(group1.parent_id) - expect(json_response['projects']).to be_an Array - expect(json_response['projects'].length).to eq(2) - expect(json_response['shared_projects']).to be_an Array - expect(json_response['shared_projects'].length).to eq(1) - expect(json_response['shared_projects'][0]['id']).to eq(project.id) + expect(json_response["id"]).to eq(group1.id) + expect(json_response["name"]).to eq(group1.name) + expect(json_response["path"]).to eq(group1.path) + expect(json_response["description"]).to eq(group1.description) + expect(json_response["visibility"]).to eq(Gitlab::VisibilityLevel.string_level(group1.visibility_level)) + expect(json_response["avatar_url"]).to eq(group1.avatar_url(only_path: false)) + expect(json_response["web_url"]).to eq(group1.web_url) + expect(json_response["request_access_enabled"]).to eq(group1.request_access_enabled) + expect(json_response["full_name"]).to eq(group1.full_name) + expect(json_response["full_path"]).to eq(group1.full_path) + expect(json_response["parent_id"]).to eq(group1.parent_id) + expect(json_response["projects"]).to be_an Array + expect(json_response["projects"].length).to eq(2) + expect(json_response["shared_projects"]).to be_an Array + expect(json_response["shared_projects"].length).to eq(1) + expect(json_response["shared_projects"][0]["id"]).to eq(project.id) end it "returns one of user1's groups without projects when with_projects option is set to false" do - project = create(:project, namespace: group2, path: 'Foo') + project = create(:project, namespace: group2, path: "Foo") create(:project_group_link, project: project, group: group1) - get api("/groups/#{group1.id}", user1), params: { with_projects: false } + get api("/groups/#{group1.id}", user1), params: {with_projects: false} expect(response).to have_gitlab_http_status(200) - expect(json_response['projects']).to be_nil - expect(json_response['shared_projects']).to be_nil + expect(json_response["projects"]).to be_nil + expect(json_response["shared_projects"]).to be_nil end it "does not return a non existing group" do @@ -363,38 +363,38 @@ describe API::Groups do expect(response).to have_gitlab_http_status(404) end - it 'returns only public and internal projects in the group' do + it "returns only public and internal projects in the group" do public_group = create(:group, :public) projects = add_projects_to_group(public_group) get api("/groups/#{public_group.id}", user2) - expect(response_project_ids(json_response, 'projects')) + expect(response_project_ids(json_response, "projects")) .to contain_exactly(projects[:public].id, projects[:internal].id) end - it 'returns only public and internal projects shared with the group' do + it "returns only public and internal projects shared with the group" do public_group = create(:group, :public) projects = add_projects_to_group(public_group, share_with: group1) get api("/groups/#{group1.id}", user2) - expect(response_project_ids(json_response, 'shared_projects')) + expect(response_project_ids(json_response, "shared_projects")) .to contain_exactly(projects[:public].id, projects[:internal].id) end - it 'avoids N+1 queries' do + it "avoids N+1 queries" do get api("/groups/#{group1.id}", admin) - control_count = ActiveRecord::QueryRecorder.new do + control_count = ActiveRecord::QueryRecorder.new { get api("/groups/#{group1.id}", admin) - end.count + }.count create(:project, namespace: group1) - expect do + expect { get api("/groups/#{group1.id}", admin) - end.not_to exceed_query_limit(control_count) + }.not_to exceed_query_limit(control_count) end end @@ -403,7 +403,7 @@ describe API::Groups do get api("/groups/#{group2.id}", admin) expect(response).to have_gitlab_http_status(200) - expect(json_response['name']).to eq(group2.name) + expect(json_response["name"]).to eq(group2.name) end it "does not return a non existing group" do @@ -413,21 +413,21 @@ describe API::Groups do end end - context 'when using group path in URL' do - it 'returns any existing group' do + context "when using group path in URL" do + it "returns any existing group" do get api("/groups/#{group1.path}", admin) expect(response).to have_gitlab_http_status(200) - expect(json_response['name']).to eq(group1.name) + expect(json_response["name"]).to eq(group1.name) end - it 'does not return a non existing group' do - get api('/groups/unknown', admin) + it "does not return a non existing group" do + get api("/groups/unknown", admin) expect(response).to have_gitlab_http_status(404) end - it 'does not return a group not attached to user1' do + it "does not return a group not attached to user1" do get api("/groups/#{group2.path}", user1) expect(response).to have_gitlab_http_status(404) @@ -435,45 +435,45 @@ describe API::Groups do end end - describe 'PUT /groups/:id' do - let(:new_group_name) { 'New Group'} + describe "PUT /groups/:id" do + let(:new_group_name) { "New Group"} - context 'when authenticated as the group owner' do - it 'updates the group' do - put api("/groups/#{group1.id}", user1), params: { name: new_group_name, request_access_enabled: true } + context "when authenticated as the group owner" do + it "updates the group" do + put api("/groups/#{group1.id}", user1), params: {name: new_group_name, request_access_enabled: true} expect(response).to have_gitlab_http_status(200) - expect(json_response['name']).to eq(new_group_name) - expect(json_response['request_access_enabled']).to eq(true) + expect(json_response["name"]).to eq(new_group_name) + expect(json_response["request_access_enabled"]).to eq(true) end - it 'returns 404 for a non existing group' do - put api('/groups/1328', user1), params: { name: new_group_name } + it "returns 404 for a non existing group" do + put api("/groups/1328", user1), params: {name: new_group_name} expect(response).to have_gitlab_http_status(404) end end - context 'when authenticated as the admin' do - it 'updates the group' do - put api("/groups/#{group1.id}", admin), params: { name: new_group_name } + context "when authenticated as the admin" do + it "updates the group" do + put api("/groups/#{group1.id}", admin), params: {name: new_group_name} expect(response).to have_gitlab_http_status(200) - expect(json_response['name']).to eq(new_group_name) + expect(json_response["name"]).to eq(new_group_name) end end - context 'when authenticated as an user that can see the group' do - it 'does not updates the group' do - put api("/groups/#{group1.id}", user2), params: { name: new_group_name } + context "when authenticated as an user that can see the group" do + it "does not updates the group" do + put api("/groups/#{group1.id}", user2), params: {name: new_group_name} expect(response).to have_gitlab_http_status(403) end end - context 'when authenticated as an user that cannot see the group' do - it 'returns 404 when trying to update the group' do - put api("/groups/#{group2.id}", user1), params: { name: new_group_name } + context "when authenticated as an user that cannot see the group" do + it "returns 404 when trying to update the group" do + put api("/groups/#{group2.id}", user1), params: {name: new_group_name} expect(response).to have_gitlab_http_status(404) end @@ -488,32 +488,32 @@ describe API::Groups do expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response.length).to eq(2) - project_names = json_response.map { |proj| proj['name'] } + project_names = json_response.map { |proj| proj["name"] } expect(project_names).to match_array([project1.name, project3.name]) - expect(json_response.first['visibility']).to be_present + expect(json_response.first["visibility"]).to be_present end it "returns the group's projects with simple representation" do - get api("/groups/#{group1.id}/projects", user1), params: { simple: true } + get api("/groups/#{group1.id}/projects", user1), params: {simple: true} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response.length).to eq(2) - project_names = json_response.map { |proj| proj['name'] } + project_names = json_response.map { |proj| proj["name"] } expect(project_names).to match_array([project1.name, project3.name]) - expect(json_response.first['visibility']).not_to be_present + expect(json_response.first["visibility"]).not_to be_present end it "filters the groups projects" do - public_project = create(:project, :public, path: 'test1', group: group1) + public_project = create(:project, :public, path: "test1", group: group1) - get api("/groups/#{group1.id}/projects", user1), params: { visibility: 'public' } + get api("/groups/#{group1.id}/projects", user1), params: {visibility: "public"} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an(Array) expect(json_response.length).to eq(1) - expect(json_response.first['name']).to eq(public_project.name) + expect(json_response.first["name"]).to eq(public_project.name) end it "returns projects excluding shared" do @@ -521,7 +521,7 @@ describe API::Groups do create(:project_group_link, project: create(:project), group: group1) create(:project_group_link, project: create(:project), group: group1) - get api("/groups/#{group1.id}/projects", user1), params: { with_shared: false } + get api("/groups/#{group1.id}/projects", user1), params: {with_shared: false} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -534,7 +534,7 @@ describe API::Groups do create(:project, group: subgroup) create(:project, group: subgroup) - get api("/groups/#{group1.id}/projects", user1), params: { include_subgroups: true } + get api("/groups/#{group1.id}/projects", user1), params: {include_subgroups: true} expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers @@ -562,27 +562,27 @@ describe API::Groups do expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response.length).to eq(1) - expect(json_response.first['name']).to eq(project3.name) + expect(json_response.first["name"]).to eq(project3.name) end - it 'only returns the projects owned by user' do + it "only returns the projects owned by user" do project2.group.add_owner(user3) - get api("/groups/#{project2.group.id}/projects", user3), params: { owned: true } + get api("/groups/#{project2.group.id}/projects", user3), params: {owned: true} expect(response).to have_gitlab_http_status(200) expect(json_response.length).to eq(1) - expect(json_response.first['name']).to eq(project2.name) + expect(json_response.first["name"]).to eq(project2.name) end - it 'only returns the projects starred by user' do + it "only returns the projects starred by user" do user1.starred_projects = [project1] - get api("/groups/#{group1.id}/projects", user1), params: { starred: true } + get api("/groups/#{group1.id}/projects", user1), params: {starred: true} expect(response).to have_gitlab_http_status(200) expect(json_response.length).to eq(1) - expect(json_response.first['name']).to eq(project1.name) + expect(json_response.first["name"]).to eq(project1.name) end end @@ -593,7 +593,7 @@ describe API::Groups do expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response.length).to eq(1) - expect(json_response.first['name']).to eq(project2.name) + expect(json_response.first["name"]).to eq(project2.name) end it "does not return a non existing group" do @@ -602,38 +602,38 @@ describe API::Groups do expect(response).to have_gitlab_http_status(404) end - it 'avoids N+1 queries' do + it "avoids N+1 queries" do get api("/groups/#{group1.id}/projects", admin) - control_count = ActiveRecord::QueryRecorder.new do + control_count = ActiveRecord::QueryRecorder.new { get api("/groups/#{group1.id}/projects", admin) - end.count + }.count create(:project, namespace: group1) - expect do + expect { get api("/groups/#{group1.id}/projects", admin) - end.not_to exceed_query_limit(control_count) + }.not_to exceed_query_limit(control_count) end end - context 'when using group path in URL' do - it 'returns any existing group' do + context "when using group path in URL" do + it "returns any existing group" do get api("/groups/#{group1.path}/projects", admin) expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers - project_names = json_response.map { |proj| proj['name'] } + project_names = json_response.map { |proj| proj["name"] } expect(project_names).to match_array([project1.name, project3.name]) end - it 'does not return a non existing group' do - get api('/groups/unknown/projects', admin) + it "does not return a non existing group" do + get api("/groups/unknown/projects", admin) expect(response).to have_gitlab_http_status(404) end - it 'does not return a group not attached to user1' do + it "does not return a group not attached to user1" do get api("/groups/#{group2.path}/projects", user1) expect(response).to have_gitlab_http_status(404) @@ -641,33 +641,33 @@ describe API::Groups do end end - describe 'GET /groups/:id/subgroups', :nested_groups do + describe "GET /groups/:id/subgroups", :nested_groups do let!(:subgroup1) { create(:group, parent: group1) } let!(:subgroup2) { create(:group, :private, parent: group1) } let!(:subgroup3) { create(:group, :private, parent: group2) } - context 'when unauthenticated' do - it 'returns only public subgroups' do + context "when unauthenticated" do + it "returns only public subgroups" do get api("/groups/#{group1.id}/subgroups") expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array expect(json_response.length).to eq(1) - expect(json_response.first['id']).to eq(subgroup1.id) - expect(json_response.first['parent_id']).to eq(group1.id) + expect(json_response.first["id"]).to eq(subgroup1.id) + expect(json_response.first["parent_id"]).to eq(group1.id) end - it 'returns 404 for a private group' do + it "returns 404 for a private group" do get api("/groups/#{group2.id}/subgroups") expect(response).to have_gitlab_http_status(404) end end - context 'when authenticated as user' do - context 'when user is not member of a public group' do - it 'returns no subgroups for the public group' do + context "when authenticated as user" do + context "when user is not member of a public group" do + it "returns no subgroups for the public group" do get api("/groups/#{group1.id}/subgroups", user2) expect(response).to have_gitlab_http_status(200) @@ -675,75 +675,75 @@ describe API::Groups do expect(json_response.length).to eq(0) end - context 'when using all_available in request' do - it 'returns public subgroups' do - get api("/groups/#{group1.id}/subgroups", user2), params: { all_available: true } + context "when using all_available in request" do + it "returns public subgroups" do + get api("/groups/#{group1.id}/subgroups", user2), params: {all_available: true} expect(response).to have_gitlab_http_status(200) expect(json_response).to be_an Array expect(json_response.length).to eq(1) - expect(json_response[0]['id']).to eq(subgroup1.id) - expect(json_response[0]['parent_id']).to eq(group1.id) + expect(json_response[0]["id"]).to eq(subgroup1.id) + expect(json_response[0]["parent_id"]).to eq(group1.id) end end end - context 'when user is not member of a private group' do - it 'returns 404 for the private group' do + context "when user is not member of a private group" do + it "returns 404 for the private group" do get api("/groups/#{group2.id}/subgroups", user1) expect(response).to have_gitlab_http_status(404) end end - context 'when user is member of public group' do + context "when user is member of public group" do before do group1.add_guest(user2) end - it 'returns private subgroups' do + it "returns private subgroups" do get api("/groups/#{group1.id}/subgroups", user2) expect(response).to have_gitlab_http_status(200) expect(response).to include_pagination_headers expect(json_response).to be_an Array expect(json_response.length).to eq(2) - private_subgroups = json_response.select { |group| group['visibility'] == 'private' } + private_subgroups = json_response.select { |group| group["visibility"] == "private" } expect(private_subgroups.length).to eq(1) - expect(private_subgroups.first['id']).to eq(subgroup2.id) - expect(private_subgroups.first['parent_id']).to eq(group1.id) + expect(private_subgroups.first["id"]).to eq(subgroup2.id) + expect(private_subgroups.first["parent_id"]).to eq(group1.id) end - context 'when using statistics in request' do - it 'does not include statistics' do - get api("/groups/#{group1.id}/subgroups", user2), params: { statistics: true } + context "when using statistics in request" do + it "does not include statistics" do + get api("/groups/#{group1.id}/subgroups", user2), params: {statistics: true} expect(response).to have_gitlab_http_status(200) expect(json_response).to be_an Array - expect(json_response.first).not_to include 'statistics' + expect(json_response.first).not_to include "statistics" end end end - context 'when user is member of private group' do + context "when user is member of private group" do before do group2.add_guest(user1) end - it 'returns subgroups' do + it "returns subgroups" do get api("/groups/#{group2.id}/subgroups", user1) expect(response).to have_gitlab_http_status(200) expect(json_response).to be_an Array expect(json_response.length).to eq(1) - expect(json_response.first['id']).to eq(subgroup3.id) - expect(json_response.first['parent_id']).to eq(group2.id) + expect(json_response.first["id"]).to eq(subgroup3.id) + expect(json_response.first["parent_id"]).to eq(group2.id) end end end - context 'when authenticated as admin' do - it 'returns private subgroups of a public group' do + context "when authenticated as admin" do + it "returns private subgroups of a public group" do get api("/groups/#{group1.id}/subgroups", admin) expect(response).to have_gitlab_http_status(200) @@ -751,7 +751,7 @@ describe API::Groups do expect(json_response.length).to eq(2) end - it 'returns subgroups of a private group' do + it "returns subgroups of a private group" do get api("/groups/#{group2.id}/subgroups", admin) expect(response).to have_gitlab_http_status(200) @@ -759,20 +759,20 @@ describe API::Groups do expect(json_response.length).to eq(1) end - it 'does not include statistics by default' do + it "does not include statistics by default" do get api("/groups/#{group1.id}/subgroups", admin) expect(response).to have_gitlab_http_status(200) expect(json_response).to be_an Array - expect(json_response.first).not_to include('statistics') + expect(json_response.first).not_to include("statistics") end - it 'includes statistics if requested' do - get api("/groups/#{group1.id}/subgroups", admin), params: { statistics: true } + it "includes statistics if requested" do + get api("/groups/#{group1.id}/subgroups", admin), params: {statistics: true} expect(response).to have_gitlab_http_status(200) expect(json_response).to be_an Array - expect(json_response.first).to include('statistics') + expect(json_response.first).to include("statistics") end end end @@ -785,25 +785,25 @@ describe API::Groups do expect(response).to have_gitlab_http_status(403) end - context 'as owner', :nested_groups do + context "as owner", :nested_groups do before do group2.add_owner(user1) end - it 'can create subgroups' do - post api("/groups", user1), params: { parent_id: group2.id, name: 'foo', path: 'foo' } + it "can create subgroups" do + post api("/groups", user1), params: {parent_id: group2.id, name: "foo", path: "foo"} expect(response).to have_gitlab_http_status(201) end end - context 'as maintainer', :nested_groups do + context "as maintainer", :nested_groups do before do group2.add_maintainer(user1) end - it 'cannot create subgroups' do - post api("/groups", user1), params: { parent_id: group2.id, name: 'foo', path: 'foo' } + it "cannot create subgroups" do + post api("/groups", user1), params: {parent_id: group2.id, name: "foo", path: "foo"} expect(response).to have_gitlab_http_status(403) end @@ -812,7 +812,7 @@ describe API::Groups do context "when authenticated as user with group permissions" do it "creates group" do - group = attributes_for(:group, { request_access_enabled: false }) + group = attributes_for(:group, {request_access_enabled: false}) post api("/groups", user3), params: group @@ -827,7 +827,7 @@ describe API::Groups do it "creates a nested group", :nested_groups do parent = create(:group) parent.add_owner(user3) - group = attributes_for(:group, { parent_id: parent.id }) + group = attributes_for(:group, {parent_id: parent.id}) post api("/groups", user3), params: group @@ -838,20 +838,20 @@ describe API::Groups do end it "does not create group, duplicate" do - post api("/groups", user3), params: { name: 'Duplicate Test', path: group2.path } + post api("/groups", user3), params: {name: "Duplicate Test", path: group2.path} expect(response).to have_gitlab_http_status(400) expect(response.message).to eq("Bad Request") end it "returns 400 bad request error if name not given" do - post api("/groups", user3), params: { path: group2.path } + post api("/groups", user3), params: {path: group2.path} expect(response).to have_gitlab_http_status(400) end it "returns 400 bad request error if path not given" do - post api("/groups", user3), params: { name: 'test' } + post api("/groups", user3), params: {name: "test"} expect(response).to have_gitlab_http_status(400) end @@ -868,7 +868,7 @@ describe API::Groups do expect(response).to have_gitlab_http_status(202) end - it_behaves_like '412 response' do + it_behaves_like "412 response" do let(:request) { api("/groups/#{group1.id}", user1) } let(:success_status) { 202 } end @@ -934,8 +934,8 @@ describe API::Groups do expect(response).to have_gitlab_http_status(201) end - context 'when using project path in URL' do - context 'with a valid project path' do + context "when using project path in URL" do + context "with a valid project path" do it "transfers project to group" do post api("/groups/#{group1.id}/projects/#{project_path}", admin) @@ -943,7 +943,7 @@ describe API::Groups do end end - context 'with a non-existent project path' do + context "with a non-existent project path" do it "does not transfer project to group" do post api("/groups/#{group1.id}/projects/nogroup%2Fnoproject", admin) @@ -952,8 +952,8 @@ describe API::Groups do end end - context 'when using a group path in URL' do - context 'with a valid group path' do + context "when using a group path in URL" do + context "with a valid group path" do it "transfers project to group" do post api("/groups/#{group1.path}/projects/#{project_path}", admin) @@ -961,7 +961,7 @@ describe API::Groups do end end - context 'with a non-existent group path' do + context "with a non-existent group path" do it "does not transfer project to group" do post api("/groups/noexist/projects/#{project_path}", admin) @@ -972,7 +972,7 @@ describe API::Groups do end end - it_behaves_like 'custom attributes endpoints', 'groups' do + it_behaves_like "custom attributes endpoints", "groups" do let(:attributable) { group1 } let(:other_attributable) { group2 } let(:user) { user1 } |