diff options
Diffstat (limited to 'spec/graphql/resolvers')
| -rw-r--r-- | spec/graphql/resolvers/projects/snippets_resolver_spec.rb | 6 | ||||
| -rw-r--r-- | spec/graphql/resolvers/snippets_resolver_spec.rb | 10 | ||||
| -rw-r--r-- | spec/graphql/resolvers/users/snippets_resolver_spec.rb | 2 |
3 files changed, 6 insertions, 12 deletions
diff --git a/spec/graphql/resolvers/projects/snippets_resolver_spec.rb b/spec/graphql/resolvers/projects/snippets_resolver_spec.rb index b4a5eb8ddb0..6f7feff8fe5 100644 --- a/spec/graphql/resolvers/projects/snippets_resolver_spec.rb +++ b/spec/graphql/resolvers/projects/snippets_resolver_spec.rb @@ -56,12 +56,6 @@ RSpec.describe Resolvers::Projects::SnippetsResolver do expect(snippets).to contain_exactly(project_snippet, other_project_snippet) end - - it 'returns an error if the gid is invalid' do - expect do - resolve_snippets(args: { ids: 'foo' }) - end.to raise_error(Gitlab::Graphql::Errors::ArgumentError) - end end context 'when no project is provided' do diff --git a/spec/graphql/resolvers/snippets_resolver_spec.rb b/spec/graphql/resolvers/snippets_resolver_spec.rb index 180be8e8624..a58d9c5ac3a 100644 --- a/spec/graphql/resolvers/snippets_resolver_spec.rb +++ b/spec/graphql/resolvers/snippets_resolver_spec.rb @@ -36,7 +36,7 @@ RSpec.describe Resolvers::SnippetsResolver do context 'when using filters' do context 'by author id' do it 'returns the snippets' do - snippets = resolve_snippets(args: { author_id: current_user.to_global_id }) + snippets = resolve_snippets(args: { author_id: global_id_of(current_user) }) expect(snippets).to contain_exactly(personal_snippet, project_snippet) end @@ -44,7 +44,7 @@ RSpec.describe Resolvers::SnippetsResolver do it 'returns an error if the param id is invalid' do expect do resolve_snippets(args: { author_id: 'foo' }) - end.to raise_error(Gitlab::Graphql::Errors::ArgumentError) + end.to raise_error(GraphQL::CoercionError) end end @@ -65,7 +65,7 @@ RSpec.describe Resolvers::SnippetsResolver do it 'returns an error if the param id is invalid' do expect do resolve_snippets(args: { project_id: 'foo' }) - end.to raise_error(Gitlab::Graphql::Errors::ArgumentError) + end.to raise_error(GraphQL::CoercionError) end end @@ -99,14 +99,14 @@ RSpec.describe Resolvers::SnippetsResolver do expect(snippets).to contain_exactly(personal_snippet, project_snippet) end - it 'returns an error if the gid is invalid' do + it 'returns an error if the id cannot be coerced' do args = { ids: [personal_snippet.to_global_id, 'foo'] } expect do resolve_snippets(args: args) - end.to raise_error(Gitlab::Graphql::Errors::ArgumentError) + end.to raise_error(GraphQL::CoercionError, '"foo" is not a valid Global ID') end it 'returns an error if both project and author are provided' do diff --git a/spec/graphql/resolvers/users/snippets_resolver_spec.rb b/spec/graphql/resolvers/users/snippets_resolver_spec.rb index 497b6b11b46..9ccbebc59e6 100644 --- a/spec/graphql/resolvers/users/snippets_resolver_spec.rb +++ b/spec/graphql/resolvers/users/snippets_resolver_spec.rb @@ -73,7 +73,7 @@ RSpec.describe Resolvers::Users::SnippetsResolver do expect do resolve_snippets(args: args) - end.to raise_error(Gitlab::Graphql::Errors::ArgumentError) + end.to raise_error(GraphQL::CoercionError) end end end |
