summaryrefslogtreecommitdiff
path: root/spec/finders/notes_finder_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/finders/notes_finder_spec.rb')
-rw-r--r--spec/finders/notes_finder_spec.rb120
1 files changed, 60 insertions, 60 deletions
diff --git a/spec/finders/notes_finder_spec.rb b/spec/finders/notes_finder_spec.rb
index 0a685152cf9..56f08e408d8 100644
--- a/spec/finders/notes_finder_spec.rb
+++ b/spec/finders/notes_finder_spec.rb
@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
describe NotesFinder do
let(:user) { create :user }
@@ -8,12 +8,12 @@ describe NotesFinder do
project.add_maintainer(user)
end
- describe '#execute' do
- context 'when notes filter is present' do
+ describe "#execute" do
+ context "when notes filter is present" do
let!(:comment) { create(:note_on_issue, project: project) }
let!(:system_note) { create(:note_on_issue, project: project, system: true) }
- it 'returns only user notes when using only_comments filter' do
+ it "returns only user notes when using only_comments filter" do
finder = described_class.new(project, user, notes_filter: UserPreference::NOTES_FILTERS[:only_comments])
notes = finder.execute
@@ -21,7 +21,7 @@ describe NotesFinder do
expect(notes).to match_array(comment)
end
- it 'returns only system notes when using only_activity filters' do
+ it "returns only system notes when using only_activity filters" do
finder = described_class.new(project, user, notes_filter: UserPreference::NOTES_FILTERS[:only_activity])
notes = finder.execute
@@ -29,7 +29,7 @@ describe NotesFinder do
expect(notes).to match_array(system_note)
end
- it 'gets all notes' do
+ it "gets all notes" do
finder = described_class.new(project, user, notes_filter: UserPreference::NOTES_FILTERS[:all_activity])
notes = finder.execute
@@ -38,7 +38,7 @@ describe NotesFinder do
end
end
- it 'finds notes on merge requests' do
+ it "finds notes on merge requests" do
create(:note_on_merge_request, project: project)
notes = described_class.new(project, user).execute
@@ -46,7 +46,7 @@ describe NotesFinder do
expect(notes.count).to eq(1)
end
- it 'finds notes on snippets' do
+ it "finds notes on snippets" do
create(:note_on_project_snippet, project: project)
notes = described_class.new(project, user).execute
@@ -57,29 +57,29 @@ describe NotesFinder do
it "excludes notes on commits the author can't download" do
project = create(:project, :private, :repository)
note = create(:note_on_commit, project: project)
- params = { target_type: 'commit', target_id: note.noteable.id }
+ params = {target_type: "commit", target_id: note.noteable.id}
notes = described_class.new(project, create(:user), params).execute
expect(notes.count).to eq(0)
end
- it 'succeeds when no notes found' do
+ it "succeeds when no notes found" do
notes = described_class.new(project, create(:user)).execute
expect(notes.count).to eq(0)
end
- context 'on restricted projects' do
+ context "on restricted projects" do
let(:project) do
create(:project,
- :public,
- :issues_private,
- :snippets_private,
- :merge_requests_private)
+ :public,
+ :issues_private,
+ :snippets_private,
+ :merge_requests_private)
end
- it 'publicly excludes notes on merge requests' do
+ it "publicly excludes notes on merge requests" do
create(:note_on_merge_request, project: project)
notes = described_class.new(project, create(:user)).execute
@@ -87,7 +87,7 @@ describe NotesFinder do
expect(notes.count).to eq(0)
end
- it 'publicly excludes notes on issues' do
+ it "publicly excludes notes on issues" do
create(:note_on_issue, project: project)
notes = described_class.new(project, create(:user)).execute
@@ -95,7 +95,7 @@ describe NotesFinder do
expect(notes.count).to eq(0)
end
- it 'publicly excludes notes on snippets' do
+ it "publicly excludes notes on snippets" do
create(:note_on_project_snippet, project: project)
notes = described_class.new(project, create(:user)).execute
@@ -104,89 +104,89 @@ describe NotesFinder do
end
end
- context 'for target type' do
+ context "for target type" do
let(:project) { create(:project, :repository) }
let!(:note1) { create :note_on_issue, project: project }
let!(:note2) { create :note_on_commit, project: project }
- it 'finds only notes for the selected type' do
- notes = described_class.new(project, user, target_type: 'issue').execute
+ it "finds only notes for the selected type" do
+ notes = described_class.new(project, user, target_type: "issue").execute
expect(notes).to eq([note1])
end
end
- context 'for target' do
+ context "for target" do
let(:project) { create(:project, :repository) }
let(:note1) { create :note_on_commit, project: project }
let(:note2) { create :note_on_commit, project: project }
let(:commit) { note1.noteable }
- let(:params) { { target_id: commit.id, target_type: 'commit', last_fetched_at: 1.hour.ago.to_i } }
+ let(:params) { {target_id: commit.id, target_type: "commit", last_fetched_at: 1.hour.ago.to_i} }
before do
note1
note2
end
- it 'finds all notes' do
+ it "finds all notes" do
notes = described_class.new(project, user, params).execute
expect(notes.size).to eq(2)
end
- it 'finds notes on merge requests' do
+ it "finds notes on merge requests" do
note = create(:note_on_merge_request, project: project)
- params = { target_type: 'merge_request', target_id: note.noteable.id }
+ params = {target_type: "merge_request", target_id: note.noteable.id}
notes = described_class.new(project, user, params).execute
expect(notes).to include(note)
end
- it 'finds notes on snippets' do
+ it "finds notes on snippets" do
note = create(:note_on_project_snippet, project: project)
- params = { target_type: 'snippet', target_id: note.noteable.id }
+ params = {target_type: "snippet", target_id: note.noteable.id}
notes = described_class.new(project, user, params).execute
expect(notes.count).to eq(1)
end
- it 'finds notes on personal snippets' do
+ it "finds notes on personal snippets" do
note = create(:note_on_personal_snippet)
- params = { target_type: 'personal_snippet', target_id: note.noteable_id }
+ params = {target_type: "personal_snippet", target_id: note.noteable_id}
notes = described_class.new(project, user, params).execute
expect(notes.count).to eq(1)
end
- it 'raises an exception for an invalid target_type' do
- params[:target_type] = 'invalid'
+ it "raises an exception for an invalid target_type" do
+ params[:target_type] = "invalid"
expect { described_class.new(project, user, params).execute }.to raise_error("invalid target_type '#{params[:target_type]}'")
end
- it 'filters out old notes' do
+ it "filters out old notes" do
note2.update_attribute(:updated_at, 2.hours.ago)
notes = described_class.new(project, user, params).execute
expect(notes).to eq([note1])
end
- context 'confidential issue notes' do
+ context "confidential issue notes" do
let(:confidential_issue) { create(:issue, :confidential, project: project, author: user) }
let!(:confidential_note) { create(:note, noteable: confidential_issue, project: confidential_issue.project) }
- let(:params) { { target_id: confidential_issue.id, target_type: 'issue', last_fetched_at: 1.hour.ago.to_i } }
+ let(:params) { {target_id: confidential_issue.id, target_type: "issue", last_fetched_at: 1.hour.ago.to_i} }
- it 'returns notes if user can see the issue' do
+ it "returns notes if user can see the issue" do
expect(described_class.new(project, user, params).execute).to eq([confidential_note])
end
- it 'raises an error if user can not see the issue' do
+ it "raises an error if user can not see the issue" do
user = create(:user)
expect { described_class.new(project, user, params).execute }.to raise_error(ActiveRecord::RecordNotFound)
end
- it 'raises an error for project members with guest role' do
+ it "raises an error for project members with guest role" do
user = create(:user)
project.add_guest(user)
@@ -196,19 +196,19 @@ describe NotesFinder do
end
end
- describe '.search' do
+ describe ".search" do
let(:project) { create(:project, :public) }
- let(:note) { create(:note_on_issue, note: 'WoW', project: project) }
+ let(:note) { create(:note_on_issue, note: "WoW", project: project) }
- it 'returns notes with matching content' do
+ it "returns notes with matching content" do
expect(described_class.new(note.project, nil, search: note.note).execute).to eq([note])
end
- it 'returns notes with matching content regardless of the casing' do
- expect(described_class.new(note.project, nil, search: 'WOW').execute).to eq([note])
+ it "returns notes with matching content regardless of the casing" do
+ expect(described_class.new(note.project, nil, search: "WOW").execute).to eq([note])
end
- it 'returns commit notes user can access' do
+ it "returns commit notes user can access" do
note = create(:note_on_commit, project: project)
expect(described_class.new(note.project, create(:user), search: note.note).execute).to eq([note])
@@ -239,56 +239,56 @@ describe NotesFinder do
end
end
- context 'inlines SQL filters on subqueries for performance' do
+ context "inlines SQL filters on subqueries for performance" do
let(:sql) { described_class.new(note.project, nil, search: note.note).execute.to_sql }
let(:number_of_noteable_types) { 4 }
- specify 'project_id check' do
+ specify "project_id check" do
expect(sql.scan(/project_id/).count).to be >= (number_of_noteable_types + 2)
end
- specify 'search filter' do
+ specify "search filter" do
expect(sql.scan(/LIKE/).count).to be >= number_of_noteable_types
end
end
end
- describe '#target' do
+ describe "#target" do
subject { described_class.new(project, user, params) }
- context 'for a issue target' do
+ context "for a issue target" do
let(:issue) { create(:issue, project: project) }
- let(:params) { { target_type: 'issue', target_id: issue.id } }
+ let(:params) { {target_type: "issue", target_id: issue.id} }
- it 'returns the issue' do
+ it "returns the issue" do
expect(subject.target).to eq(issue)
end
end
- context 'for a merge request target' do
+ context "for a merge request target" do
let(:merge_request) { create(:merge_request, source_project: project) }
- let(:params) { { target_type: 'merge_request', target_id: merge_request.id } }
+ let(:params) { {target_type: "merge_request", target_id: merge_request.id} }
- it 'returns the merge_request' do
+ it "returns the merge_request" do
expect(subject.target).to eq(merge_request)
end
end
- context 'for a snippet target' do
+ context "for a snippet target" do
let(:snippet) { create(:project_snippet, project: project) }
- let(:params) { { target_type: 'snippet', target_id: snippet.id } }
+ let(:params) { {target_type: "snippet", target_id: snippet.id} }
- it 'returns the snippet' do
+ it "returns the snippet" do
expect(subject.target).to eq(snippet)
end
end
- context 'for a commit target' do
+ context "for a commit target" do
let(:project) { create(:project, :repository) }
let(:commit) { project.commit }
- let(:params) { { target_type: 'commit', target_id: commit.id } }
+ let(:params) { {target_type: "commit", target_id: commit.id} }
- it 'returns the commit' do
+ it "returns the commit" do
expect(subject.target).to eq(commit)
end
end