diff options
Diffstat (limited to 'spec/controllers/projects_controller_spec.rb')
| -rw-r--r-- | spec/controllers/projects_controller_spec.rb | 538 |
1 files changed, 269 insertions, 269 deletions
diff --git a/spec/controllers/projects_controller_spec.rb b/spec/controllers/projects_controller_spec.rb index a1662658ade..cec2242907b 100644 --- a/spec/controllers/projects_controller_spec.rb +++ b/spec/controllers/projects_controller_spec.rb @@ -1,4 +1,4 @@ -require('spec_helper') +require("spec_helper") describe ProjectsController do include ProjectForksHelper @@ -6,44 +6,44 @@ describe ProjectsController do let(:project) { create(:project) } let(:public_project) { create(:project, :public) } let(:user) { create(:user) } - let(:jpg) { fixture_file_upload('spec/fixtures/rails_sample.jpg', 'image/jpg') } - let(:txt) { fixture_file_upload('spec/fixtures/doc_sample.txt', 'text/plain') } + let(:jpg) { fixture_file_upload("spec/fixtures/rails_sample.jpg", "image/jpg") } + let(:txt) { fixture_file_upload("spec/fixtures/doc_sample.txt", "text/plain") } - describe 'GET new' do - context 'with an authenticated user' do + describe "GET new" do + context "with an authenticated user" do let(:group) { create(:group) } before do sign_in(user) end - context 'when namespace_id param is present' do - context 'when user has access to the namespace' do - it 'renders the template' do + context "when namespace_id param is present" do + context "when user has access to the namespace" do + it "renders the template" do group.add_owner(user) - get :new, params: { namespace_id: group.id } + get :new, params: {namespace_id: group.id} expect(response).to have_gitlab_http_status(200) - expect(response).to render_template('new') + expect(response).to render_template("new") end end - context 'when user does not have access to the namespace' do - it 'responds with status 404' do - get :new, params: { namespace_id: group.id } + context "when user does not have access to the namespace" do + it "responds with status 404" do + get :new, params: {namespace_id: group.id} expect(response).to have_gitlab_http_status(404) - expect(response).not_to render_template('new') + expect(response).not_to render_template("new") end end end end end - describe 'GET index' do - context 'as a user' do - it 'redirects to root page' do + describe "GET index" do + context "as a user" do + it "redirects to root page" do sign_in(user) get :index @@ -52,8 +52,8 @@ describe ProjectsController do end end - context 'as a guest' do - it 'redirects to Explore page' do + context "as a guest" do + it "redirects to Explore page" do get :index expect(response).to redirect_to(explore_root_path) @@ -71,7 +71,7 @@ describe ProjectsController do let(:private_project) { create(:project, :private) } it "does not initialize notification setting" do - get :show, params: { namespace_id: private_project.namespace, id: private_project } + get :show, params: {namespace_id: private_project.namespace, id: private_project} expect(assigns(:notification_setting)).to be_nil end end @@ -79,7 +79,7 @@ describe ProjectsController do context "user has access to project" do context "and does not have notification setting" do it "initializes notification as disabled" do - get :show, params: { namespace_id: public_project.namespace, id: public_project } + get :show, params: {namespace_id: public_project.namespace, id: public_project} expect(assigns(:notification_setting).level).to eq("global") end end @@ -92,7 +92,7 @@ describe ProjectsController do end it "shows current notification setting" do - get :show, params: { namespace_id: public_project.namespace, id: public_project } + get :show, params: {namespace_id: public_project.namespace, id: public_project} expect(assigns(:notification_setting).level).to eq("watch") end end @@ -106,42 +106,42 @@ describe ProjectsController do project.project_feature.update_attribute(:repository_access_level, ProjectFeature::DISABLED) end - it 'shows wiki homepage' do - get :show, params: { namespace_id: project.namespace, id: project } + it "shows wiki homepage" do + get :show, params: {namespace_id: project.namespace, id: project} - expect(response).to render_template('projects/_wiki') + expect(response).to render_template("projects/_wiki") end - it 'shows issues list page if wiki is disabled' do + it "shows issues list page if wiki is disabled" do project.project_feature.update_attribute(:wiki_access_level, ProjectFeature::DISABLED) create(:issue, project: project) - get :show, params: { namespace_id: project.namespace, id: project } + get :show, params: {namespace_id: project.namespace, id: project} - expect(response).to render_template('projects/issues/_issues') + expect(response).to render_template("projects/issues/_issues") expect(assigns(:issuable_meta_data)).not_to be_nil end - it 'shows customize workflow page if wiki and issues are disabled' do + it "shows customize workflow page if wiki and issues are disabled" do project.project_feature.update_attribute(:wiki_access_level, ProjectFeature::DISABLED) project.project_feature.update_attribute(:issues_access_level, ProjectFeature::DISABLED) - get :show, params: { namespace_id: project.namespace, id: project } + get :show, params: {namespace_id: project.namespace, id: project} expect(response).to render_template("projects/_customize_workflow") end - it 'shows activity if enabled by user' do - user.update_attribute(:project_view, 'activity') + it "shows activity if enabled by user" do + user.update_attribute(:project_view, "activity") - get :show, params: { namespace_id: project.namespace, id: project } + get :show, params: {namespace_id: project.namespace, id: project} expect(response).to render_template("projects/_activity") end end end - context 'when the storage is not available', :broken_storage do + context "when the storage is not available", :broken_storage do set(:project) { create(:project, :broken_storage) } before do @@ -149,8 +149,8 @@ describe ProjectsController do sign_in(user) end - it 'renders a 503' do - get :show, params: { namespace_id: project.namespace, id: project } + it "renders a 503" do + get :show, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(503) end @@ -168,11 +168,11 @@ describe ProjectsController do before do user.update(project_view: project_view) - get :show, params: { namespace_id: empty_project.namespace, id: empty_project } + get :show, params: {namespace_id: empty_project.namespace, id: empty_project} end it "renders the empty project view" do - expect(response).to render_template('empty') + expect(response).to render_template("empty") end end end @@ -190,13 +190,13 @@ describe ProjectsController do before do user.update(project_view: project_view) - get :show, params: { namespace_id: empty_project.namespace, id: empty_project } + get :show, params: {namespace_id: empty_project.namespace, id: empty_project} end it "renders the empty project view" do allow(Project).to receive(:repo).and_raise(Gitlab::Git::Repository::NoRepository) - expect(response).to render_template('projects/no_repo') + expect(response).to render_template("projects/no_repo") end end end @@ -209,60 +209,60 @@ describe ProjectsController do it "renders the activity view" do allow(controller).to receive(:current_user).and_return(user) - allow(user).to receive(:project_view).and_return('activity') + allow(user).to receive(:project_view).and_return("activity") - get :show, params: { namespace_id: public_project.namespace, id: public_project } - expect(response).to render_template('_activity') + get :show, params: {namespace_id: public_project.namespace, id: public_project} + expect(response).to render_template("_activity") end it "renders the files view" do allow(controller).to receive(:current_user).and_return(user) - allow(user).to receive(:project_view).and_return('files') + allow(user).to receive(:project_view).and_return("files") - get :show, params: { namespace_id: public_project.namespace, id: public_project } - expect(response).to render_template('_files') + get :show, params: {namespace_id: public_project.namespace, id: public_project} + expect(response).to render_template("_files") end it "renders the readme view" do allow(controller).to receive(:current_user).and_return(user) - allow(user).to receive(:project_view).and_return('readme') + allow(user).to receive(:project_view).and_return("readme") - get :show, params: { namespace_id: public_project.namespace, id: public_project } - expect(response).to render_template('_readme') + get :show, params: {namespace_id: public_project.namespace, id: public_project} + expect(response).to render_template("_readme") end end context "when the url contains .atom" do - let(:public_project_with_dot_atom) { build(:project, :public, name: 'my.atom', path: 'my.atom') } + let(:public_project_with_dot_atom) { build(:project, :public, name: "my.atom", path: "my.atom") } - it 'expects an error creating the project' do + it "expects an error creating the project" do expect(public_project_with_dot_atom).not_to be_valid end end - context 'when the project is pending deletions' do - it 'renders a 404 error' do + context "when the project is pending deletions" do + it "renders a 404 error" do project = create(:project, pending_delete: true) sign_in(user) - get :show, params: { namespace_id: project.namespace, id: project } + get :show, params: {namespace_id: project.namespace, id: project} expect(response.status).to eq 404 end end context "redirection from http://someproject.git" do - it 'redirects to project page (format.html)' do + it "redirects to project page (format.html)" do project = create(:project, :public) - get :show, params: { namespace_id: project.namespace, id: project }, format: :git + get :show, params: {namespace_id: project.namespace, id: project}, format: :git expect(response).to have_gitlab_http_status(302) expect(response).to redirect_to(namespace_project_path) end end - context 'when the project is forked and has a repository', :request_store do + context "when the project is forked and has a repository", :request_store do let(:public_project) { create(:project, :public, :repository) } let(:other_user) { create(:user) } @@ -275,25 +275,25 @@ describe ProjectsController do fork_project(public_project) end - it 'does not increase the number of queries when the project is forked' do + it "does not increase the number of queries when the project is forked" do expected_query = /#{public_project.fork_network.find_forks_in(other_user.namespace).to_sql}/ - expect { get(:show, params: { namespace_id: public_project.namespace, id: public_project }) } + expect { get(:show, params: {namespace_id: public_project.namespace, id: public_project}) } .not_to exceed_query_limit(2).for_query(expected_query) end end end - describe 'GET edit' do - it 'sets the badge API endpoint' do + describe "GET edit" do + it "sets the badge API endpoint" do sign_in(user) project.add_maintainer(user) get :edit, - params: { - namespace_id: project.namespace.path, - id: project.path - } + params: { + namespace_id: project.namespace.path, + id: project.path, + } expect(assigns(:badge_api_endpoint)).not_to be_nil end @@ -308,20 +308,20 @@ describe ProjectsController do sign_in(admin) end - shared_examples_for 'updating a project' do - context 'when only renaming a project path' do + shared_examples_for "updating a project" do + context "when only renaming a project path" do it "sets the repository to the right path after a rename" do - original_repository_path = Gitlab::GitalyClient::StorageSettings.allow_disk_access do + original_repository_path = Gitlab::GitalyClient::StorageSettings.allow_disk_access { project.repository.path - end + } - expect { update_project path: 'renamed_path' } + expect { update_project path: "renamed_path" } .to change { project.reload.path } - expect(project.path).to include 'renamed_path' + expect(project.path).to include "renamed_path" - assign_repository_path = Gitlab::GitalyClient::StorageSettings.allow_disk_access do + assign_repository_path = Gitlab::GitalyClient::StorageSettings.allow_disk_access { assigns(:repository).path - end + } if project.hashed_storage?(:repository) expect(assign_repository_path).to eq(original_repository_path) @@ -333,15 +333,15 @@ describe ProjectsController do end end - context 'when project has container repositories with tags' do + context "when project has container repositories with tags" do before do stub_container_registry_config(enabled: true) stub_container_registry_tags(repository: /image/, tags: %w[rc1]) create(:container_repository, project: project, name: :image) end - it 'does not allow to rename the project' do - expect { update_project path: 'renamed_path' } + it "does not allow to rename the project" do + expect { update_project path: "renamed_path" } .not_to change { project.reload.path } expect(controller).to set_flash.now[:alert].to(/container registry tags/) @@ -349,19 +349,19 @@ describe ProjectsController do end end - it 'updates Fast Forward Merge attributes' do + it "updates Fast Forward Merge attributes" do controller.instance_variable_set(:@project, project) params = { - merge_method: :ff + merge_method: :ff, } put :update, - params: { - namespace_id: project.namespace, - id: project.id, - project: params - } + params: { + namespace_id: project.namespace, + id: project.id, + project: params, + } expect(response).to have_gitlab_http_status(302) params.each do |param, value| @@ -371,44 +371,44 @@ describe ProjectsController do def update_project(**parameters) put :update, - params: { - namespace_id: project.namespace.path, - id: project.path, - project: parameters - } + params: { + namespace_id: project.namespace.path, + id: project.path, + project: parameters, + } end end - context 'hashed storage' do + context "hashed storage" do let(:project) { create(:project, :repository) } - it_behaves_like 'updating a project' + it_behaves_like "updating a project" end - context 'legacy storage' do + context "legacy storage" do let(:project) { create(:project, :repository, :legacy_storage) } - it_behaves_like 'updating a project' + it_behaves_like "updating a project" end end - describe '#transfer' do + describe "#transfer" do render_views let(:project) { create(:project, :repository) } let(:admin) { create(:admin) } let(:new_namespace) { create(:namespace) } - it 'updates namespace' do + it "updates namespace" do sign_in(admin) put :transfer, - params: { - namespace_id: project.namespace.path, - new_namespace_id: new_namespace.id, - id: project.path - }, - format: :js + params: { + namespace_id: project.namespace.path, + new_namespace_id: new_namespace.id, + id: project.path, + }, + format: :js project.reload @@ -416,26 +416,26 @@ describe ProjectsController do expect(response).to have_gitlab_http_status(200) end - context 'when new namespace is empty' do - it 'project namespace is not changed' do + context "when new namespace is empty" do + it "project namespace is not changed" do controller.instance_variable_set(:@project, project) sign_in(admin) old_namespace = project.namespace put :transfer, - params: { - namespace_id: old_namespace.path, - new_namespace_id: nil, - id: project.path - }, - format: :js + params: { + namespace_id: old_namespace.path, + new_namespace_id: nil, + id: project.path, + }, + format: :js project.reload expect(project.namespace).to eq(old_namespace) expect(response).to have_gitlab_http_status(200) - expect(flash[:alert]).to eq 'Please select a new namespace for your project.' + expect(flash[:alert]).to eq "Please select a new namespace for your project." end end end @@ -448,7 +448,7 @@ describe ProjectsController do sign_in(admin) orig_id = project.id - delete :destroy, params: { namespace_id: project.namespace, id: project } + delete :destroy, params: {namespace_id: project.namespace, id: project} expect { Project.find(orig_id) }.to raise_error(ActiveRecord::RecordNotFound) expect(response).to have_gitlab_http_status(302) @@ -468,20 +468,20 @@ describe ProjectsController do project.merge_requests << merge_request sign_in(admin) - delete :destroy, params: { namespace_id: forked_project.namespace, id: forked_project } + delete :destroy, params: {namespace_id: forked_project.namespace, id: forked_project} - expect(merge_request.reload.state).to eq('closed') + expect(merge_request.reload.state).to eq("closed") end end end - describe 'PUT #new_issuable_address for issue' do + describe "PUT #new_issuable_address for issue" do subject do put :new_issuable_address, params: { namespace_id: project.namespace, id: project, - issuable_type: 'issue' + issuable_type: "issue", } user.reload end @@ -492,26 +492,26 @@ describe ProjectsController do allow(Gitlab.config.incoming_email).to receive(:enabled).and_return(true) end - it 'has http status 200' do + it "has http status 200" do expect(response).to have_gitlab_http_status(200) end - it 'changes the user incoming email token' do + it "changes the user incoming email token" do expect { subject }.to change { user.incoming_email_token } end - it 'changes projects new issue address' do - expect { subject }.to change { project.new_issuable_address(user, 'issue') } + it "changes projects new issue address" do + expect { subject }.to change { project.new_issuable_address(user, "issue") } end end - describe 'PUT #new_issuable_address for merge request' do + describe "PUT #new_issuable_address for merge request" do subject do put :new_issuable_address, params: { namespace_id: project.namespace, id: project, - issuable_type: 'merge_request' + issuable_type: "merge_request", } user.reload end @@ -522,16 +522,16 @@ describe ProjectsController do allow(Gitlab.config.incoming_email).to receive(:enabled).and_return(true) end - it 'has http status 200' do + it "has http status 200" do expect(response).to have_http_status(200) end - it 'changes the user incoming email token' do + it "changes the user incoming email token" do expect { subject }.to change { user.incoming_email_token } end - it 'changes projects new merge request address' do - expect { subject }.to change { project.new_issuable_address(user, 'merge_request') } + it "changes projects new merge request address" do + expect { subject }.to change { project.new_issuable_address(user, "merge_request") } end end @@ -540,68 +540,68 @@ describe ProjectsController do sign_in(user) expect(user.starred?(public_project)).to be_falsey post(:toggle_star, - params: { - namespace_id: public_project.namespace, - id: public_project - }) + params: { + namespace_id: public_project.namespace, + id: public_project, + }) expect(user.starred?(public_project)).to be_truthy post(:toggle_star, - params: { - namespace_id: public_project.namespace, - id: public_project - }) + params: { + namespace_id: public_project.namespace, + id: public_project, + }) expect(user.starred?(public_project)).to be_falsey end it "does nothing if user is not signed in" do post(:toggle_star, - params: { - namespace_id: project.namespace, - id: public_project - }) + params: { + namespace_id: project.namespace, + id: public_project, + }) expect(user.starred?(public_project)).to be_falsey post(:toggle_star, - params: { - namespace_id: project.namespace, - id: public_project - }) + params: { + namespace_id: project.namespace, + id: public_project, + }) expect(user.starred?(public_project)).to be_falsey end end describe "DELETE remove_fork" do - context 'when signed in' do + context "when signed in" do before do sign_in(user) end - context 'with forked project' do + context "with forked project" do let(:forked_project) { fork_project(create(:project, :public), user) } - it 'removes fork from project' do + it "removes fork from project" do delete(:remove_fork, - params: { - namespace_id: forked_project.namespace.to_param, - id: forked_project.to_param - }, - format: :js) + params: { + namespace_id: forked_project.namespace.to_param, + id: forked_project.to_param, + }, + format: :js) expect(forked_project.reload.forked?).to be_falsey - expect(flash[:notice]).to eq('The fork relationship has been removed.') + expect(flash[:notice]).to eq("The fork relationship has been removed.") expect(response).to render_template(:remove_fork) end end - context 'when project not forked' do + context "when project not forked" do let(:unforked_project) { create(:project, namespace: user.namespace) } - it 'does nothing if project was not forked' do + it "does nothing if project was not forked" do delete(:remove_fork, - params: { - namespace_id: unforked_project.namespace, - id: unforked_project - }, - format: :js) + params: { + namespace_id: unforked_project.namespace, + id: unforked_project, + }, + format: :js) expect(flash[:notice]).to be_nil expect(response).to render_template(:remove_fork) @@ -611,11 +611,11 @@ describe ProjectsController do it "does nothing if user is not signed in" do delete(:remove_fork, - params: { - namespace_id: project.namespace, - id: project - }, - format: :js) + params: { + namespace_id: project.namespace, + id: project, + }, + format: :js) expect(response).to have_gitlab_http_status(401) end end @@ -623,18 +623,18 @@ describe ProjectsController do describe "GET refs" do let(:project) { create(:project, :public, :repository) } - it 'gets a list of branches and tags' do - get :refs, params: { namespace_id: project.namespace, id: project, sort: 'updated_desc' } + it "gets a list of branches and tags" do + get :refs, params: {namespace_id: project.namespace, id: project, sort: "updated_desc"} parsed_body = JSON.parse(response.body) - expect(parsed_body['Branches']).to include('master') - expect(parsed_body['Tags'].first).to eq('v1.1.0') - expect(parsed_body['Tags'].last).to eq('v1.0.0') - expect(parsed_body['Commits']).to be_nil + expect(parsed_body["Branches"]).to include("master") + expect(parsed_body["Tags"].first).to eq("v1.1.0") + expect(parsed_body["Tags"].last).to eq("v1.0.0") + expect(parsed_body["Commits"]).to be_nil end it "gets a list of branches, tags and commits" do - get :refs, params: { namespace_id: project.namespace, id: project, ref: "123456" } + get :refs, params: {namespace_id: project.namespace, id: project, ref: "123456"} parsed_body = JSON.parse(response.body) expect(parsed_body["Branches"]).to include("master") @@ -644,12 +644,12 @@ describe ProjectsController do context "when preferred language is Japanese" do before do - user.update!(preferred_language: 'ja') + user.update!(preferred_language: "ja") sign_in(user) end it "gets a list of branches, tags and commits" do - get :refs, params: { namespace_id: project.namespace, id: project, ref: "123456" } + get :refs, params: {namespace_id: project.namespace, id: project, ref: "123456"} parsed_body = JSON.parse(response.body) expect(parsed_body["Branches"]).to include("master") @@ -658,16 +658,16 @@ describe ProjectsController do end end - context 'when private project' do + context "when private project" do let(:project) { create(:project, :repository) } - context 'as a guest' do - it 'renders forbidden' do + context "as a guest" do + it "renders forbidden" do user = create(:user) project.add_guest(user) sign_in(user) - get :refs, params: { namespace_id: project.namespace, id: project } + get :refs, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(404) end @@ -675,57 +675,57 @@ describe ProjectsController do end end - describe 'POST #preview_markdown' do + describe "POST #preview_markdown" do before do sign_in(user) end - it 'renders json in a correct format' do - post :preview_markdown, params: { namespace_id: public_project.namespace, id: public_project, text: '*Markdown* text' } + it "renders json in a correct format" do + post :preview_markdown, params: {namespace_id: public_project.namespace, id: public_project, text: "*Markdown* text"} - expect(JSON.parse(response.body).keys).to match_array(%w(body references)) + expect(JSON.parse(response.body).keys).to match_array(%w[body references]) end - context 'state filter on references' do + context "state filter on references" do let(:issue) { create(:issue, :closed, project: public_project) } let(:merge_request) { create(:merge_request, :closed, target_project: public_project) } - it 'renders JSON body with state filter for issues' do + it "renders JSON body with state filter for issues" do post :preview_markdown, params: { - namespace_id: public_project.namespace, - id: public_project, - text: issue.to_reference - } + namespace_id: public_project.namespace, + id: public_project, + text: issue.to_reference, + } json_response = JSON.parse(response.body) - expect(json_response['body']).to match(/\##{issue.iid} \(closed\)/) + expect(json_response["body"]).to match(/\##{issue.iid} \(closed\)/) end - it 'renders JSON body with state filter for MRs' do + it "renders JSON body with state filter for MRs" do post :preview_markdown, params: { - namespace_id: public_project.namespace, - id: public_project, - text: merge_request.to_reference - } + namespace_id: public_project.namespace, + id: public_project, + text: merge_request.to_reference, + } json_response = JSON.parse(response.body) - expect(json_response['body']).to match(/\!#{merge_request.iid} \(closed\)/) + expect(json_response["body"]).to match(/\!#{merge_request.iid} \(closed\)/) end end end - describe '#ensure_canonical_path' do + describe "#ensure_canonical_path" do before do sign_in(user) end - context 'for a GET request' do - context 'when requesting the canonical path' do + context "for a GET request" do + context "when requesting the canonical path" do context "with exactly matching casing" do it "loads the project" do - get :show, params: { namespace_id: public_project.namespace, id: public_project } + get :show, params: {namespace_id: public_project.namespace, id: public_project} expect(assigns(:project)).to eq(public_project) expect(response).to have_gitlab_http_status(200) @@ -734,7 +734,7 @@ describe ProjectsController do context "with different casing" do it "redirects to the normalized path" do - get :show, params: { namespace_id: public_project.namespace, id: public_project.path.upcase } + get :show, params: {namespace_id: public_project.namespace, id: public_project.path.upcase} expect(assigns(:project)).to eq(public_project) expect(response).to redirect_to("/#{public_project.full_path}") @@ -743,18 +743,18 @@ describe ProjectsController do end end - context 'when requesting a redirected path' do + context "when requesting a redirected path" do let!(:redirect_route) { public_project.redirect_routes.create!(path: "foo/bar") } - it 'redirects to the canonical path' do - get :show, params: { namespace_id: 'foo', id: 'bar' } + it "redirects to the canonical path" do + get :show, params: {namespace_id: "foo", id: "bar"} expect(response).to redirect_to(public_project) expect(controller).to set_flash[:notice].to(project_moved_message(redirect_route, public_project)) end - it 'redirects to the canonical path (testing non-show action)' do - get :refs, params: { namespace_id: 'foo', id: 'bar' } + it "redirects to the canonical path (testing non-show action)" do + get :refs, params: {namespace_id: "foo", id: "bar"} expect(response).to redirect_to(refs_project_path(public_project)) expect(controller).to set_flash[:notice].to(project_moved_message(redirect_route, public_project)) @@ -762,56 +762,56 @@ describe ProjectsController do end end - context 'for a POST request' do - context 'when requesting the canonical path with different casing' do - it 'does not 404' do - post :toggle_star, params: { namespace_id: public_project.namespace, id: public_project.path.upcase } + context "for a POST request" do + context "when requesting the canonical path with different casing" do + it "does not 404" do + post :toggle_star, params: {namespace_id: public_project.namespace, id: public_project.path.upcase} expect(response).not_to have_gitlab_http_status(404) end - it 'does not redirect to the correct casing' do - post :toggle_star, params: { namespace_id: public_project.namespace, id: public_project.path.upcase } + it "does not redirect to the correct casing" do + post :toggle_star, params: {namespace_id: public_project.namespace, id: public_project.path.upcase} expect(response).not_to have_gitlab_http_status(301) end end - context 'when requesting a redirected path' do + context "when requesting a redirected path" do let!(:redirect_route) { public_project.redirect_routes.create!(path: "foo/bar") } - it 'returns not found' do - post :toggle_star, params: { namespace_id: 'foo', id: 'bar' } + it "returns not found" do + post :toggle_star, params: {namespace_id: "foo", id: "bar"} expect(response).to have_gitlab_http_status(404) end end end - context 'for a DELETE request' do + context "for a DELETE request" do before do sign_in(create(:admin)) end - context 'when requesting the canonical path with different casing' do - it 'does not 404' do - delete :destroy, params: { namespace_id: project.namespace, id: project.path.upcase } + context "when requesting the canonical path with different casing" do + it "does not 404" do + delete :destroy, params: {namespace_id: project.namespace, id: project.path.upcase} expect(response).not_to have_gitlab_http_status(404) end - it 'does not redirect to the correct casing' do - delete :destroy, params: { namespace_id: project.namespace, id: project.path.upcase } + it "does not redirect to the correct casing" do + delete :destroy, params: {namespace_id: project.namespace, id: project.path.upcase} expect(response).not_to have_gitlab_http_status(301) end end - context 'when requesting a redirected path' do + context "when requesting a redirected path" do let!(:redirect_route) { project.redirect_routes.create!(path: "foo/bar") } - it 'returns not found' do - delete :destroy, params: { namespace_id: 'foo', id: 'bar' } + it "returns not found" do + delete :destroy, params: {namespace_id: "foo", id: "bar"} expect(response).to have_gitlab_http_status(404) end @@ -819,57 +819,57 @@ describe ProjectsController do end end - describe '#export' do + describe "#export" do before do sign_in(user) project.add_maintainer(user) end - context 'when project export is enabled' do - it 'returns 302' do - get :export, params: { namespace_id: project.namespace, id: project } + context "when project export is enabled" do + it "returns 302" do + get :export, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(302) end end - context 'when project export is disabled' do + context "when project export is disabled" do before do stub_application_setting(project_export_enabled?: false) end - it 'returns 404' do - get :export, params: { namespace_id: project.namespace, id: project } + it "returns 404" do + get :export, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(404) end end end - describe '#download_export' do + describe "#download_export" do before do sign_in(user) project.add_maintainer(user) end - context 'object storage enabled' do - context 'when project export is enabled' do - it 'returns 302' do - get :download_export, params: { namespace_id: project.namespace, id: project } + context "object storage enabled" do + context "when project export is enabled" do + it "returns 302" do + get :download_export, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(302) end end - context 'when project export is disabled' do + context "when project export is disabled" do before do stub_application_setting(project_export_enabled?: false) end - it 'returns 404' do - get :download_export, params: { namespace_id: project.namespace, id: project } + it "returns 404" do + get :download_export, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(404) end @@ -877,66 +877,66 @@ describe ProjectsController do end end - describe '#remove_export' do + describe "#remove_export" do before do sign_in(user) project.add_maintainer(user) end - context 'when project export is enabled' do - it 'returns 302' do - post :remove_export, params: { namespace_id: project.namespace, id: project } + context "when project export is enabled" do + it "returns 302" do + post :remove_export, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(302) end end - context 'when project export is disabled' do + context "when project export is disabled" do before do stub_application_setting(project_export_enabled?: false) end - it 'returns 404' do - post :remove_export, params: { namespace_id: project.namespace, id: project } + it "returns 404" do + post :remove_export, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(404) end end end - describe '#generate_new_export' do + describe "#generate_new_export" do before do sign_in(user) project.add_maintainer(user) end - context 'when project export is enabled' do - it 'returns 302' do - post :generate_new_export, params: { namespace_id: project.namespace, id: project } + context "when project export is enabled" do + it "returns 302" do + post :generate_new_export, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(302) end end - context 'when project export is disabled' do + context "when project export is disabled" do before do stub_application_setting(project_export_enabled?: false) end - it 'returns 404' do - post :generate_new_export, params: { namespace_id: project.namespace, id: project } + it "returns 404" do + post :generate_new_export, params: {namespace_id: project.namespace, id: project} expect(response).to have_gitlab_http_status(404) end end end - context 'private project with token authentication' do + context "private project with token authentication" do let(:private_project) { create(:project, :private) } - it_behaves_like 'authenticates sessionless user', :show, :atom do + it_behaves_like "authenticates sessionless user", :show, :atom do before do default_params.merge!(id: private_project, namespace_id: private_project.namespace) @@ -945,63 +945,63 @@ describe ProjectsController do end end - context 'public project with token authentication' do + context "public project with token authentication" do let(:public_project) { create(:project, :public) } - it_behaves_like 'authenticates sessionless user', :show, :atom, public: true do + it_behaves_like "authenticates sessionless user", :show, :atom, public: true do before do default_params.merge!(id: public_project, namespace_id: public_project.namespace) end end end - describe 'GET resolve' do - shared_examples 'resolvable endpoint' do - it 'redirects to the project page' do - get :resolve, params: { id: project.id } + describe "GET resolve" do + shared_examples "resolvable endpoint" do + it "redirects to the project page" do + get :resolve, params: {id: project.id} expect(response).to have_gitlab_http_status(302) expect(response).to redirect_to(project_path(project)) end end - context 'with an authenticated user' do + context "with an authenticated user" do before do sign_in(user) end - context 'when user has access to the project' do + context "when user has access to the project" do before do project.add_developer(user) end - it_behaves_like 'resolvable endpoint' + it_behaves_like "resolvable endpoint" end - context 'when user has no access to the project' do - it 'gives 404 for existing project' do - get :resolve, params: { id: project.id } + context "when user has no access to the project" do + it "gives 404 for existing project" do + get :resolve, params: {id: project.id} expect(response).to have_gitlab_http_status(404) end end - it 'gives 404 for non-existing project' do - get :resolve, params: { id: '0' } + it "gives 404 for non-existing project" do + get :resolve, params: {id: "0"} expect(response).to have_gitlab_http_status(404) end end - context 'non authenticated user' do - context 'with a public project' do + context "non authenticated user" do + context "with a public project" do let(:project) { public_project } - it_behaves_like 'resolvable endpoint' + it_behaves_like "resolvable endpoint" end - it 'gives 404 for private project' do - get :resolve, params: { id: project.id } + it "gives 404 for private project" do + get :resolve, params: {id: project.id} expect(response).to have_gitlab_http_status(404) end |