Refactor plugins feature and make some doc improvements

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

1 files changed, 10 insertions, 4 deletions

diff --git a/spec/workers/plugin_worker_spec.rb b/spec/workers/plugin_worker_spec.rb
index 60631def8f3..9238a8199bc 100644
--- a/spec/workers/plugin_worker_spec.rb
+++ b/spec/workers/plugin_worker_spec.rb
@@ -3,16 +3,22 @@ require 'spec_helper'
 describe PluginWorker do
   include RepoHelpers
 
-  subject { described_class.new }
-
   let(:filename) { 'my_plugin.rb' }
+  let(:data) { { 'event_name' => 'project_create' } }
+
+  subject { described_class.new }
 
   describe '#perform' do
     it 'executes Gitlab::Plugin with expected values' do
-      data = { 'event_name' => 'project_create' }
+      allow(Gitlab::Plugin).to receive(:execute).with(filename, data).and_return([true, ''])
+
+      expect(subject.perform(filename, data)).to be_truthy
+    end
 
-      allow(Gitlab::Plugin).to receive(:execute).with(filename, data).and_return(true)
+    it 'logs message in case of plugin execution failure' do
+      allow(Gitlab::Plugin).to receive(:execute).with(filename, data).and_return([false, 'permission denied'])
 
+      expect(Gitlab::PluginLogger).to receive(:error)
       expect(subject.perform(filename, data)).to be_truthy
     end
   end