Fix Project#to_param to keep invalid project suitable for use in URLsfix-19538

1 files changed, 0 insertions, 21 deletions

diff --git a/spec/services/projects/update_service_spec.rb b/spec/services/projects/update_service_spec.rb
index 6337daca9c7..e8b9e6b9238 100644
--- a/spec/services/projects/update_service_spec.rb
+++ b/spec/services/projects/update_service_spec.rb
@@ -139,27 +139,6 @@ describe Projects::UpdateService, services: true do
     end
   end
 
-  context 'for invalid project path/name' do
-    let(:user) { create(:user, admin: true) }
-    let(:project) { create(:empty_project, path: 'gitlab', name: 'sample') }
-    let(:params) { { path: 'foo&bar', name: 'foo&bar' } }
-
-    it 'resets to previous values to keep project in a valid state' do
-      update_project(project, user, params)
-
-      expect(project.path).to eq 'gitlab'
-      expect(project.name).to eq 'sample'
-    end
-
-    it 'keeps error messages' do
-      update_project(project, user, params)
-
-      expect(project.errors).not_to be_blank
-      expect(project.errors[:name]).to include("can contain only letters, digits, '_', '.', dash and space. It must start with letter, digit or '_'.")
-      expect(project.errors[:path]).to include("can contain only letters, digits, '_', '-' and '.'. Cannot start with '-', end in '.git' or end in '.atom'")
-    end
-  end
-
   def update_project(project, user, opts)
     Projects::UpdateService.new(project, user, opts).execute
   end