diff options
author | Valery Sizov <valery@gitlab.com> | 2016-10-19 15:25:37 +0300 |
---|---|---|
committer | Valery Sizov <valery@gitlab.com> | 2016-11-01 14:46:59 +0200 |
commit | a6ba358a8fe5a965a46ca07c8c0382348b2b8d8c (patch) | |
tree | a1ac8c2fe33e9a618a347e890ed9ab6a0cf4bbba /spec/requests/api/merge_requests_spec.rb | |
parent | 957308af84ca8312ea362c7272a4008dac808086 (diff) | |
download | gitlab-ce-spec_optimization.tar.gz |
Make specs a bit fasterspec_optimization
Diffstat (limited to 'spec/requests/api/merge_requests_spec.rb')
-rw-r--r-- | spec/requests/api/merge_requests_spec.rb | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/spec/requests/api/merge_requests_spec.rb b/spec/requests/api/merge_requests_spec.rb index b813ee967f8..bae4fa11ec2 100644 --- a/spec/requests/api/merge_requests_spec.rb +++ b/spec/requests/api/merge_requests_spec.rb @@ -186,14 +186,14 @@ describe API::API, api: true do end describe 'GET /projects/:id/merge_requests/:merge_request_id/commits' do - context 'valid merge request' do - before { get api("/projects/#{project.id}/merge_requests/#{merge_request.id}/commits", user) } - let(:commit) { merge_request.commits.first } - - it { expect(response.status).to eq 200 } - it { expect(json_response.size).to eq(merge_request.commits.size) } - it { expect(json_response.first['id']).to eq(commit.id) } - it { expect(json_response.first['title']).to eq(commit.title) } + it 'returns a 200 when merge request is valid' do + get api("/projects/#{project.id}/merge_requests/#{merge_request.id}/commits", user) + commit = merge_request.commits.first + + expect(response.status).to eq 200 + expect(json_response.size).to eq(merge_request.commits.size) + expect(json_response.first['id']).to eq(commit.id) + expect(json_response.first['title']).to eq(commit.title) end it 'returns a 404 when merge_request_id not found' do |