Merge pull request #8785 from jvanbaarsen/rspec-upgrade

Rspec upgrade

1 files changed, 22 insertions, 22 deletions

diff --git a/spec/requests/api/group_members_spec.rb b/spec/requests/api/group_members_spec.rb
index 43d26d67efe..8ba6876a95b 100644
--- a/spec/requests/api/group_members_spec.rb
+++ b/spec/requests/api/group_members_spec.rb
@@ -31,20 +31,20 @@ describe API::API, api: true  do
       it "each user: should return an array of members groups of group3" do
         [owner, master, developer, reporter, guest].each do |user|
           get api("/groups/#{group_with_members.id}/members", user)
-          response.status.should == 200
-          json_response.should be_an Array
-          json_response.size.should == 5
-          json_response.find { |e| e['id']==owner.id }['access_level'].should == GroupMember::OWNER
-          json_response.find { |e| e['id']==reporter.id }['access_level'].should == GroupMember::REPORTER
-          json_response.find { |e| e['id']==developer.id }['access_level'].should == GroupMember::DEVELOPER
-          json_response.find { |e| e['id']==master.id }['access_level'].should == GroupMember::MASTER
-          json_response.find { |e| e['id']==guest.id }['access_level'].should == GroupMember::GUEST
+          expect(response.status).to eq(200)
+          expect(json_response).to be_an Array
+          expect(json_response.size).to eq(5)
+          expect(json_response.find { |e| e['id']==owner.id }['access_level']).to eq(GroupMember::OWNER)
+          expect(json_response.find { |e| e['id']==reporter.id }['access_level']).to eq(GroupMember::REPORTER)
+          expect(json_response.find { |e| e['id']==developer.id }['access_level']).to eq(GroupMember::DEVELOPER)
+          expect(json_response.find { |e| e['id']==master.id }['access_level']).to eq(GroupMember::MASTER)
+          expect(json_response.find { |e| e['id']==guest.id }['access_level']).to eq(GroupMember::GUEST)
         end
       end
 
       it "users not part of the group should get access error" do
         get api("/groups/#{group_with_members.id}/members", stranger)
-        response.status.should == 403
+        expect(response.status).to eq(403)
       end
     end
   end
@@ -53,7 +53,7 @@ describe API::API, api: true  do
     context "when not a member of the group" do
       it "should not add guest as member of group_no_members when adding being done by person outside the group" do
         post api("/groups/#{group_no_members.id}/members", reporter), user_id: guest.id, access_level: GroupMember::MASTER
-        response.status.should == 403
+        expect(response.status).to eq(403)
       end
     end
 
@@ -66,9 +66,9 @@ describe API::API, api: true  do
           user_id: new_user.id, access_level: GroupMember::MASTER
         }.to change { group_no_members.members.count }.by(1)
 
-        response.status.should == 201
-        json_response['name'].should == new_user.name
-        json_response['access_level'].should == GroupMember::MASTER
+        expect(response.status).to eq(201)
+        expect(json_response['name']).to eq(new_user.name)
+        expect(json_response['access_level']).to eq(GroupMember::MASTER)
       end
 
       it "should not allow guest to modify group members" do
@@ -79,27 +79,27 @@ describe API::API, api: true  do
           user_id: new_user.id, access_level: GroupMember::MASTER
         }.not_to change { group_with_members.members.count }
 
-        response.status.should == 403
+        expect(response.status).to eq(403)
       end
 
       it "should return error if member already exists" do
         post api("/groups/#{group_with_members.id}/members", owner), user_id: master.id, access_level: GroupMember::MASTER
-        response.status.should == 409
+        expect(response.status).to eq(409)
       end
 
       it "should return a 400 error when user id is not given" do
         post api("/groups/#{group_no_members.id}/members", owner), access_level: GroupMember::MASTER
-        response.status.should == 400
+        expect(response.status).to eq(400)
       end
 
       it "should return a 400 error when access level is not given" do
         post api("/groups/#{group_no_members.id}/members", owner), user_id: master.id
-        response.status.should == 400
+        expect(response.status).to eq(400)
       end
 
       it "should return a 422 error when access level is not known" do
         post api("/groups/#{group_no_members.id}/members", owner), user_id: master.id, access_level: 1234
-        response.status.should == 422
+        expect(response.status).to eq(422)
       end
     end
   end
@@ -172,7 +172,7 @@ describe API::API, api: true  do
       it "should not delete guest's membership of group_with_members" do
         random_user = create(:user)
         delete api("/groups/#{group_with_members.id}/members/#{owner.id}", random_user)
-        response.status.should == 403
+        expect(response.status).to eq(403)
       end
     end
 
@@ -182,17 +182,17 @@ describe API::API, api: true  do
           delete api("/groups/#{group_with_members.id}/members/#{guest.id}", owner)
         }.to change { group_with_members.members.count }.by(-1)
 
-        response.status.should == 200
+        expect(response.status).to eq(200)
       end
 
       it "should return a 404 error when user id is not known" do
         delete api("/groups/#{group_with_members.id}/members/1328", owner)
-        response.status.should == 404
+        expect(response.status).to eq(404)
       end
 
       it "should not allow guest to modify group members" do
         delete api("/groups/#{group_with_members.id}/members/#{master.id}", guest)
-        response.status.should == 403
+        expect(response.status).to eq(403)
       end
     end
   end