diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-12-02 13:54:57 +0100 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-12-06 10:23:17 +0100 |
| commit | 4e249d5baea99a52915025fc2827d01ab2d77c18 (patch) | |
| tree | 98a0eaa592fdb17657e10a6cd9fe941b17c0253d /spec/models/environment_spec.rb | |
| parent | 90c0f610e29976608dbfeeb63bc4763982c5dbc3 (diff) | |
| download | gitlab-ce-25209-improve-length-validators.tar.gz | |
Use :maximum instead of :within for length validators with a 0..N range25209-improve-length-validators
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec/models/environment_spec.rb')
| -rw-r--r-- | spec/models/environment_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/models/environment_spec.rb b/spec/models/environment_spec.rb index d06665197db..c8170164898 100644 --- a/spec/models/environment_spec.rb +++ b/spec/models/environment_spec.rb @@ -13,9 +13,9 @@ describe Environment, models: true do it { is_expected.to validate_presence_of(:name) } it { is_expected.to validate_uniqueness_of(:name).scoped_to(:project_id) } - it { is_expected.to validate_length_of(:name).is_within(0..255) } + it { is_expected.to validate_length_of(:name).is_at_most(255) } - it { is_expected.to validate_length_of(:external_url).is_within(0..255) } + it { is_expected.to validate_length_of(:external_url).is_at_most(255) } # To circumvent a not null violation of the name column: # https://github.com/thoughtbot/shoulda-matchers/issues/336 |