diff options
author | Kamil Trzciński <ayufan@ayufan.eu> | 2018-11-14 18:55:38 +0100 |
---|---|---|
committer | Kamil Trzciński <ayufan@ayufan.eu> | 2018-11-19 14:09:39 +0100 |
commit | c3bd3bfc6e1990f4774bcd678deef1eb202a2680 (patch) | |
tree | 89d59fa8513716b5b00a49a293752c9f7533e869 /spec/models/clusters | |
parent | 321506c7431788e23e12a196ee1b77c0af2ea5f6 (diff) | |
download | gitlab-ce-improve-variables-support.tar.gz |
Improve variables supportimprove-variables-support
This ensures that variables accept only string,
alongside also improves kubernetes_namespace,
improving validation and default value being set.
Diffstat (limited to 'spec/models/clusters')
-rw-r--r-- | spec/models/clusters/kubernetes_namespace_spec.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/spec/models/clusters/kubernetes_namespace_spec.rb b/spec/models/clusters/kubernetes_namespace_spec.rb index c068c4d7739..56c98d016c9 100644 --- a/spec/models/clusters/kubernetes_namespace_spec.rb +++ b/spec/models/clusters/kubernetes_namespace_spec.rb @@ -45,14 +45,14 @@ RSpec.describe Clusters::KubernetesNamespace, type: :model do end end - describe '#configure_predefined_variables' do + describe '#set_defaults' do let(:kubernetes_namespace) { build(:cluster_kubernetes_namespace) } let(:cluster) { kubernetes_namespace.cluster } let(:platform) { kubernetes_namespace.platform_kubernetes } - subject { kubernetes_namespace.configure_predefined_credentials } + subject { kubernetes_namespace.set_defaults } - describe 'namespace' do + describe '#namespace' do before do platform.update_column(:namespace, namespace) end @@ -80,7 +80,7 @@ RSpec.describe Clusters::KubernetesNamespace, type: :model do end end - describe 'service_account_name' do + describe '#service_account_name' do let(:service_account_name) { "#{kubernetes_namespace.namespace}-service-account" } it 'should set a service account name based on namespace' do |