diff options
author | Kamil Trzciński <ayufan@ayufan.eu> | 2018-11-14 18:55:38 +0100 |
---|---|---|
committer | Kamil Trzciński <ayufan@ayufan.eu> | 2018-11-19 14:09:39 +0100 |
commit | c3bd3bfc6e1990f4774bcd678deef1eb202a2680 (patch) | |
tree | 89d59fa8513716b5b00a49a293752c9f7533e869 /spec/lib | |
parent | 321506c7431788e23e12a196ee1b77c0af2ea5f6 (diff) | |
download | gitlab-ce-improve-variables-support.tar.gz |
Improve variables supportimprove-variables-support
This ensures that variables accept only string,
alongside also improves kubernetes_namespace,
improving validation and default value being set.
Diffstat (limited to 'spec/lib')
-rw-r--r-- | spec/lib/gitlab/ci/variables/collection/item_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/lib/gitlab/ci/variables/collection/item_spec.rb b/spec/lib/gitlab/ci/variables/collection/item_spec.rb index 46874662edd..e1e0582cd11 100644 --- a/spec/lib/gitlab/ci/variables/collection/item_spec.rb +++ b/spec/lib/gitlab/ci/variables/collection/item_spec.rb @@ -36,7 +36,7 @@ describe Gitlab::Ci::Variables::Collection::Item do shared_examples 'raises error for invalid type' do it do expect { described_class.new(key: variable_key, value: variable_value) } - .to raise_error ArgumentError, /`value` must be of type String, while it was:/ + .to raise_error ArgumentError, /`#{variable_key}` must be of type String, while it was:/ end end @@ -46,7 +46,7 @@ describe Gitlab::Ci::Variables::Collection::Item do let(:variable_value) { nil } let(:expected_value) { nil } - it_behaves_like 'creates variable' + it_behaves_like 'raises error for invalid type' end context "when it's an empty string" do |