Made diff & note data consistent

This caused many pain points when working with it.
Part of the data was camel cased the other snake case.
Other parts where snake case & then getting converted in components,
this conversion has the potential for leaking memory.

This changes that & makes it consistent with what it returned from the
API, snake case.

1 files changed, 8 insertions, 8 deletions

diff --git a/spec/javascripts/diffs/components/diff_file_spec.js b/spec/javascripts/diffs/components/diff_file_spec.js
index 431944eee96..51bb4807960 100644
--- a/spec/javascripts/diffs/components/diff_file_spec.js
+++ b/spec/javascripts/diffs/components/diff_file_spec.js
@@ -17,14 +17,14 @@ describe('DiffFile', () => {
   describe('template', () => {
     it('should render component with file header, file content components', () => {
       const el = vm.$el;
-      const { fileHash, filePath } = vm.file;
+      const { file_hash, file_path } = vm.file;
 
-      expect(el.id).toEqual(fileHash);
+      expect(el.id).toEqual(file_hash);
       expect(el.classList.contains('diff-file')).toEqual(true);
 
       expect(el.querySelectorAll('.diff-content.hidden').length).toEqual(0);
       expect(el.querySelector('.js-file-title')).toBeDefined();
-      expect(el.querySelector('.file-title-name').innerText.indexOf(filePath)).toBeGreaterThan(-1);
+      expect(el.querySelector('.file-title-name').innerText.indexOf(file_path)).toBeGreaterThan(-1);
       expect(el.querySelector('.js-syntax-highlight')).toBeDefined();
 
       expect(vm.file.renderIt).toEqual(false);
@@ -52,7 +52,7 @@ describe('DiffFile', () => {
       it('should have collapsed text and link', done => {
         vm.file.renderIt = true;
         vm.file.collapsed = false;
-        vm.file.highlightedDiffLines = null;
+        vm.file.highlighted_diff_lines = null;
 
         vm.$nextTick(() => {
           expect(vm.$el.innerText).toContain('This diff is collapsed');
@@ -90,8 +90,8 @@ describe('DiffFile', () => {
   describe('too large diff', () => {
     it('should have too large warning and blob link', done => {
       const BLOB_LINK = '/file/view/path';
-      vm.file.tooLarge = true;
-      vm.file.viewPath = BLOB_LINK;
+      vm.file.too_large = true;
+      vm.file.view_path = BLOB_LINK;
 
       vm.$nextTick(() => {
         expect(vm.$el.innerText).toContain(
@@ -112,8 +112,8 @@ describe('DiffFile', () => {
     it('calls handleLoadCollapsedDiff if collapsed changed & file has no lines', done => {
       spyOn(vm, 'handleLoadCollapsedDiff');
 
-      vm.file.highlightedDiffLines = undefined;
-      vm.file.parallelDiffLines = [];
+      vm.file.highlighted_diff_lines = undefined;
+      vm.file.parallel_diff_lines = [];
       vm.file.collapsed = true;
 
       vm.$nextTick()