diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-07-02 20:23:55 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-07-02 20:33:02 -0700 |
| commit | 645c7f9631dc73035ef868977c56ca8f7f5529fc (patch) | |
| tree | c86557bf38e6fb62fe4bf2d083119481494755e3 /spec/frontend/lib/utils/text_utility_spec.js | |
| parent | 4aa98d31e51ea0f7debdbc160b828a4d3d242884 (diff) | |
| download | gitlab-ce-645c7f9631dc73035ef868977c56ca8f7f5529fc.tar.gz | |
Fix order-dependent Gitaly specs failingsh-fix-gitaly-specs-failing
If `spec/tasks/gitlab/cleanup_rake_spec.rb` preceded any of the Gitaly
request specs, it would import the `cleanup.rake` and the global
function `limit`. For some reason, the Protobuf implementation would use
the global function instead of the getter method. For example:
```
def limit
puts "hi"
end
req = Gitaly::WikiGetAllPagesRequest.new
req.send(:limit)
hi
=> nil
```
To fix this problem, access the field value using the [] operator
instead.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64006
Diffstat (limited to 'spec/frontend/lib/utils/text_utility_spec.js')
0 files changed, 0 insertions, 0 deletions
