diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2015-12-30 18:16:53 +0100 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2015-12-31 15:46:47 +0100 |
| commit | 054df415f94abe1e517a729e53cdb325d592d31b (patch) | |
| tree | b7e5d560e39f05fdae0e5ee0ba654739eab59094 /lib/banzai/querying.rb | |
| parent | d3951dfaa13b9aaf11695ef10fa63456ac75cc48 (diff) | |
| download | gitlab-ce-autocomplete-performance.tar.gz | |
Optimize CSS expressions produced by Nokogiriautocomplete-performance
Nokogiri produces inefficient XPath expressions when given CSS
expressions such as "a.gfm". Luckily these expressions can be optimized
quite easily while still achieving the same results.
In the two cases where this optimization is applied the run time has
been reduced from around 170 ms to around 15 ms.
Diffstat (limited to 'lib/banzai/querying.rb')
| -rw-r--r-- | lib/banzai/querying.rb | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/lib/banzai/querying.rb b/lib/banzai/querying.rb new file mode 100644 index 00000000000..1e1b51e683e --- /dev/null +++ b/lib/banzai/querying.rb @@ -0,0 +1,18 @@ +module Banzai + module Querying + # Searches a Nokogiri document using a CSS query, optionally optimizing it + # whenever possible. + # + # document - A document/element to search. + # query - The CSS query to use. + # + # Returns a Nokogiri::XML::NodeSet. + def self.css(document, query) + # When using "a.foo" Nokogiri compiles this to "//a[...]" but + # "descendant::a[...]" is quite a bit faster and achieves the same result. + xpath = Nokogiri::CSS.xpath_for(query)[0].gsub(%r{^//}, 'descendant::') + + document.xpath(xpath) + end + end +end |