Ran standardrb --fix on the whole codebasetc-standard-gem

Inspired by https://twitter.com/searls/status/1101137953743613952 I
decided to try https://github.com/testdouble/standard on our codebase.

It's opinionated, but at least it's a _standard_.

1 files changed, 24 insertions, 26 deletions

diff --git a/lib/api/project_milestones.rb b/lib/api/project_milestones.rb
index ca24742b7a3..8a31cf1d6f5 100644
--- a/lib/api/project_milestones.rb
+++ b/lib/api/project_milestones.rb
@@ -10,10 +10,10 @@ module API
     end
 
     params do
-      requires :id, type: String, desc: 'The ID of a project'
+      requires :id, type: String, desc: "The ID of a project"
     end
     resource :projects, requirements: API::NAMESPACE_OR_PROJECT_REQUIREMENTS do
-      desc 'Get a list of project milestones' do
+      desc "Get a list of project milestones" do
         success Entities::Milestone
       end
       params do
@@ -25,11 +25,11 @@ module API
         list_milestones_for(user_project)
       end
 
-      desc 'Get a single project milestone' do
+      desc "Get a single project milestone" do
         success Entities::Milestone
       end
       params do
-        requires :milestone_id, type: Integer, desc: 'The ID of a project milestone'
+        requires :milestone_id, type: Integer, desc: "The ID of a project milestone"
       end
       get ":id/milestones/:milestone_id" do
         authorize! :read_milestone, user_project
@@ -37,11 +37,11 @@ module API
         get_milestone_for(user_project)
       end
 
-      desc 'Create a new project milestone' do
+      desc "Create a new project milestone" do
         success Entities::Milestone
       end
       params do
-        requires :title, type: String, desc: 'The title of the milestone'
+        requires :title, type: String, desc: "The title of the milestone"
         use :optional_params
       end
       post ":id/milestones" do
@@ -50,7 +50,7 @@ module API
         create_milestone_for(user_project)
       end
 
-      desc 'Update an existing project milestone' do
+      desc "Update an existing project milestone" do
         success Entities::Milestone
       end
       params do
@@ -62,7 +62,7 @@ module API
         update_milestone_for(user_project)
       end
 
-      desc 'Remove a project milestone'
+      desc "Remove a project milestone"
       delete ":id/milestones/:milestone_id" do
         authorize! :admin_milestone, user_project
 
@@ -72,11 +72,11 @@ module API
         status(204)
       end
 
-      desc 'Get all issues for a single project milestone' do
+      desc "Get all issues for a single project milestone" do
         success Entities::IssueBasic
       end
       params do
-        requires :milestone_id, type: Integer, desc: 'The ID of a project milestone'
+        requires :milestone_id, type: Integer, desc: "The ID of a project milestone"
         use :pagination
       end
       get ":id/milestones/:milestone_id/issues" do
@@ -85,35 +85,33 @@ module API
         milestone_issuables_for(user_project, :issue)
       end
 
-      desc 'Get all merge requests for a single project milestone' do
-        detail 'This feature was introduced in GitLab 9.'
+      desc "Get all merge requests for a single project milestone" do
+        detail "This feature was introduced in GitLab 9."
         success Entities::MergeRequestBasic
       end
       params do
-        requires :milestone_id, type: Integer, desc: 'The ID of a project milestone'
+        requires :milestone_id, type: Integer, desc: "The ID of a project milestone"
         use :pagination
       end
-      get ':id/milestones/:milestone_id/merge_requests' do
+      get ":id/milestones/:milestone_id/merge_requests" do
         authorize! :read_milestone, user_project
 
         milestone_issuables_for(user_project, :merge_request)
       end
 
-      desc 'Promote a milestone to group milestone' do
-        detail 'This feature was introduced in GitLab 11.9'
+      desc "Promote a milestone to group milestone" do
+        detail "This feature was introduced in GitLab 11.9"
       end
-      post ':id/milestones/:milestone_id/promote' do
-        begin
-          authorize! :admin_milestone, user_project
-          authorize! :admin_milestone, user_project.group
+      post ":id/milestones/:milestone_id/promote" do
+        authorize! :admin_milestone, user_project
+        authorize! :admin_milestone, user_project.group
 
-          milestone = user_project.milestones.find(params[:milestone_id])
-          Milestones::PromoteService.new(user_project, current_user).execute(milestone)
+        milestone = user_project.milestones.find(params[:milestone_id])
+        Milestones::PromoteService.new(user_project, current_user).execute(milestone)
 
-          status(200)
-        rescue Milestones::PromoteService::PromoteMilestoneError => error
-          render_api_error!(error.message, 400)
-        end
+        status(200)
+      rescue Milestones::PromoteService::PromoteMilestoneError => error
+        render_api_error!(error.message, 400)
       end
     end
   end