Instrument private/protected methods18527-instrument-private-methods

By default instrumentation will instrument public, 
protected and private methods, because usually 
heavy work is done on private method or at least 
that’s what facts is showing

1 files changed, 2 insertions, 4 deletions

diff --git a/doc/development/instrumentation.md b/doc/development/instrumentation.md
index 9168c70945a..0b375917061 100644
--- a/doc/development/instrumentation.md
+++ b/doc/development/instrumentation.md
@@ -15,8 +15,8 @@ instrument code:
 * `instrument_instance_method`: instruments a single instance method.
 * `instrument_class_hierarchy`: given a Class this method will recursively
   instrument all sub-classes (both class and instance methods).
-* `instrument_methods`: instruments all public class methods of a Module.
-* `instrument_instance_methods`: instruments all public instance methods of a
+* `instrument_methods`: instruments all public and private class methods of a Module.
+* `instrument_instance_methods`: instruments all public and private instance methods of a
   Module.
 
 To remove the need for typing the full `Gitlab::Metrics::Instrumentation`
@@ -102,8 +102,6 @@ def #{name}(#{args_signature})
     duration = (Time.now - start) * 1000.0
 
     if duration >= Gitlab::Metrics.method_call_threshold
-      trans.increment(:method_duration, duration)
-
       trans.add_metric(Gitlab::Metrics::Instrumentation::SERIES,
                        { duration: duration },
                        method: #{label.inspect})