diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-02-10 00:11:55 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-02-10 00:11:55 +0000 |
commit | 3f22924df411018ba665ecf72ab0768d61173477 (patch) | |
tree | 511da0ef74e33f241ecc50d50c7a57a1ac51a06f /doc/development/contributing | |
parent | d183d2d76bcc25f983c0836805c712af096bcc2f (diff) | |
download | gitlab-ce-3f22924df411018ba665ecf72ab0768d61173477.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/contributing')
-rw-r--r-- | doc/development/contributing/index.md | 46 | ||||
-rw-r--r-- | doc/development/contributing/merge_request_workflow.md | 19 |
2 files changed, 20 insertions, 45 deletions
diff --git a/doc/development/contributing/index.md b/doc/development/contributing/index.md index 5feabf2bd18..b3d79bec9be 100644 --- a/doc/development/contributing/index.md +++ b/doc/development/contributing/index.md @@ -28,40 +28,9 @@ Throughout this guide you will see references to CE and EE for abbreviation. We want to create a welcoming environment for everyone who is interested in contributing. Visit our [Code of Conduct page](https://about.gitlab.com/community/contribute/code-of-conduct/) to learn more about our commitment to an open and welcoming environment. -## Closing policy for issues and merge requests - -GitLab is a popular open source project and the capacity to deal with issues -and merge requests is limited. Out of respect for our volunteers, issues and -merge requests not in line with the guidelines listed in this document may be -closed without notice. - -Treat our volunteers with courtesy and respect, it will go a long way -towards getting your issue resolved. - Issues and merge requests should be in English and contain appropriate language for audiences of all ages. -If a contributor is no longer actively working on a submitted merge request, -we can: - -- Decide that the merge request will be finished by one of our - [Merge request coaches](https://about.gitlab.com/company/team/). -- Close the merge request. - -We make this decision based on how important the change is for our product vision. If a merge -request coach is going to finish the merge request, we assign the -`~coach will finish` label. - -When a team member picks up a community contribution, -we credit the original author by adding a changelog entry crediting the author -and optionally include the original author on at least one of the commits -within the MR. - -## Closing policy for inactive bugs - -GitLab values the time spent by contributors on reporting bugs. However, if a bug remains inactive for a very long period, -it will qualify for auto-closure. Please refer to the [auto-close inactive bugs](https://about.gitlab.com/handbook/engineering/quality/triage-operations/#auto-close-inactive-bugs) section in our handbook to understand the complete workflow. - ## How to contribute If you would like to contribute to GitLab: @@ -173,19 +142,10 @@ This [documentation](merge_request_workflow.md) outlines the current merge reque - [Definition of done](merge_request_workflow.md#definition-of-done) - [Dependencies](merge_request_workflow.md#dependencies) -## Style guides - -This [documentation](style_guides.md) outlines the current style guidelines. - -## Implement design & UI elements - -This [design documentation](design.md) outlines the current process for implementing design and UI -elements. - -## Contribute documentation +## Closing policy for issues and merge requests -For information on how to contribute documentation, see GitLab -[documentation guidelines](../documentation/index.md). +- For the criteria for closing issues, see [the Issue Triage handbook page](https://about.gitlab.com/handbook/engineering/quality/issue-triage/#outdated-issues). +- For the criteria for closing merge requests, see [the Merge Request Workflow](merge_request_workflow.md). ## Getting an Enterprise Edition License diff --git a/doc/development/contributing/merge_request_workflow.md b/doc/development/contributing/merge_request_workflow.md index 20127304bbe..680cc06d792 100644 --- a/doc/development/contributing/merge_request_workflow.md +++ b/doc/development/contributing/merge_request_workflow.md @@ -13,8 +13,23 @@ for community contributions have the [`Seeking community contributions`](issue_w label, but you are free to contribute to any issue you want. If an issue is marked for the current milestone at any time, even -when you are working on it, a GitLab Inc. team member may take over the merge request -to ensure the work is finished before the release date. +when you are working on it, a GitLab team member may take over the merge request to ensure the work is finished before the release date. + +If a contributor is no longer actively working on a submitted merge request, +we can: + +- Decide that the merge request will be finished by one of our + [Merge request coaches](https://about.gitlab.com/company/team/). +- Close the merge request. + +We make this decision based on how important the change is for our product vision. If a merge +request coach is going to finish the merge request, we assign the +`~coach will finish` label. + +When a team member picks up a community contribution, +we credit the original author by adding a changelog entry crediting the author +and optionally include the original author on at least one of the commits +within the MR. If you want to add a new feature that is not labeled, it is best to first create an issue (if there isn't one already) and leave a comment asking for it |