summaryrefslogtreecommitdiff
path: root/app/services/packages
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2022-08-19 18:10:17 +0000
committerGitLab Bot <gitlab-bot@gitlab.com>2022-08-19 18:10:17 +0000
commitf5e42f97372d5bfe06291698d25e0f9e68b61819 (patch)
tree4b6e8dcd1ad901dfc2d1ae2252f6a5623e32d44e /app/services/packages
parent4c083c816333ef903fe7c32f412eaa53d7b959d3 (diff)
downloadgitlab-ce-f5e42f97372d5bfe06291698d25e0f9e68b61819.tar.gz
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'app/services/packages')
-rw-r--r--app/services/packages/conan/search_service.rb2
-rw-r--r--app/services/packages/rubygems/dependency_resolver_service.rb5
2 files changed, 5 insertions, 2 deletions
diff --git a/app/services/packages/conan/search_service.rb b/app/services/packages/conan/search_service.rb
index 31ee9bea084..df22a895c00 100644
--- a/app/services/packages/conan/search_service.rb
+++ b/app/services/packages/conan/search_service.rb
@@ -44,7 +44,7 @@ module Packages
name, version, username, _ = query.split(%r{[@/]})
full_path = Packages::Conan::Metadatum.full_path_from(package_username: username)
project = Project.find_by_full_path(full_path)
- return unless Ability.allowed?(current_user, :read_package, project)
+ return unless Ability.allowed?(current_user, :read_package, project&.packages_policy_subject)
result = project.packages.with_name(name).with_version(version).order_created.last
[result&.conan_recipe].compact
diff --git a/app/services/packages/rubygems/dependency_resolver_service.rb b/app/services/packages/rubygems/dependency_resolver_service.rb
index c44b26e2b92..839a7683632 100644
--- a/app/services/packages/rubygems/dependency_resolver_service.rb
+++ b/app/services/packages/rubygems/dependency_resolver_service.rb
@@ -8,7 +8,10 @@ module Packages
DEFAULT_PLATFORM = 'ruby'
def execute
- return ServiceResponse.error(message: "forbidden", http_status: :forbidden) unless Ability.allowed?(current_user, :read_package, project)
+ unless Ability.allowed?(current_user, :read_package, project&.packages_policy_subject)
+ return ServiceResponse.error(message: "forbidden", http_status: :forbidden)
+ end
+
return ServiceResponse.error(message: "#{gem_name} not found", http_status: :not_found) if packages.empty?
payload = packages.map do |package|