summaryrefslogtreecommitdiff
path: root/app/models
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2021-04-08 18:09:32 +0000
committerGitLab Bot <gitlab-bot@gitlab.com>2021-04-08 18:09:32 +0000
commit383ec6808b2e5385ccdc0ff7fef8f537635f9bff (patch)
tree93977ed73841bf36c8f07020f0d2dfab74162a02 /app/models
parent7a4a8bd5abf6ed6519f252abd79e5f528b8d29d6 (diff)
downloadgitlab-ce-383ec6808b2e5385ccdc0ff7fef8f537635f9bff.tar.gz
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'app/models')
-rw-r--r--app/models/concerns/milestoneish.rb4
-rw-r--r--app/models/project_services/emails_on_push_service.rb2
2 files changed, 5 insertions, 1 deletions
diff --git a/app/models/concerns/milestoneish.rb b/app/models/concerns/milestoneish.rb
index 5f24564dc56..8f7e6041d4b 100644
--- a/app/models/concerns/milestoneish.rb
+++ b/app/models/concerns/milestoneish.rb
@@ -15,6 +15,10 @@ module Milestoneish
total_issues_count - closed_issues_count
end
+ def total_merge_requests_count
+ @total_merge_request_count ||= Milestones::MergeRequestsCountService.new(self).count
+ end
+
def complete?
total_issues_count > 0 && total_issues_count == closed_issues_count
end
diff --git a/app/models/project_services/emails_on_push_service.rb b/app/models/project_services/emails_on_push_service.rb
index a7437608c1e..cdb69684d16 100644
--- a/app/models/project_services/emails_on_push_service.rb
+++ b/app/models/project_services/emails_on_push_service.rb
@@ -72,7 +72,7 @@ class EmailsOnPushService < Service
domains = Notify.allowed_email_domains.map { |domain| "user@#{domain}" }.join(", ")
[
{ type: 'checkbox', name: 'send_from_committer_email', title: s_("EmailsOnPushService|Send from committer"),
- help: s_("EmailsOnPushService|Send notifications from the committer's email address if the domain is part of the domain GitLab is running on (e.g. %{domains}).") % { domains: domains } },
+ help: s_("EmailsOnPushService|Send notifications from the committer's email address if the domain matches the domain used by your GitLab instance (such as %{domains}).") % { domains: domains } },
{ type: 'checkbox', name: 'disable_diffs', title: s_("EmailsOnPushService|Disable code diffs"),
help: s_("EmailsOnPushService|Don't include possibly sensitive code diffs in notification body.") },
{ type: 'select', name: 'branches_to_be_notified', choices: branch_choices },