diff options
| author | Mayra Cabrera <mcabrera@gitlab.com> | 2019-01-31 08:58:58 -0600 |
|---|---|---|
| committer | Mayra Cabrera <mcabrera@gitlab.com> | 2019-02-04 12:08:09 -0600 |
| commit | 087af654bbae1e4a843029b33e1aab546f4d7d61 (patch) | |
| tree | 9230a20b2eb5deecd93d431bf30489d714887c20 /app/models/project_auto_devops.rb | |
| parent | 8b5553daa43d48fdef42f0f2a3f700580dea770b (diff) | |
| download | gitlab-ce-087af654bbae1e4a843029b33e1aab546f4d7d61.tar.gz | |
Addresses backend/db review comments
- Fixes multiple typos on AutoDevops script
- Add an alias to Clusters::Cluster#domain as base_domain, so it's more
descriptive
- Removes unnecessary memoization on qa specs
- Changes migration to a post migration to deal better with traffic on
big instances (like gitlab.com)
Diffstat (limited to 'app/models/project_auto_devops.rb')
| -rw-r--r-- | app/models/project_auto_devops.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/app/models/project_auto_devops.rb b/app/models/project_auto_devops.rb index d254ec158ca..b6c5c7c4c87 100644 --- a/app/models/project_auto_devops.rb +++ b/app/models/project_auto_devops.rb @@ -26,7 +26,9 @@ class ProjectAutoDevops < ActiveRecord::Base # From 11.8, AUTO_DEVOPS_DOMAIN has been replaced by KUBE_INGRESS_BASE_DOMAIN. # See Clusters::Cluster#predefined_variables and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24580 - # for more info. Support for AUTO_DEVOPS_DOMAIN support will be dropped on 12.0. + # for more info. + # Support for AUTO_DEVOPS_DOMAIN support will be dropped on 12.0 on + # https://gitlab.com/gitlab-org/gitlab-ce/issues/52363 def predefined_variables Gitlab::Ci::Variables::Collection.new.tap do |variables| if has_domain? |