diff options
author | Kamil Trzciński <ayufan@ayufan.eu> | 2018-12-13 13:25:14 +0100 |
---|---|---|
committer | Kamil Trzciński <ayufan@ayufan.eu> | 2019-01-02 19:02:46 +0100 |
commit | 7ebd36e302e3e6c118f47d18d6c72a83418097d2 (patch) | |
tree | 82cd0c0a8229c40afd86824c1acc6459057d7945 /app/models/merge_request.rb | |
parent | 1a83d9387f6db91f2adae5c3d66c6e21077967bc (diff) | |
download | gitlab-ce-use-after-transition.tar.gz |
Prefer to use after_transitionuse-after-transition
Before_transition does not play nice when used with
OptimisticLocking and this can result in triggering
multiple events
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55306
Diffstat (limited to 'app/models/merge_request.rb')
-rw-r--r-- | app/models/merge_request.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb index b937bef100b..6092c56b925 100644 --- a/app/models/merge_request.rb +++ b/app/models/merge_request.rb @@ -105,7 +105,9 @@ class MergeRequest < ActiveRecord::Base before_transition any => :opened do |merge_request| merge_request.merge_jid = nil + end + after_transition any => :opened do |merge_request| merge_request.run_after_commit do UpdateHeadPipelineForMergeRequestWorker.perform_async(merge_request.id) end |