diff options
| author | Toon Claes <toon@gitlab.com> | 2019-06-28 14:28:29 +0200 |
|---|---|---|
| committer | Toon Claes <toon@gitlab.com> | 2019-06-28 14:28:29 +0200 |
| commit | 288b050e5b226e403f9c88c3fe16fb4279714d69 (patch) | |
| tree | 9b3f96b71cab616d44000c192ab5870098ee6c5f /app/helpers/diff_helper.rb | |
| parent | 046527beb585b8086e8b280dee78f43417b9a753 (diff) | |
| download | gitlab-ce-tc-no-more-try.tar.gz | |
Enable Style/SafeNavigation coptc-no-more-try
I ran `rubocop -a --only Style/SafeNavigation` to correct all.
I could not enable `ConvertTry` cause it does not seem to be supported
by the version we're using.
https://gitlab.com/gitlab-org/gitlab-ce/issues/63875
Diffstat (limited to 'app/helpers/diff_helper.rb')
| -rw-r--r-- | app/helpers/diff_helper.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/app/helpers/diff_helper.rb b/app/helpers/diff_helper.rb index 32431959851..77c2622304c 100644 --- a/app/helpers/diff_helper.rb +++ b/app/helpers/diff_helper.rb @@ -71,12 +71,12 @@ module DiffHelper discussions_left = discussions_right = nil - if left && left.discussable? && (left.unchanged? || left.removed?) + if left&.discussable? && (left.unchanged? || left.removed?) line_code = diff_file.line_code(left) discussions_left = @grouped_diff_discussions[line_code] end - if right && right.discussable? && right.added? + if right&.discussable? && right.added? line_code = diff_file.line_code(right) discussions_right = @grouped_diff_discussions[line_code] end |