summaryrefslogtreecommitdiff
path: root/app/controllers/projects/commit_controller.rb
diff options
context:
space:
mode:
authorLuke Duncalfe <lduncalfe@eml.cc>2019-02-07 12:04:09 +1300
committerLuke Duncalfe <lduncalfe@eml.cc>2019-02-18 11:30:32 +1300
commit19cb1985c76ae756194a05f21af0d02caedb60c2 (patch)
tree717f585ed70cbe61ab6e3a5d136284442d1fb6f0 /app/controllers/projects/commit_controller.rb
parent618b87448e9167f39d8216d1100733cc0fbf020b (diff)
downloadgitlab-ce-19cb1985c76ae756194a05f21af0d02caedb60c2.tar.gz
Removing sensitive properties from ProjectType
defaultBranch and ciConfigPath should only be available to users with the :download_code permission for the Project, as the respository might be private. When implementing the authorize check on these properties, it was found that our current Graphql::Authorize::Instrumentation class does not work with fields that resolve to subclasses of GraphQL::Schema::Scalar, like GraphQL::STRING_TYPE. After discussion with other Create Team members, it has been decided that because the GraphQL API is not GA, to remove these properties from ProjectType, and instead implement them as part of epic https://gitlab.com/groups/gitlab-org/-/epics/711 Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/55316
Diffstat (limited to 'app/controllers/projects/commit_controller.rb')
0 files changed, 0 insertions, 0 deletions