diff options
author | Dan Davison <ddavison@gitlab.com> | 2019-07-18 19:21:03 +0000 |
---|---|---|
committer | Dan Davison <ddavison@gitlab.com> | 2019-07-18 19:21:03 +0000 |
commit | 4caf063122be1cf3d052b443d781b5446eda8426 (patch) | |
tree | 87b517308cc3b9db2853eae0b23a372491c560e4 | |
parent | e2a9d2e8b0e4bf8ddac56a7b7b74f4b4eb0037dd (diff) | |
parent | 0604390a111d6d3410d93a69cbc321a934b21f41 (diff) | |
download | gitlab-ce-4caf063122be1cf3d052b443d781b5446eda8426.tar.gz |
Merge branch 'docs-qa-replace-act-with-perform' into 'master'
Fix QA documentation to refer to perform method
See merge request gitlab-org/gitlab-ce!30872
-rw-r--r-- | doc/development/testing_guide/end_to_end/page_objects.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/testing_guide/end_to_end/page_objects.md b/doc/development/testing_guide/end_to_end/page_objects.md index 29ad49403fe..52957d1a1ab 100644 --- a/doc/development/testing_guide/end_to_end/page_objects.md +++ b/doc/development/testing_guide/end_to_end/page_objects.md @@ -27,7 +27,7 @@ When someone later changes `t.text_field :login` in the view associated with this page to `t.text_field :username` it will generate a different field identifier, what would effectively break all tests. -Because we are using `Page::Main::Login.act { sign_in_using_credentials }` +Because we are using `Page::Main::Login.perform(&:sign_in_using_credentials)` everywhere, when we want to sign into GitLab, the page object is the single source of truth, and we will need to update `fill_in :user_login` to `fill_in :user_username` only in a one place. |