summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEvan Read <eread@gitlab.com>2019-06-10 02:02:52 +0000
committerEvan Read <eread@gitlab.com>2019-06-10 02:02:52 +0000
commit273b8d1eda520ad7c7cb816d1dd55a9499fcf2be (patch)
tree7dd4d67cccac1121f6fd5a8d7be9e9f2bbdbc20f
parente5fb082b18f211421e2ea06aa4076d81595e4e3c (diff)
parent3b2efa41ffcdc7c9d7bfcd15bcd38c7566a2c980 (diff)
downloadgitlab-ce-273b8d1eda520ad7c7cb816d1dd55a9499fcf2be.tar.gz
Merge branch 'patch-32' into 'master'
Clarify that GitLab CI token does not have write permissions See merge request gitlab-org/gitlab-ce!28089
-rw-r--r--doc/user/project/new_ci_build_permissions_model.md9
1 files changed, 5 insertions, 4 deletions
diff --git a/doc/user/project/new_ci_build_permissions_model.md b/doc/user/project/new_ci_build_permissions_model.md
index d36312c9b8d..c07c4099f22 100644
--- a/doc/user/project/new_ci_build_permissions_model.md
+++ b/doc/user/project/new_ci_build_permissions_model.md
@@ -28,10 +28,10 @@ The reasons to do it like that are:
and maximizing security.
With the new behavior, any job that is triggered by the user, is also marked
-with their permissions. When a user does a `git push` or changes files through
+with their read permissions. When a user does a `git push` or changes files through
the web UI, a new pipeline will be usually created. This pipeline will be marked
as created be the pusher (local push or via the UI) and any job created in this
-pipeline will have the permissions of the pusher.
+pipeline will have the read permissions of the pusher but not write permissions.
This allows us to make it really easy to evaluate the access for all projects
that have [Git submodules][gitsub] or are using container images that the pusher
@@ -67,9 +67,10 @@ Let's consider the following scenario:
## Job token
-A unique job token is generated for each job and it allows the user to
+A unique job token is generated for each job and provides the user read
access all projects that would be normally accessible to the user creating that
-job.
+job. The unique job token does not have any write permissions, but there
+is a [proposal to add support](https://gitlab.com/gitlab-org/gitlab-ce/issues/18106).
We try to make sure that this token doesn't leak by: