diff options
| author | Jarka Kadlecová <jarka@gitlab.com> | 2018-08-21 11:51:13 +0200 |
|---|---|---|
| committer | Jarka Košanová <jarka@gitlab.com> | 2018-10-01 14:46:17 +0200 |
| commit | 751fd59d39de35af03b99da506a161cc65025268 (patch) | |
| tree | a26d2e5da9aee4a847f49790b09f316c51329e0b | |
| parent | 39d2f186a7cceb75ee0b18a9bb21447efb5d4262 (diff) | |
| download | gitlab-ce-ready-for-review-doc.tar.gz | |
Add documentation how to assign a merge request for reviewready-for-review-doc
| -rw-r--r-- | doc/development/code_review.md | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index edf0b6f46df..160c20fff40 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -97,6 +97,18 @@ first time. branch. Do not squash until the branch is ready to merge. Reviewers should be able to read individual updates based on their earlier feedback. +### Assignning a merge request for a review + +If you want to have your merge request reviewed you can assign it to any reviewer. The list of reviewers can be found on [Egineering projects](https://about.gitlab.com/handbook/engineering/projects/) page. + +You can also use `ready for review` label. That means that your merge request is ready to be reviewed and any reviewer can pick it. + +When your merge request was reviewed and can be passed to a maintainer you can either pick a specific maintainer or use a label `ready for merge`. + +### List of merge requests ready for review + +If you have capacity to review a merge request you can find one in a list of [merge requests to review](https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=all&utf8=%E2%9C%93&state=opened&label_name%5B%5D=ready%20for%20review&assignee_id=0). + ### Reviewing code Understand why the change is necessary (fixes a bug, improves the user |