diff options
author | Douwe Maan <douwe@selenight.nl> | 2018-06-20 16:34:19 +0200 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2018-06-20 16:34:19 +0200 |
commit | 1753efbc143d18fe0c29e33319b8779c1d03f7c6 (patch) | |
tree | 2e83228add89acecfe92b213349f4250f8ce1565 | |
parent | 96f8ad0683619bb852931f4005f0b83c8337e8e6 (diff) | |
download | gitlab-ce-dm-label-reference-period.tar.gz |
Add spec for more examples of trailing punctuation that should be ignoreddm-label-reference-period
-rw-r--r-- | spec/lib/banzai/filter/label_reference_filter_spec.rb | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/spec/lib/banzai/filter/label_reference_filter_spec.rb b/spec/lib/banzai/filter/label_reference_filter_spec.rb index f34d3dc935b..00257ed7904 100644 --- a/spec/lib/banzai/filter/label_reference_filter_spec.rb +++ b/spec/lib/banzai/filter/label_reference_filter_spec.rb @@ -148,9 +148,11 @@ describe Banzai::Filter::LabelReferenceFilter do expect(doc.text).to eq 'See ?g.fm&' end - it 'links with adjacent text' do - doc = reference_filter("Label #{reference}.") - expect(doc.to_html).to match(%r(<a.+><span.+>\?g\.fm&</span></a>\.)) + it 'does not include trailing punctuation', :aggregate_failures do + ['.', ', ok?', '...', '?', '!', ': is that ok?'].each do |trailing_punctuation| + doc = filter("Label #{reference}#{trailing_punctuation}") + expect(doc.to_html).to match(%r(<a.+><span.+>\?g\.fm&</span></a>#{Regexp.escape(trailing_punctuation)})) + end end it 'ignores invalid label names' do |