diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-08-08 03:04:09 +0000 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-08-08 08:43:19 +0530 |
| commit | c78640890cae5ca6f17e75c0e034503ff0de7cc9 (patch) | |
| tree | 23c5cf3abc2f654af8d7017f97d91f3668887f42 | |
| parent | 91030230545a199a86c2742600a7a2e68ef75c98 (diff) | |
| download | gitlab-ce-add-mr-migration-guidelines.tar.gz | |
Add migration-related tips to the "Merge Request Guidelines" docadd-mr-migration-guidelines
[ci-skip]
| -rw-r--r-- | CONTRIBUTING.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2f522c1e39a..d94673e82ce 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -336,6 +336,10 @@ request is as follows: 1. If your code creates new files on disk please read the [shared files guidelines](doc/development/shared_files.md). 1. When writing commit messages please follow [these](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) [guidelines](http://chris.beams.io/posts/git-commit/). +1. If your merge request adds one or more migrations, make sure to execute all + migrations on a fresh database before the MR is reviewed. If the review leads + to large changes in the MR, do this again once the review is complete. +1. For more complex migrations, write tests. The **official merge window** is in the beginning of the month from the 1st to the 7th day of the month. This is the best time to submit an MR and get |