diff options
| author | Eric Sunshine <sunshine@sunshineco.com> | 2021-12-09 00:11:13 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-12-13 10:29:48 -0800 |
| commit | cbe1d9d630e529d3dd240eacf3d1c9799fef702b (patch) | |
| tree | 5aaa08925285248af953dc01916f33b26d0eb142 /t/t4124-apply-ws-rule.sh | |
| parent | db5875aa9fe056c2db3a463989091c5f70d6c8d1 (diff) | |
| download | git-cbe1d9d630e529d3dd240eacf3d1c9799fef702b.tar.gz | |
t4000-t4999: detect and signal failure within loop
Failures within `for` and `while` loops can go unnoticed if not detected
and signaled manually since the loop itself does not abort when a
contained command fails, nor will a failure necessarily be detected when
the loop finishes since the loop returns the exit code of the last
command it ran on the final iteration, which may not be the command
which failed. Therefore, detect and signal failures manually within
loops using the idiom `|| return 1` (or `|| exit 1` within subshells).
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4124-apply-ws-rule.sh')
| -rwxr-xr-x | t/t4124-apply-ws-rule.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t4124-apply-ws-rule.sh b/t/t4124-apply-ws-rule.sh index ec5c10d2a0..485c7d2d12 100755 --- a/t/t4124-apply-ws-rule.sh +++ b/t/t4124-apply-ws-rule.sh @@ -333,7 +333,7 @@ test_expect_success 'applying beyond EOF requires one non-blank context line' ' test_expect_success 'tons of blanks at EOF should not apply' ' for i in 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16; do - test_write_lines "" "" "" "" + test_write_lines "" "" "" "" || return 1 done >one && git add one && echo a >>one && @@ -396,7 +396,7 @@ test_expect_success 'shrink file with tons of missing blanks at end of file' ' test_write_lines a b c >one && cp one no-blank-lines && for i in 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16; do - test_write_lines "" "" "" "" + test_write_lines "" "" "" "" || return 1 done >>one && git add one && echo a >one && |