summaryrefslogtreecommitdiff
path: root/string-list.c
diff options
context:
space:
mode:
authorJeff Hostetler <jeffhost@microsoft.com>2017-04-14 19:51:52 +0000
committerJunio C Hamano <gitster@pobox.com>2017-04-15 02:04:41 -0700
commit950a234cbd781021d69fcfaa40ab6fd258b1d917 (patch)
treedcb1101fb59ad382f5c1a14b41bd2f457aeeac00 /string-list.c
parent3b9e3c2cede15057af3ff8076c45ad5f33829436 (diff)
downloadgit-950a234cbd781021d69fcfaa40ab6fd258b1d917.tar.gz
string-list: use ALLOC_GROW macro when reallocing string_listjh/string-list-micro-optim
Use ALLOC_GROW() macro when reallocing a string_list array rather than simply increasing it by 32. This is a performance optimization. During status on a very large repo and there are many changes, a significant percentage of the total run time is spent reallocing the wt_status.changes array. This change decreases the time in wt_status_collect_changes_worktree() from 125 seconds to 45 seconds on my very large repository. This produced a modest gain on my 1M file artificial repo, but broke even on linux.git. Test HEAD^^ HEAD --------------------------------------------------------------------------------------- 0005.2: read-tree status br_ballast (1000001) 8.29(5.62+2.62) 8.22(5.57+2.63) -0.8% Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'string-list.c')
-rw-r--r--string-list.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/string-list.c b/string-list.c
index 8c83cac189..1e27d9cec3 100644
--- a/string-list.c
+++ b/string-list.c
@@ -41,10 +41,7 @@ static int add_entry(int insert_at, struct string_list *list, const char *string
if (exact_match)
return -1 - index;
- if (list->nr + 1 >= list->alloc) {
- list->alloc += 32;
- REALLOC_ARRAY(list->items, list->alloc);
- }
+ ALLOC_GROW(list->items, list->nr+1, list->alloc);
if (index < list->nr)
memmove(list->items + index + 1, list->items + index,
(list->nr - index)