summaryrefslogtreecommitdiff
path: root/builtin-add.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2008-07-20 00:21:38 -0700
committerJunio C Hamano <gitster@pobox.com>2008-07-20 17:21:32 -0700
commitd14e7407b34b8c11b407358b9677c283c381a71c (patch)
tree2ea98209de908a49d8841a7fc6ccb1e5b186795e /builtin-add.c
parent559e840b74dbbf39633aa68627937a5f7a6d4145 (diff)
downloadgit-d14e7407b34b8c11b407358b9677c283c381a71c.tar.gz
"needs update" considered harmful
"git update-index --refresh", "git reset" and "git add --refresh" have reported paths that have local modifications as "needs update" since the beginning of git. Although this is logically correct in that you need to update the index at that path before you can commit that change, it is now becoming more and more clear, especially with the continuous push for user friendliness since 1.5.0 series, that the message is suboptimal. After all, the change may be something the user might want to get rid of, and "updating" would be absolutely a wrong thing to do if that is the case. I prepared two alternatives to solve this. Both aim to reword the message to more neutral "locally modified". This patch is a more intrusive variant that changes the message for only Porcelain commands ("add" and "reset") while keeping the plumbing "update-index" intact. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-add.c')
-rw-r--r--builtin-add.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin-add.c b/builtin-add.c
index bf13aa3ad6..0800b14ac6 100644
--- a/builtin-add.c
+++ b/builtin-add.c
@@ -142,7 +142,8 @@ static void refresh(int verbose, const char **pathspec)
seen = xcalloc(specs, 1);
if (read_cache() < 0)
die("index file corrupt");
- refresh_index(&the_index, verbose ? 0 : REFRESH_QUIET, pathspec, seen);
+ refresh_index(&the_index, verbose ? REFRESH_SAY_CHANGED : REFRESH_QUIET,
+ pathspec, seen);
for (i = 0; i < specs; i++) {
if (!seen[i])
die("pathspec '%s' did not match any files", pathspec[i]);