diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2014-03-25 10:22:22 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-03-25 13:42:52 -0700 |
| commit | b09d8552bd04b17c20f89b73e09206719f9e7b84 (patch) | |
| tree | 57e1d55295470a7fa2c69084c5cb1f25ad2f6f66 | |
| parent | d393d140b5656e608b332c00ea3b14f9a060d604 (diff) | |
| download | git-b09d8552bd04b17c20f89b73e09206719f9e7b84.tar.gz | |
check-builtins.sh: use the $(...) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | check-builtins.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/check-builtins.sh b/check-builtins.sh index d6fe6cf174..07cff69d8e 100755 --- a/check-builtins.sh +++ b/check-builtins.sh @@ -14,8 +14,8 @@ sort | bad=0 while read builtin do - base=`expr "$builtin" : 'git-\(.*\)'` - x=`sed -ne 's/.*{ "'$base'", \(cmd_[^, ]*\).*/'$base' \1/p' git.c` + base=$(expr "$builtin" : 'git-\(.*\)') + x=$(sed -ne 's/.*{ "'$base'", \(cmd_[^, ]*\).*/'$base' \1/p' git.c) if test -z "$x" then echo "$base is builtin but not listed in git.c command list" |