diff options
| author | Jonathan Tan <jonathantanmy@google.com> | 2016-11-10 16:13:28 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-11-11 09:36:23 -0800 |
| commit | 6cc823c5c15911b27a410cfd47abc81cc10c0003 (patch) | |
| tree | 1e0702ed382438e161d7a5e335a15cc92a5217b5 | |
| parent | 0b65a8dbdb38962e700ee16776a3042beb489060 (diff) | |
| download | git-jt/fetch-no-redundant-tag-fetch-map.tar.gz | |
fetch: do not redundantly calculate tag refmapjt/fetch-no-redundant-tag-fetch-map
builtin/fetch.c redundantly calculates refmaps for tags twice. Remove
the first calculation.
This is only a code simplification and slight performance improvement -
the result is unchanged, as the redundant refmaps are subsequently
removed by the invocation to "ref_remove_duplicates" anyway.
This was introduced in commit c5a84e9 ("fetch --tags: fetch tags *in
addition to* other stuff", 2013-10-29) when modifying the effect of the
--tags parameter to "git fetch". The refmap-for-tag calculation was
copied instead of moved.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/fetch.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/builtin/fetch.c b/builtin/fetch.c index e4639d8eb1..606364593e 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -347,9 +347,6 @@ static struct ref *get_ref_map(struct transport *transport, for (i = 0; i < fetch_refspec_nr; i++) get_fetch_map(ref_map, &fetch_refspec[i], &oref_tail, 1); - - if (tags == TAGS_SET) - get_fetch_map(remote_refs, tag_refspec, &tail, 0); } else if (refmap_array) { die("--refmap option is only meaningful with command-line refspec(s)."); } else { |