summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRamsay Jones <ramsay@ramsayjones.plus.com>2016-06-09 23:52:22 +0100
committerJunio C Hamano <gitster@pobox.com>2016-06-10 10:54:27 -0700
commitb333d0d6f450d4f9c4535fd9fd6e0f4ef367507c (patch)
tree22a07e4fc7a1d8b83cb02467f61b69714fb6f38a
parentf0bca72dc77f62d61fc355bd6fe6e32b194950b8 (diff)
downloadgit-jk/send-pack-stdio.tar.gz
write_or_die: remove the unused write_or_whine() functionjk/send-pack-stdio
Now the last caller of this function is gone, and new ones are unlikely to appear, because this function is doing very little that a regular if() does not besides obfuscating the error message (and if we ever did want something like it, we would probably prefer the function to come back with more "normal" return value semantics). Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--cache.h1
-rw-r--r--write_or_die.c11
2 files changed, 0 insertions, 12 deletions
diff --git a/cache.h b/cache.h
index 4ff196c259..5e5c1df1a7 100644
--- a/cache.h
+++ b/cache.h
@@ -1715,7 +1715,6 @@ extern int copy_file(const char *dst, const char *src, int mode);
extern int copy_file_with_time(const char *dst, const char *src, int mode);
extern void write_or_die(int fd, const void *buf, size_t count);
-extern int write_or_whine(int fd, const void *buf, size_t count, const char *msg);
extern int write_or_whine_pipe(int fd, const void *buf, size_t count, const char *msg);
extern void fsync_or_die(int fd, const char *);
diff --git a/write_or_die.c b/write_or_die.c
index 49e80aa222..981687945a 100644
--- a/write_or_die.c
+++ b/write_or_die.c
@@ -94,14 +94,3 @@ int write_or_whine_pipe(int fd, const void *buf, size_t count, const char *msg)
return 1;
}
-
-int write_or_whine(int fd, const void *buf, size_t count, const char *msg)
-{
- if (write_in_full(fd, buf, count) < 0) {
- fprintf(stderr, "%s: write error (%s)\n",
- msg, strerror(errno));
- return 0;
- }
-
- return 1;
-}