diff options
| author | Eric Sunshine <sunshine@sunshineco.com> | 2016-08-02 06:52:53 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-08-03 08:52:46 -0700 |
| commit | aa59e14b23b3c075e7f50eae73d9c6812ed96959 (patch) | |
| tree | f3266b13aa025f6431c916924330f2be7de78264 | |
| parent | 64093fc06a871f71316211a2aea6bb46c49b20ab (diff) | |
| download | git-jk/parseopt-string-list.tar.gz | |
blame: drop strdup of string literaljk/parseopt-string-list
This strdup was added as part of 58dbfa2 (blame: accept
multiple -L ranges, 2013-08-06) to be consistent with
parse_opt_string_list(), which appends to the same list.
But as of 7a7a517 (parse_opt_string_list: stop allocating
new strings, 2016-06-13), we should stop using strdup (to
match parse_opt_string_list, and for all the reasons
described in that commit; namely that it does nothing useful
and causes us to leak the memory).
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/blame.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/blame.c b/builtin/blame.c index 9b1701d314..f3fe92643c 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -2748,7 +2748,7 @@ parse_done: lno = prepare_lines(&sb); if (lno && !range_list.nr) - string_list_append(&range_list, xstrdup("1")); + string_list_append(&range_list, "1"); anchor = 1; range_set_init(&ranges, range_list.nr); |